* Re: [PATCH] thermal/drivers/imx9: Constify struct thermal_zone_device_ops
[not found] <5cce9ea713edcf2aa3c0efd5d31e9d9fd9f40a88.1786220585.git.christophe.jaillet@wanadoo.fr>
@ 2026-08-10 19:09 ` Frank Li
2026-09-18 10:16 ` Daniel Lezcano
1 sibling, 0 replies; 2+ messages in thread
From: Frank Li @ 2026-08-10 19:09 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
linux-kernel, kernel-janitors, linux-pm, imx, linux-arm-kernel
On Sat, Aug 08, 2026 at 10:23:33PM +0200, Christophe JAILLET wrote:
> 'struct thermal_zone_device_ops' is not modified in this driver.
>
> Constifying this structure moves some data to a read-only section, so
> increases overall security, especially when the structure holds some
> function pointers.
>
> On a x86_64, with allmodconfig:
> Before:
> ======
> text data bss dec hex filename
> 8567 2144 0 10711 29d7 drivers/thermal/imx91_thermal.o
>
> After:
> =====
> text data bss dec hex filename
> 8695 2016 0 10711 29d7 drivers/thermal/imx91_thermal.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Compile tested only.
> ---
> drivers/thermal/imx91_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/imx91_thermal.c b/drivers/thermal/imx91_thermal.c
> index 25915bb702be..892a25440e06 100644
> --- a/drivers/thermal/imx91_thermal.c
> +++ b/drivers/thermal/imx91_thermal.c
> @@ -225,7 +225,7 @@ static int imx91_tmu_change_mode(struct thermal_zone_device *tz, enum thermal_de
> return 0;
> }
>
> -static struct thermal_zone_device_ops tmu_tz_ops = {
> +static const struct thermal_zone_device_ops tmu_tz_ops = {
> .get_temp = imx91_tmu_get_temp,
> .change_mode = imx91_tmu_change_mode,
> .set_trips = imx91_tmu_set_trips,
> --
> 2.55.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] thermal/drivers/imx9: Constify struct thermal_zone_device_ops
[not found] <5cce9ea713edcf2aa3c0efd5d31e9d9fd9f40a88.1786220585.git.christophe.jaillet@wanadoo.fr>
2026-08-10 19:09 ` [PATCH] thermal/drivers/imx9: Constify struct thermal_zone_device_ops Frank Li
@ 2026-09-18 10:16 ` Daniel Lezcano
1 sibling, 0 replies; 2+ messages in thread
From: Daniel Lezcano @ 2026-09-18 10:16 UTC (permalink / raw)
To: Christophe JAILLET, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
Lukasz Luba, Frank Li, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam
Cc: linux-kernel, kernel-janitors, linux-pm, imx, linux-arm-kernel
On 8/8/26 22:23, Christophe JAILLET wrote:
> 'struct thermal_zone_device_ops' is not modified in this driver.
>
> Constifying this structure moves some data to a read-only section, so
> increases overall security, especially when the structure holds some
> function pointers.
>
> On a x86_64, with allmodconfig:
> Before:
> ======
> text data bss dec hex filename
> 8567 2144 0 10711 29d7 drivers/thermal/imx91_thermal.o
>
> After:
> =====
> text data bss dec hex filename
> 8695 2016 0 10711 29d7 drivers/thermal/imx91_thermal.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread