* [PATCH v3 1/7] ARM: dts: samsung: exynos4210-i9100: Replace clock-frequency in camera sensor node
2026-08-10 18:05 [PATCH v3 0/7] ARM: dts: Replace clock-frequency in camera sensor nodes Laurent Pinchart
@ 2026-08-10 18:05 ` Laurent Pinchart
2026-08-10 18:05 ` [PATCH v3 2/7] ARM: dts: samsung: exynos4412-midas: " Laurent Pinchart
` (5 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Laurent Pinchart @ 2026-08-10 18:05 UTC (permalink / raw)
To: linux-arm-kernel
Cc: devicetree, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jacopo Mondi, Sakari Ailus, Peter Griffin, Alim Akhtar,
linux-samsung-soc
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. Replace it in
the device tree.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/samsung/exynos4210-i9100.dts | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
index 8a635bee59fa..067a3264edf3 100644
--- a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
+++ b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
@@ -169,11 +169,14 @@ image-sensor@2d {
vdda-supply = <&cam_io_en_reg>;
vddreg-supply = <&vt_core_15v_reg>;
vddio-supply = <&vtcam_reg>;
+
clocks = <&camera 0>;
clock-names = "mclk";
+ assigned-clocks = <&camera 0>;
+ assigned-clock-rates = <24000000>;
+
stbyn-gpios = <&gpl2 0 GPIO_ACTIVE_LOW>;
rstn-gpios = <&gpl2 1 GPIO_ACTIVE_LOW>;
- clock-frequency = <24000000>;
port {
s5k5bafx_ep: endpoint {
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v3 2/7] ARM: dts: samsung: exynos4412-midas: Replace clock-frequency in camera sensor node
2026-08-10 18:05 [PATCH v3 0/7] ARM: dts: Replace clock-frequency in camera sensor nodes Laurent Pinchart
2026-08-10 18:05 ` [PATCH v3 1/7] ARM: dts: samsung: exynos4210-i9100: Replace clock-frequency in camera sensor node Laurent Pinchart
@ 2026-08-10 18:05 ` Laurent Pinchart
2026-08-10 18:06 ` [PATCH v3 3/7] ARM: dts: ti: omap3-n950: " Laurent Pinchart
` (4 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Laurent Pinchart @ 2026-08-10 18:05 UTC (permalink / raw)
To: linux-arm-kernel
Cc: devicetree, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jacopo Mondi, Sakari Ailus, Peter Griffin, Alim Akhtar,
linux-samsung-soc
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. Replace it in
the device tree.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/samsung/exynos4412-midas.dtsi | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
index 48245b1665a6..8b6c2e2baed4 100644
--- a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
@@ -638,10 +638,13 @@ image-sensor@10 {
svdda-supply = <&cam_io_reg>;
svddio-supply = <&ldo19_reg>;
afvdd-supply = <&ldo19_reg>;
- clock-frequency = <24000000>;
+
/* CAM_B_CLKOUT */
clocks = <&camera 1>;
clock-names = "extclk";
+ assigned-clocks = <&camera 1>;
+ assigned-clock-rates = <24000000>;
+
gpios = <&gpm1 6 GPIO_ACTIVE_LOW>;
port {
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v3 3/7] ARM: dts: ti: omap3-n950: Replace clock-frequency in camera sensor node
2026-08-10 18:05 [PATCH v3 0/7] ARM: dts: Replace clock-frequency in camera sensor nodes Laurent Pinchart
2026-08-10 18:05 ` [PATCH v3 1/7] ARM: dts: samsung: exynos4210-i9100: Replace clock-frequency in camera sensor node Laurent Pinchart
2026-08-10 18:05 ` [PATCH v3 2/7] ARM: dts: samsung: exynos4412-midas: " Laurent Pinchart
@ 2026-08-10 18:06 ` Laurent Pinchart
2026-08-11 18:31 ` Aaro Koskinen
2026-08-10 18:06 ` [PATCH v3 4/7] ARM: dts: ti: omap3-n9: " Laurent Pinchart
` (3 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Laurent Pinchart @ 2026-08-10 18:06 UTC (permalink / raw)
To: linux-arm-kernel
Cc: devicetree, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jacopo Mondi, Sakari Ailus, Aaro Koskinen, Andreas Kemnade,
Kevin Hilman, Roger Quadros, Tony Lindgren, linux-omap
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. Replace it in
the device tree.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/ti/omap/omap3-n950.dts | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ti/omap/omap3-n950.dts b/arch/arm/boot/dts/ti/omap/omap3-n950.dts
index b99f97880204..2864ed8dd6c3 100644
--- a/arch/arm/boot/dts/ti/omap/omap3-n950.dts
+++ b/arch/arm/boot/dts/ti/omap/omap3-n950.dts
@@ -74,8 +74,11 @@ smia_1: camera@10 {
reg = <0x10>;
/* No reset gpio */
vana-supply = <&vaux3>;
+
clocks = <&isp 0>;
- clock-frequency = <9600000>;
+ assigned-clocks = <&isp 0>;
+ assigned-clock-rates = <9600000>;
+
flash-leds = <&as3645a_flash &as3645a_indicator>;
port {
smia_1_1: endpoint {
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v3 3/7] ARM: dts: ti: omap3-n950: Replace clock-frequency in camera sensor node
2026-08-10 18:06 ` [PATCH v3 3/7] ARM: dts: ti: omap3-n950: " Laurent Pinchart
@ 2026-08-11 18:31 ` Aaro Koskinen
0 siblings, 0 replies; 14+ messages in thread
From: Aaro Koskinen @ 2026-08-11 18:31 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel, devicetree, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jacopo Mondi, Sakari Ailus, Andreas Kemnade,
Kevin Hilman, Roger Quadros, Tony Lindgren, linux-omap
On Mon, Aug 10, 2026 at 09:06:00PM +0300, Laurent Pinchart wrote:
> The clock-frequency for camera sensors has been deprecated in favour of
> the assigned-clocks and assigned-clock-rates properties. Replace it in
> the device tree.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
A.
> ---
> arch/arm/boot/dts/ti/omap/omap3-n950.dts | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/ti/omap/omap3-n950.dts b/arch/arm/boot/dts/ti/omap/omap3-n950.dts
> index b99f97880204..2864ed8dd6c3 100644
> --- a/arch/arm/boot/dts/ti/omap/omap3-n950.dts
> +++ b/arch/arm/boot/dts/ti/omap/omap3-n950.dts
> @@ -74,8 +74,11 @@ smia_1: camera@10 {
> reg = <0x10>;
> /* No reset gpio */
> vana-supply = <&vaux3>;
> +
> clocks = <&isp 0>;
> - clock-frequency = <9600000>;
> + assigned-clocks = <&isp 0>;
> + assigned-clock-rates = <9600000>;
> +
> flash-leds = <&as3645a_flash &as3645a_indicator>;
> port {
> smia_1_1: endpoint {
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3 4/7] ARM: dts: ti: omap3-n9: Replace clock-frequency in camera sensor node
2026-08-10 18:05 [PATCH v3 0/7] ARM: dts: Replace clock-frequency in camera sensor nodes Laurent Pinchart
` (2 preceding siblings ...)
2026-08-10 18:06 ` [PATCH v3 3/7] ARM: dts: ti: omap3-n950: " Laurent Pinchart
@ 2026-08-10 18:06 ` Laurent Pinchart
2026-08-11 18:32 ` Aaro Koskinen
2026-08-10 18:06 ` [PATCH v3 5/7] ARM: dts: ti: omap3-n900: " Laurent Pinchart
` (2 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Laurent Pinchart @ 2026-08-10 18:06 UTC (permalink / raw)
To: linux-arm-kernel
Cc: devicetree, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jacopo Mondi, Sakari Ailus, Aaro Koskinen, Andreas Kemnade,
Kevin Hilman, Roger Quadros, Tony Lindgren, linux-omap
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. Replace it in
the device tree.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/ti/omap/omap3-n9.dts | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ti/omap/omap3-n9.dts b/arch/arm/boot/dts/ti/omap/omap3-n9.dts
index a3cf3f443785..2edc1933449b 100644
--- a/arch/arm/boot/dts/ti/omap/omap3-n9.dts
+++ b/arch/arm/boot/dts/ti/omap/omap3-n9.dts
@@ -21,8 +21,11 @@ smia_1: camera@10 {
reg = <0x10>;
/* No reset gpio */
vana-supply = <&vaux3>;
+
clocks = <&isp 0>;
- clock-frequency = <9600000>;
+ assigned-clocks = <&isp 0>;
+ assigned-clock-rates = <9600000>;
+
flash-leds = <&as3645a_flash &as3645a_indicator>;
port {
smia_1_1: endpoint {
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v3 4/7] ARM: dts: ti: omap3-n9: Replace clock-frequency in camera sensor node
2026-08-10 18:06 ` [PATCH v3 4/7] ARM: dts: ti: omap3-n9: " Laurent Pinchart
@ 2026-08-11 18:32 ` Aaro Koskinen
0 siblings, 0 replies; 14+ messages in thread
From: Aaro Koskinen @ 2026-08-11 18:32 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel, devicetree, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jacopo Mondi, Sakari Ailus, Andreas Kemnade,
Kevin Hilman, Roger Quadros, Tony Lindgren, linux-omap
Hi,
On Mon, Aug 10, 2026 at 09:06:01PM +0300, Laurent Pinchart wrote:
> The clock-frequency for camera sensors has been deprecated in favour of
> the assigned-clocks and assigned-clock-rates properties. Replace it in
> the device tree.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
A.
> ---
> arch/arm/boot/dts/ti/omap/omap3-n9.dts | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/ti/omap/omap3-n9.dts b/arch/arm/boot/dts/ti/omap/omap3-n9.dts
> index a3cf3f443785..2edc1933449b 100644
> --- a/arch/arm/boot/dts/ti/omap/omap3-n9.dts
> +++ b/arch/arm/boot/dts/ti/omap/omap3-n9.dts
> @@ -21,8 +21,11 @@ smia_1: camera@10 {
> reg = <0x10>;
> /* No reset gpio */
> vana-supply = <&vaux3>;
> +
> clocks = <&isp 0>;
> - clock-frequency = <9600000>;
> + assigned-clocks = <&isp 0>;
> + assigned-clock-rates = <9600000>;
> +
> flash-leds = <&as3645a_flash &as3645a_indicator>;
> port {
> smia_1_1: endpoint {
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3 5/7] ARM: dts: ti: omap3-n900: Replace clock-frequency in camera sensor node
2026-08-10 18:05 [PATCH v3 0/7] ARM: dts: Replace clock-frequency in camera sensor nodes Laurent Pinchart
` (3 preceding siblings ...)
2026-08-10 18:06 ` [PATCH v3 4/7] ARM: dts: ti: omap3-n9: " Laurent Pinchart
@ 2026-08-10 18:06 ` Laurent Pinchart
2026-08-11 18:32 ` Aaro Koskinen
2026-08-10 18:06 ` [PATCH v3 6/7] ARM: dts: nxp: imx6qdl-pico: " Laurent Pinchart
2026-08-10 18:06 ` [PATCH v3 7/7] ARM: dts: nxp: imx6qdl-wandboard: " Laurent Pinchart
6 siblings, 1 reply; 14+ messages in thread
From: Laurent Pinchart @ 2026-08-10 18:06 UTC (permalink / raw)
To: linux-arm-kernel
Cc: devicetree, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jacopo Mondi, Sakari Ailus, Aaro Koskinen, Andreas Kemnade,
Kevin Hilman, Roger Quadros, Tony Lindgren, linux-omap
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. Replace it in
the device tree.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/ti/omap/omap3-n900.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ti/omap/omap3-n900.dts b/arch/arm/boot/dts/ti/omap/omap3-n900.dts
index 7db73d9bed9e..97e9eae2b60e 100644
--- a/arch/arm/boot/dts/ti/omap/omap3-n900.dts
+++ b/arch/arm/boot/dts/ti/omap/omap3-n900.dts
@@ -792,7 +792,8 @@ cam1: camera@3e {
clocks = <&isp 0>;
clock-names = "extclk";
- clock-frequency = <9600000>;
+ assigned-clocks = <&isp 0>;
+ assigned-clock-rates = <9600000>;
reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v3 5/7] ARM: dts: ti: omap3-n900: Replace clock-frequency in camera sensor node
2026-08-10 18:06 ` [PATCH v3 5/7] ARM: dts: ti: omap3-n900: " Laurent Pinchart
@ 2026-08-11 18:32 ` Aaro Koskinen
0 siblings, 0 replies; 14+ messages in thread
From: Aaro Koskinen @ 2026-08-11 18:32 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel, devicetree, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jacopo Mondi, Sakari Ailus, Andreas Kemnade,
Kevin Hilman, Roger Quadros, Tony Lindgren, linux-omap
Hi,
On Mon, Aug 10, 2026 at 09:06:02PM +0300, Laurent Pinchart wrote:
> The clock-frequency for camera sensors has been deprecated in favour of
> the assigned-clocks and assigned-clock-rates properties. Replace it in
> the device tree.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
A.
> ---
> arch/arm/boot/dts/ti/omap/omap3-n900.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/ti/omap/omap3-n900.dts b/arch/arm/boot/dts/ti/omap/omap3-n900.dts
> index 7db73d9bed9e..97e9eae2b60e 100644
> --- a/arch/arm/boot/dts/ti/omap/omap3-n900.dts
> +++ b/arch/arm/boot/dts/ti/omap/omap3-n900.dts
> @@ -792,7 +792,8 @@ cam1: camera@3e {
>
> clocks = <&isp 0>;
> clock-names = "extclk";
> - clock-frequency = <9600000>;
> + assigned-clocks = <&isp 0>;
> + assigned-clock-rates = <9600000>;
>
> reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
>
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3 6/7] ARM: dts: nxp: imx6qdl-pico: Replace clock-frequency in camera sensor node
2026-08-10 18:05 [PATCH v3 0/7] ARM: dts: Replace clock-frequency in camera sensor nodes Laurent Pinchart
` (4 preceding siblings ...)
2026-08-10 18:06 ` [PATCH v3 5/7] ARM: dts: ti: omap3-n900: " Laurent Pinchart
@ 2026-08-10 18:06 ` Laurent Pinchart
2026-08-10 18:55 ` Frank Li
2026-08-10 18:06 ` [PATCH v3 7/7] ARM: dts: nxp: imx6qdl-wandboard: " Laurent Pinchart
6 siblings, 1 reply; 14+ messages in thread
From: Laurent Pinchart @ 2026-08-10 18:06 UTC (permalink / raw)
To: linux-arm-kernel
Cc: devicetree, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jacopo Mondi, Sakari Ailus, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, imx
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. Replace it in
the device tree.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Changes since v1:
- Drop added blank line
---
arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
index ca4cb986efbc..0cc05d084f9b 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
@@ -233,7 +233,9 @@ camera@3c {
pinctrl-0 = <&pinctrl_ov5645>;
reg = <0x3c>;
clocks = <&clks IMX6QDL_CLK_CKO2>;
- clock-frequency = <24000000>;
+ assigned-clocks = <&clks IMX6QDL_CLK_CKO2>;
+ assigned-clock-rates = <24000000>;
+
vdddo-supply = <®_1p8v>;
vdda-supply = <®_2p8v>;
vddd-supply = <®_1p5v>;
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v3 6/7] ARM: dts: nxp: imx6qdl-pico: Replace clock-frequency in camera sensor node
2026-08-10 18:06 ` [PATCH v3 6/7] ARM: dts: nxp: imx6qdl-pico: " Laurent Pinchart
@ 2026-08-10 18:55 ` Frank Li
2026-08-10 19:08 ` Laurent Pinchart
0 siblings, 1 reply; 14+ messages in thread
From: Frank Li @ 2026-08-10 18:55 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel, devicetree, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jacopo Mondi, Sakari Ailus, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, imx
On Mon, Aug 10, 2026 at 09:06:03PM +0300, Laurent Pinchart wrote:
> The clock-frequency for camera sensors has been deprecated in favour of
> the assigned-clocks and assigned-clock-rates properties. Replace it in
> the device tree.
Remove "clock-frequency" may break back compatiblity.
A similar case
https://lore.kernel.org/imx/20d37ab7-308e-4f07-96dc-7ae011af76d0@kernel.org/
https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/
Need provide judgement in commit message about impact of break ABI.
Frank
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v1:
>
> - Drop added blank line
> ---
> arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> index ca4cb986efbc..0cc05d084f9b 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> @@ -233,7 +233,9 @@ camera@3c {
> pinctrl-0 = <&pinctrl_ov5645>;
> reg = <0x3c>;
> clocks = <&clks IMX6QDL_CLK_CKO2>;
> - clock-frequency = <24000000>;
> + assigned-clocks = <&clks IMX6QDL_CLK_CKO2>;
> + assigned-clock-rates = <24000000>;
> +
> vdddo-supply = <®_1p8v>;
> vdda-supply = <®_2p8v>;
> vddd-supply = <®_1p5v>;
> --
> Regards,
>
> Laurent Pinchart
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v3 6/7] ARM: dts: nxp: imx6qdl-pico: Replace clock-frequency in camera sensor node
2026-08-10 18:55 ` Frank Li
@ 2026-08-10 19:08 ` Laurent Pinchart
2026-08-11 16:51 ` Frank Li
0 siblings, 1 reply; 14+ messages in thread
From: Laurent Pinchart @ 2026-08-10 19:08 UTC (permalink / raw)
To: Frank Li
Cc: linux-arm-kernel, devicetree, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jacopo Mondi, Sakari Ailus, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, imx
On Mon, Aug 10, 2026 at 01:55:41PM -0500, Frank Li wrote:
> On Mon, Aug 10, 2026 at 09:06:03PM +0300, Laurent Pinchart wrote:
> > The clock-frequency for camera sensors has been deprecated in favour of
> > the assigned-clocks and assigned-clock-rates properties. Replace it in
> > the device tree.
>
> Remove "clock-frequency" may break back compatiblity.
>
> A similar case
> https://lore.kernel.org/imx/20d37ab7-308e-4f07-96dc-7ae011af76d0@kernel.org/
> https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/
>
> Need provide judgement in commit message about impact of break ABI.
What ABI breakage ? The latest kernel supports the updated bindings
(merged in commit aa1826696a55 ("dt-bindings: media: Deprecate
clock-frequency property for camera sensors") in v6.18).
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Changes since v1:
> >
> > - Drop added blank line
> > ---
> > arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> > index ca4cb986efbc..0cc05d084f9b 100644
> > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> > @@ -233,7 +233,9 @@ camera@3c {
> > pinctrl-0 = <&pinctrl_ov5645>;
> > reg = <0x3c>;
> > clocks = <&clks IMX6QDL_CLK_CKO2>;
> > - clock-frequency = <24000000>;
> > + assigned-clocks = <&clks IMX6QDL_CLK_CKO2>;
> > + assigned-clock-rates = <24000000>;
> > +
> > vdddo-supply = <®_1p8v>;
> > vdda-supply = <®_2p8v>;
> > vddd-supply = <®_1p5v>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v3 6/7] ARM: dts: nxp: imx6qdl-pico: Replace clock-frequency in camera sensor node
2026-08-10 19:08 ` Laurent Pinchart
@ 2026-08-11 16:51 ` Frank Li
0 siblings, 0 replies; 14+ messages in thread
From: Frank Li @ 2026-08-11 16:51 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel, devicetree, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jacopo Mondi, Sakari Ailus, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, imx
On Mon, Aug 10, 2026 at 10:08:00PM +0300, Laurent Pinchart wrote:
> On Mon, Aug 10, 2026 at 01:55:41PM -0500, Frank Li wrote:
> > On Mon, Aug 10, 2026 at 09:06:03PM +0300, Laurent Pinchart wrote:
> > > The clock-frequency for camera sensors has been deprecated in favour of
> > > the assigned-clocks and assigned-clock-rates properties. Replace it in
> > > the device tree.
> >
> > Remove "clock-frequency" may break back compatiblity.
> >
> > A similar case
> > https://lore.kernel.org/imx/20d37ab7-308e-4f07-96dc-7ae011af76d0@kernel.org/
> > https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/
> >
> > Need provide judgement in commit message about impact of break ABI.
>
> What ABI breakage ? The latest kernel supports the updated bindings
> (merged in commit aa1826696a55 ("dt-bindings: media: Deprecate
> clock-frequency property for camera sensors") in v6.18).
Dts now not only use by kenrel. such as uboot may use the same dts file.
uboot may still use "clock-frequency". but uboot unlikely use camera. for
this case, just need mention at commit message
"lock-frequency property for camera sensor have deprecated since
("dt-bindings: media: Deprecate clock-frequency property for camera
sensors") in v6.18, no known other user like (uboot) use it. So drop
it safely"
Frank
>
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > > Changes since v1:
> > >
> > > - Drop added blank line
> > > ---
> > > arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> > > index ca4cb986efbc..0cc05d084f9b 100644
> > > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> > > +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> > > @@ -233,7 +233,9 @@ camera@3c {
> > > pinctrl-0 = <&pinctrl_ov5645>;
> > > reg = <0x3c>;
> > > clocks = <&clks IMX6QDL_CLK_CKO2>;
> > > - clock-frequency = <24000000>;
> > > + assigned-clocks = <&clks IMX6QDL_CLK_CKO2>;
> > > + assigned-clock-rates = <24000000>;
> > > +
> > > vdddo-supply = <®_1p8v>;
> > > vdda-supply = <®_2p8v>;
> > > vddd-supply = <®_1p5v>;
>
> --
> Regards,
>
> Laurent Pinchart
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3 7/7] ARM: dts: nxp: imx6qdl-wandboard: Replace clock-frequency in camera sensor node
2026-08-10 18:05 [PATCH v3 0/7] ARM: dts: Replace clock-frequency in camera sensor nodes Laurent Pinchart
` (5 preceding siblings ...)
2026-08-10 18:06 ` [PATCH v3 6/7] ARM: dts: nxp: imx6qdl-pico: " Laurent Pinchart
@ 2026-08-10 18:06 ` Laurent Pinchart
6 siblings, 0 replies; 14+ messages in thread
From: Laurent Pinchart @ 2026-08-10 18:06 UTC (permalink / raw)
To: linux-arm-kernel
Cc: devicetree, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jacopo Mondi, Sakari Ailus, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, imx
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties. Replace it in
the device tree.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Changes since v1:
- Drop added blank line
---
arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
index 26489eccd5fb..f3aaca039953 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
@@ -137,7 +137,9 @@ camera@3c {
pinctrl-0 = <&pinctrl_ov5645>;
reg = <0x3c>;
clocks = <&clks IMX6QDL_CLK_CKO2>;
- clock-frequency = <24000000>;
+ assigned-clocks = <&clks IMX6QDL_CLK_CKO2>;
+ assigned-clock-rates = <24000000>;
+
vdddo-supply = <®_1p8v>;
vdda-supply = <®_2p8v>;
vddd-supply = <®_1p5v>;
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 14+ messages in thread