Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pranjal Shrivastava <praan@google.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: iommu@lists.linux.dev, Will Deacon <will@kernel.org>,
	Joerg Roedel <joro@8bytes.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Mostafa Saleh <smostafa@google.com>,
	Nicolin Chen <nicolinc@nvidia.com>,
	Daniel Mentz <danielmentz@google.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 00/12] iommu/arm-smmu-v3: Implement Runtime/System Sleep ops
Date: Tue, 25 Aug 2026 18:50:12 +0000	[thread overview]
Message-ID: <ao3j5FFfKQsctV4r@google.com> (raw)
In-Reply-To: <20260825133342.GA3332773@nvidia.com>

On Tue, Aug 25, 2026 at 10:33:42AM -0300, Jason Gunthorpe wrote:
> On Tue, Jul 28, 2026 at 09:09:16PM +0000, Pranjal Shrivastava wrote:
> 
> > [v9]
> >  - Replaced atomic_fetch_or_relaxed() with atomic_fetch_or() for
> >    correct ordering while asserting the STOP_FLAG
> >  - Moved arm_smmu_drain_queues() after the cmdq->lock wait loop in
> >    runtime_suspend() as per feedback in v8.
> >  - Refactored suspend sequence to use arm_smmu_disable_irqs() and
> >    synchronize_irq() for safe GERROR handling.
> >  - Fixed an off-by-one error in suspend polling timeouts.
> >  - Dropped arm_smmu_cmdq_can_elide() check from inv_range
> >  - Renamed arm_smmu_cmdq_can_elide() to arm_smmu_is_active().
> >  - Removed redundant bitwise masking from owner_prod reads.
> >  - Added comments to explain locking, gating and elision better.
> >  - Added comments to explain secondary cmdq draining and gating.
> >  - Rebased on arm/smmu/updates
> 
> There are alot of scary looking sashiko remarks, are you planning to
> resend this with some of them addressed?
> 

Yes, I was first hoping to discuss them on the list! Thanks a lot for
initiating that discussion :) 

[BTW, I'm interested to know if you used some tool to pull in sashiko
feedback in your replies, such a tool seems helpful!]

Thanks,
Praan


  reply	other threads:[~2026-08-25 18:50 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28 21:09 [PATCH v9 00/12] iommu/arm-smmu-v3: Implement Runtime/System Sleep ops Pranjal Shrivastava
2026-07-28 21:09 ` [PATCH v9 01/12] iommu/arm-smmu-v3: Refactor arm_smmu_setup_irqs Pranjal Shrivastava
2026-08-25 16:36   ` Jason Gunthorpe
2026-08-25 17:35     ` Pranjal Shrivastava
2026-08-25 18:47       ` Nicolin Chen
2026-08-25 19:01         ` Pranjal Shrivastava
2026-07-28 21:09 ` [PATCH v9 02/12] iommu/arm-smmu-v3: Add a helper to drain cmd queues Pranjal Shrivastava
2026-08-25 16:36   ` Jason Gunthorpe
2026-08-25 17:37     ` Pranjal Shrivastava
2026-08-25 18:20       ` Nicolin Chen
2026-08-25 18:57         ` Pranjal Shrivastava
2026-07-28 21:09 ` [PATCH v9 03/12] iommu/tegra241-cmdqv: Add a helper to drain VCMDQs Pranjal Shrivastava
2026-07-28 21:09 ` [PATCH v9 04/12] iommu/tegra241-cmdqv: Restore PROD and CONS after resume Pranjal Shrivastava
2026-07-28 21:09 ` [PATCH v9 05/12] iommu/arm-smmu-v3: Cache and restore MSI config Pranjal Shrivastava
2026-08-25 16:36   ` Jason Gunthorpe
2026-08-25 18:01     ` Pranjal Shrivastava
2026-07-28 21:09 ` [PATCH v9 06/12] iommu/arm-smmu-v3: Handle gerror during suspend Pranjal Shrivastava
2026-08-25 16:36   ` Jason Gunthorpe
2026-08-25 18:06     ` Pranjal Shrivastava
2026-07-28 21:09 ` [PATCH v9 07/12] iommu/arm-smmu-v3: Add CMDQ_PROD_STOP_FLAG to gate CMDQ submissions Pranjal Shrivastava
2026-08-25 16:36   ` Jason Gunthorpe
2026-08-25 18:38     ` Pranjal Shrivastava
2026-07-28 21:09 ` [PATCH v9 08/12] iommu/tegra241-cmdqv: Add a helper to quiesce VCMDQs Pranjal Shrivastava
2026-08-25 16:36   ` Jason Gunthorpe
2026-08-25 18:46     ` Pranjal Shrivastava
2026-07-28 21:09 ` [PATCH v9 09/12] iommu/arm-smmu-v3: Implement pm_runtime & system sleep ops Pranjal Shrivastava
2026-08-25 16:36   ` Jason Gunthorpe
2026-08-25 18:53     ` Pranjal Shrivastava
2026-08-25 20:17       ` Jason Gunthorpe
2026-08-26 11:51         ` Pranjal Shrivastava
2026-08-26 13:47           ` Jason Gunthorpe
2026-08-26 14:17             ` Pranjal Shrivastava
2026-07-28 21:09 ` [PATCH v9 10/12] iommu/arm-smmu-v3: Enable pm_runtime and setup devlinks Pranjal Shrivastava
2026-07-28 21:09 ` [PATCH v9 11/12] iommu/arm-smmu-v3: Invoke pm_runtime before hw access Pranjal Shrivastava
2026-07-28 21:09 ` [PATCH v9 12/12] iommu/arm-smmu-v3: Add KUnit unit tests for Runtime PM Pranjal Shrivastava
2026-08-25 13:33 ` [PATCH v9 00/12] iommu/arm-smmu-v3: Implement Runtime/System Sleep ops Jason Gunthorpe
2026-08-25 18:50   ` Pranjal Shrivastava [this message]
2026-08-25 20:14     ` Jason Gunthorpe
2026-08-26 11:55       ` Pranjal Shrivastava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ao3j5FFfKQsctV4r@google.com \
    --to=praan@google.com \
    --cc=danielmentz@google.com \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=nicolinc@nvidia.com \
    --cc=robin.murphy@arm.com \
    --cc=smostafa@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox