From: Will Deacon <will@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Eric Biggers <ebiggers@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Alexei Starovoitov <ast@kernel.org>,
Oliver Upton <oupton@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH 06/12] arm64: assembler: Remove endianness helper macros
Date: Sun, 16 Aug 2026 10:42:34 +0100 [thread overview]
Message-ID: <aoGGCqMdb8iZvZSM@willie-the-truck> (raw)
In-Reply-To: <a16ed8a4-28cc-4270-a257-b9268ab9e9ea@app.fastmail.com>
On Tue, Aug 11, 2026 at 05:04:43PM +0200, Ard Biesheuvel wrote:
> On Tue, 11 Aug 2026, at 16:01, Will Deacon wrote:
> > diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S
> > index 87a822e5c4ca..8951ce693552 100644
> > --- a/arch/arm64/kernel/head.S
> > +++ b/arch/arm64/kernel/head.S
> > @@ -138,8 +138,7 @@ SYM_CODE_START_LOCAL(record_mmu_state)
> > b.ne 0f
> > mrs x19, sctlr_el2
> > 0:
> > -CPU_LE( tbnz x19, #SCTLR_ELx_EE_SHIFT, 1f )
> > -CPU_BE( tbz x19, #SCTLR_ELx_EE_SHIFT, 1f )
> > + tbnz x19, #SCTLR_ELx_EE_SHIFT, 1f
> > tst x19, #SCTLR_ELx_C // Z := (C == 0)
> > and x19, x19, #SCTLR_ELx_M // isolate M bit
> > csel x19, xzr, x19, eq // clear x19 if Z
>
> There is some more code that can be removed here - see
> 2ced0f30a426c7301350681f838344d5aea711e3
Good spot, thanks! I'll do some more surgery at -rc1.
Will
next prev parent reply other threads:[~2026-08-16 9:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 14:01 [PATCH 00/12] arm64: Remove unused big-endian support Will Deacon
2026-08-11 14:01 ` [PATCH 01/12] selftests/arm64: Remove " Will Deacon
2026-08-11 14:01 ` [PATCH 02/12] arm64: bpf: Remove big-endian support from the JIT compiler Will Deacon
2026-08-11 14:01 ` [PATCH 03/12] arm64: crypto: Assume a little-endian kernel Will Deacon
2026-08-11 14:01 ` [PATCH 04/12] arm64: lib: Assume a little-endian kernel in custom library routines Will Deacon
2026-08-11 14:01 ` [PATCH 05/12] arm64: lib: Assume a little-endian kernel in optimised string routines Will Deacon
2026-08-11 14:01 ` [PATCH 06/12] arm64: assembler: Remove endianness helper macros Will Deacon
2026-08-11 15:04 ` Ard Biesheuvel
2026-08-16 9:42 ` Will Deacon [this message]
2026-08-20 13:19 ` Will Deacon
2026-08-20 13:27 ` Ard Biesheuvel
2026-08-20 13:45 ` Will Deacon
2026-08-20 13:50 ` Ard Biesheuvel
2026-08-21 9:23 ` Will Deacon
2026-08-11 14:01 ` [PATCH 07/12] arm64: vdso32: Always build compat vDSO object as little-endian Will Deacon
2026-08-11 14:01 ` [PATCH 08/12] KVM: arm64: Remove support for a big-endian hypervisor object Will Deacon
2026-08-11 14:01 ` [PATCH 09/12] arm64: Remove all usage of CONFIG_CPU_BIG_ENDIAN Will Deacon
2026-08-11 14:49 ` Marc Zyngier
2026-08-11 14:01 ` [PATCH 10/12] arm64: Remove all usage of __AARCH64EB__ Will Deacon
2026-08-11 14:01 ` [PATCH 11/12] arm64: image: Remove endianness handling for generating image header Will Deacon
2026-08-11 14:01 ` [PATCH 12/12] arm64: Kbuild: Remove vestigial big-endian support Will Deacon
2026-08-11 14:54 ` [PATCH 00/12] arm64: Remove unused " Marc Zyngier
2026-08-11 15:11 ` Arnd Bergmann
2026-08-16 9:47 ` Will Deacon
2026-08-16 10:15 ` Arnd Bergmann
2026-08-18 10:33 ` Will Deacon
2026-08-18 17:24 ` Eric Biggers
2026-08-11 15:43 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoGGCqMdb8iZvZSM@willie-the-truck \
--to=will@kernel.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel@iogearbox.net \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox