* [PATCH] arm64: dts: lx2160a: fix incorrect pinmux
@ 2026-08-23 22:24 Vincent Jardin via B4 Relay
2026-08-24 11:47 ` Josua Mayer
0 siblings, 1 reply; 3+ messages in thread
From: Vincent Jardin via B4 Relay @ 2026-08-23 22:24 UTC (permalink / raw)
To: Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Josua Mayer
Cc: imx, linux-arm-kernel, devicetree, linux-kernel, Vincent Jardin
From: Vincent Jardin <vjardin@free.fr>
For gpio1 value set for pinctrl is outside the mask and so will do
nothing.
Add the missing offset for value field to be the same as the mask as
expected.
Fixes: 284ad7064aaa ("arm64: dts: lx2160a: complete pinmux for rcwsr12 configuration word")
Signed-off-by: Vincent Jardin <vjardin@free.fr>
---
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
index 1d73abffa6b7..b9f079c49e19 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
@@ -1803,7 +1803,7 @@ fspi_data74_pins: xspi1-data74-pins {
};
gpio1_31_28_pins: xspi1-data74-gpio-pins {
- pinctrl-single,bits = <0x0 0x1 (0x7 << 15)>;
+ pinctrl-single,bits = <0x0 (0x1 << 15) (0x7 << 15)>;
};
fspi_data30_pins: xspi1-data30-pins {
@@ -1811,7 +1811,7 @@ fspi_data30_pins: xspi1-data30-pins {
};
gpio1_27_24_pins: xspi1-data30-gpio-pins {
- pinctrl-single,bits = <0x0 0x1 (0x7 << 18)>;
+ pinctrl-single,bits = <0x0 (0x1 << 18) (0x7 << 18)>;
};
fspi_dqs_sck_cs10_pins: xspi1-base-pins {
@@ -1819,7 +1819,7 @@ fspi_dqs_sck_cs10_pins: xspi1-base-pins {
};
gpio1_23_20_pins: xspi1-base-gpio-pins {
- pinctrl-single,bits = <0x0 0x1 (0x7 << 21)>;
+ pinctrl-single,bits = <0x0 (0x1 << 21) (0x7 << 21)>;
};
esdhc0_cmd_data30_clk_vsel_pins: sdhc1-base-sdhc-vsel-pins {
---
base-commit: 3d6d817622b0a9721e3cc404df3469171582be13
change-id: 20260824-for-upstream-lx2160a-pinmux-fix-6d09e82bd5cb
Best regards,
--
Vincent Jardin <vjardin@free.fr>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: lx2160a: fix incorrect pinmux
2026-08-23 22:24 [PATCH] arm64: dts: lx2160a: fix incorrect pinmux Vincent Jardin via B4 Relay
@ 2026-08-24 11:47 ` Josua Mayer
2026-08-24 13:15 ` Vincent Jardin
0 siblings, 1 reply; 3+ messages in thread
From: Josua Mayer @ 2026-08-24 11:47 UTC (permalink / raw)
To: vjardin@free.fr, Frank Li, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Am 24.08.26 um 00:24 schrieb Vincent Jardin via B4 Relay:
> From: Vincent Jardin <vjardin@free.fr>
>
> For gpio1 value set for pinctrl is outside the mask and so will do
> nothing.
> Add the missing offset for value field to be the same as the mask as
> expected.
>
> Fixes: 284ad7064aaa ("arm64: dts: lx2160a: complete pinmux for rcwsr12 configuration word")
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
> ---
> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index 1d73abffa6b7..b9f079c49e19 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -1803,7 +1803,7 @@ fspi_data74_pins: xspi1-data74-pins {
> };
>
> gpio1_31_28_pins: xspi1-data74-gpio-pins {
> - pinctrl-single,bits = <0x0 0x1 (0x7 << 15)>;
> + pinctrl-single,bits = <0x0 (0x1 << 15) (0x7 << 15)>;
> };
>
> fspi_data30_pins: xspi1-data30-pins {
> @@ -1811,7 +1811,7 @@ fspi_data30_pins: xspi1-data30-pins {
> };
>
> gpio1_27_24_pins: xspi1-data30-gpio-pins {
> - pinctrl-single,bits = <0x0 0x1 (0x7 << 18)>;
> + pinctrl-single,bits = <0x0 (0x1 << 18) (0x7 << 18)>;
> };
>
> fspi_dqs_sck_cs10_pins: xspi1-base-pins {
> @@ -1819,7 +1819,7 @@ fspi_dqs_sck_cs10_pins: xspi1-base-pins {
> };
>
> gpio1_23_20_pins: xspi1-base-gpio-pins {
> - pinctrl-single,bits = <0x0 0x1 (0x7 << 21)>;
> + pinctrl-single,bits = <0x0 (0x1 << 21) (0x7 << 21)>;
> };
>
> esdhc0_cmd_data30_clk_vsel_pins: sdhc1-base-sdhc-vsel-pins {
>
> ---
> base-commit: 3d6d817622b0a9721e3cc404df3469171582be13
> change-id: 20260824-for-upstream-lx2160a-pinmux-fix-6d09e82bd5cb
>
> Best regards,
Thanks!
Reviewed-by: Josua Mayer <josua@solid-run.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: lx2160a: fix incorrect pinmux
2026-08-24 11:47 ` Josua Mayer
@ 2026-08-24 13:15 ` Vincent Jardin
0 siblings, 0 replies; 3+ messages in thread
From: Vincent Jardin @ 2026-08-24 13:15 UTC (permalink / raw)
To: Josua Mayer
Cc: Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Hi Josua,
> Reviewed-by: Josua Mayer <josua@solid-run.com>
Sorry, I did miss your review while doing a v2 based on the Bot's comments.
Please, can you resubmit your reviewed by on this serie:
https://lore.kernel.org/all/20260824-for-upstream-lx2160a-pinmux-fix-v2-0-0a525d5f4cd5@free.fr/
?
thank you,
Vincent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-24 13:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-23 22:24 [PATCH] arm64: dts: lx2160a: fix incorrect pinmux Vincent Jardin via B4 Relay
2026-08-24 11:47 ` Josua Mayer
2026-08-24 13:15 ` Vincent Jardin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox