Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Will Deacon <will@kernel.org>
Cc: Bradley Morgan <brads@mainlining.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	James Morse <james.morse@arm.com>, Marc Zyngier <maz@kernel.org>,
	Ard Biesheuvel <ardb@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] arm64: hibernate: dust off the suspend/cleanup rework
Date: Wed, 9 Sep 2026 10:05:16 +0100	[thread overview]
Message-ID: <aqEhTIPqoKj98TRS@J2N7QTR9R3> (raw)
In-Reply-To: <aplRx8f5NprO9dSU@willie-the-truck_quarantine>

Hi Will,

On Thu, Sep 03, 2026 at 11:53:59AM +0100, Will Deacon wrote:
> it's worth noting that Bradley's patch _does_ fix one of the
> hibernation problems and has been tested by Vladimir:
> 
> https://lore.kernel.org/all/20260809213615.11646-1-include@grrlz.net/
> 
> I would prefer to take your complete set of patches, but if you don't
> want that then should I just take the above for now? Prior to this
> series, there has been no activity for nearly two years on your branch,
> so I'd prefer to get _something_ in, even if it only fixes some of the
> problems.

Sorry for the delay.

I'd prefer if you picked up Bradley's single patch for now. I'll follow
up with a respin of the rest of the cleanup and fixes shortly.

Could you add a note to the commit message as to how Vladimir was able
to trigger a hang with CONFIG_PAGE_POISONING=y and page_poison=on? It's
helpful for anyone testing a backport, etc.

With that:

Acked-by: Mark Rutland <mark.rutland@arm.com>

For context, when I originally wrote my patches, I hadn't managed to
trigger failures at top level without additional hacks, and so this
hadn't been a high priority. Given that Vladimir can trigger this
specific issue with existing options, it makes sense to pick that up.

I had a vague recollection that this specific fix lead to a secondary
issue, but digging through my notes I can't see what that would have
been, and I suspect I had just gotten confused w.r.t. what KVM was
doing. If I find there was a real secondary issue I'll follow up with a
fix .

Thanks,
Mark.


  parent reply	other threads:[~2026-09-09  9:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25 20:58 [PATCH 0/7] arm64: hibernate: dust off the suspend/cleanup rework Bradley Morgan
2026-08-25 20:58 ` [PATCH 1/7] arm64: hibernate: pass HVC_SET_VECTORS args to the resume hvc Bradley Morgan
2026-08-25 20:58 ` [PATCH 2/7] arm64: head: correct comment for init_kernel_el() Bradley Morgan
2026-09-02 13:46   ` Mark Rutland
2026-09-02 13:49     ` Bradley Morgan
2026-09-02 13:58       ` Mark Rutland
2026-09-02 14:01         ` Bradley Morgan
2026-08-25 20:58 ` [PATCH 3/7] arm64: hibernate: free MTE tag pages after saving Bradley Morgan
2026-08-25 20:58 ` [PATCH 4/7] arm64: hibernate: fix _cpu_resume() calling convention Bradley Morgan
2026-08-25 20:58 ` [PATCH 5/7] arm64: hibernate: use dcache_by_myline_op Bradley Morgan
2026-08-25 20:58 ` [PATCH 6/7] arm64: hibernate: only clean to PoC Bradley Morgan
2026-08-25 20:58 ` [PATCH 7/7] arm64: hibernate: use regular cpu_resume() logic Bradley Morgan
2026-08-28 10:32 ` [PATCH 0/7] arm64: hibernate: dust off the suspend/cleanup rework Ard Biesheuvel
2026-08-28 11:31   ` Bradley Morgan
2026-09-02 13:50 ` Mark Rutland
2026-09-02 13:51   ` Bradley Morgan
2026-09-02 14:03     ` Mark Rutland
2026-09-02 14:06       ` Bradley Morgan
2026-09-03 10:53       ` Will Deacon
2026-09-03 11:26         ` Bradley Morgan
2026-09-03 12:16           ` Will Deacon
     [not found]       ` <aplRx8f5NprO9dSU@willie-the-truck_quarantine>
2026-09-09  9:05         ` Mark Rutland [this message]
2026-09-09 14:45           ` Bradley Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqEhTIPqoKj98TRS@J2N7QTR9R3 \
    --to=mark.rutland@arm.com \
    --cc=ardb@kernel.org \
    --cc=brads@mainlining.org \
    --cc=catalin.marinas@arm.com \
    --cc=james.morse@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox