From: Manivannan Sadhasivam <mani@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: bivvy.bi@rock-chips.com, heiko@sntech.de, kishon@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-rockchip@lists.infradead.org, neil.armstrong@linaro.org,
vkoul@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] phy: rockchip: inno-dsidphy: Fix runtime PM leak in inno_dsidphy_power_on()
Date: Mon, 12 Oct 2026 21:41:57 +0530 [thread overview]
Message-ID: <as0GyAtxP7a0oqrB@debian> (raw)
In-Reply-To: <20260917134627.2153845-1-vulab@iscas.ac.cn>
On Thu, Sep 17, 2026 at 01:46:27PM +0000, Wentao Liang wrote:
> inno_dsidphy_power_on() resumes the device with pm_runtime_get_sync(),
> but the default case of the mode switch returns -EINVAL without
> dropping that reference. The matching pm_runtime_put() lives in
> inno_dsidphy_power_off(), which the PHY core does not run when
> power_on() fails.
>
> Release the runtime PM reference before returning.
>
> Fixes: b7535a3bc0ba ("phy/rockchip: Add support for Innosilicon MIPI/LVDS/TTL PHY")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
- Mani
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2026-10-12 16:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 13:46 [PATCH] phy: rockchip: inno-dsidphy: Fix runtime PM leak in inno_dsidphy_power_on() Wentao Liang
2026-10-12 16:11 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as0GyAtxP7a0oqrB@debian \
--to=mani@kernel.org \
--cc=bivvy.bi@rock-chips.com \
--cc=heiko@sntech.de \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox