* [PATCH] phy: rockchip: inno-dsidphy: Fix runtime PM leak in inno_dsidphy_power_on()
@ 2026-09-17 13:46 Wentao Liang
2026-10-12 16:11 ` Manivannan Sadhasivam
0 siblings, 1 reply; 2+ messages in thread
From: Wentao Liang @ 2026-09-17 13:46 UTC (permalink / raw)
To: bivvy.bi
Cc: heiko, kishon, linux-arm-kernel, linux-kernel, linux-phy,
linux-rockchip, neil.armstrong, vkoul, Wentao Liang, stable
inno_dsidphy_power_on() resumes the device with pm_runtime_get_sync(),
but the default case of the mode switch returns -EINVAL without
dropping that reference. The matching pm_runtime_put() lives in
inno_dsidphy_power_off(), which the PHY core does not run when
power_on() fails.
Release the runtime PM reference before returning.
Fixes: b7535a3bc0ba ("phy/rockchip: Add support for Innosilicon MIPI/LVDS/TTL PHY")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
index 30d5e5ddff4a..5a7962af946b 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
@@ -672,6 +672,7 @@ static int inno_dsidphy_power_on(struct phy *phy)
inno_dsidphy_lvds_mode_enable(inno);
break;
default:
+ pm_runtime_put(inno->dev);
return -EINVAL;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: rockchip: inno-dsidphy: Fix runtime PM leak in inno_dsidphy_power_on()
2026-09-17 13:46 [PATCH] phy: rockchip: inno-dsidphy: Fix runtime PM leak in inno_dsidphy_power_on() Wentao Liang
@ 2026-10-12 16:11 ` Manivannan Sadhasivam
0 siblings, 0 replies; 2+ messages in thread
From: Manivannan Sadhasivam @ 2026-10-12 16:11 UTC (permalink / raw)
To: Wentao Liang
Cc: bivvy.bi, heiko, kishon, linux-arm-kernel, linux-kernel,
linux-phy, linux-rockchip, neil.armstrong, vkoul, stable
On Thu, Sep 17, 2026 at 01:46:27PM +0000, Wentao Liang wrote:
> inno_dsidphy_power_on() resumes the device with pm_runtime_get_sync(),
> but the default case of the mode switch returns -EINVAL without
> dropping that reference. The matching pm_runtime_put() lives in
> inno_dsidphy_power_off(), which the PHY core does not run when
> power_on() fails.
>
> Release the runtime PM reference before returning.
>
> Fixes: b7535a3bc0ba ("phy/rockchip: Add support for Innosilicon MIPI/LVDS/TTL PHY")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
- Mani
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-12 16:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-17 13:46 [PATCH] phy: rockchip: inno-dsidphy: Fix runtime PM leak in inno_dsidphy_power_on() Wentao Liang
2026-10-12 16:11 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox