Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: jan.petrous@oss.nxp.com
Cc: "Ciprian Marian Costea" <ciprianmarian.costea@oss.nxp.com>,
	"NXP S32 Linux Team" <s32@nxp.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Ghennadi Procopciuc" <ghennadi.procopciuc@nxp.com>,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Bogdan Hamciuc" <bogdan.hamciuc@nxp.com>,
	"Ionut Vicovan" <ionut.vicovan@nxp.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Clark Wang" <xiaoning.wang@nxp.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Chester Lin" <chester62515@gmail.com>,
	"Matthias Brugger" <mbrugger@suse.com>,
	"Ghennadi Procopciuc" <ghennadi.procopciuc@oss.nxp.com>,
	"Frank Li" <Frank.Li@nxp.com>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Richard Cochran" <richardcochran@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-phy@lists.infradead.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, imx@lists.linux.dev,
	linux-pci@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	"Vincent Guittot" <vincent.guittot@linaro.org>
Subject: Re: [PATCH RFC v3 01/12] dt-bindings: phy: Add NXP S32G SerDes subsystem
Date: Mon, 12 Oct 2026 13:57:13 -0500	[thread overview]
Message-ID: <as0tiQwquNkdlF2i@SMW015318> (raw)
In-Reply-To: <20260919-s32g_serdes-v3-1-9d68868c1e89@oss.nxp.com>

On Sat, Sep 19, 2026 at 08:54:29AM +0200, Jan Petrous via B4 Relay wrote:
> [You don't often get email from devnull+jan.petrous.oss.nxp.com@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
>
> The S32G SerDes subsystem multiplexes two lanes between a PCIe PHY and
> two DesignWare XPCS instances. Describe it with one node per SerDes and
> one child node per lane.
>
> Compared to the previous revision, the vendor nxp,sys-mode property is
> removed: the SS_RW_REG_0[SUBSYS_MODE] value is fully derivable from the
> child-node lane mux and the XPCS instance routing (nxp,xpcs-instance).
> Each working mode described here has a unique lane mux, so the mode is
> a pure function of the child nodes. The reference-clock rate is
> validated against the derived mode; it is not used to select it.
>
> The 3.125 Gbit/s working modes are deliberately not described yet.
> Distinguishing them from the 1.25 Gbit/s dual-XPCS mode requires a
> per-lane 2500BASE-X capability that this binding does not express, and
> the reference clock does not distinguish them either - both accept 100
> or 125 MHz. They are added by the 2500BASE-X follow-up.
>
> Only the PCIe lane child gets '#phy-cells'. An XPCS lane is not a
> generic PHY provider; the Ethernet controller references it through the
> standard pcs-handle property instead.

Is it possible Ether controller use standard phy interface? of use standard
pcs-handle to phy convertion

pcs-handle = <&pcs>

pcs: pcs = {
	compatible = "pcs-to-phy";
	phys = <&phy ...>;
}

>
> S32G2 and S32G3 use distinct compatibles without fallback because the
> full reference-manual mode tables differ per SoC and per SerDes
> instance.
>
> Co-developed-by: Vincent Guittot <vincent.guittot@linaro.org>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
> ---
>  .../devicetree/bindings/phy/nxp,s32g-serdes.yaml   | 258 +++++++++++++++++++++
>  1 file changed, 258 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/nxp,s32g-serdes.yaml b/Documentation/devicetree/bindings/phy/nxp,s32g-serdes.yaml
> new file mode 100644
> index 000000000000..6343d01bfde4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/nxp,s32g-serdes.yaml
> @@ -0,0 +1,258 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/nxp,s32g-serdes.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP S32G2xxx/S32G3xxx SerDes PHY subsystem
> +
> +maintainers:
> +  - Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com>
> +  - Jan Petrous <jan.petrous@oss.nxp.com>
> +
> +description: |
> +  The SerDes subsystem multiplexes two SerDes lanes between one PCIe
> +  controller PHY and two Synopsys DesignWare XPCS (Ethernet PCS) instances,
> +  behind a shared 2-lane combo PHY. The active routing is selected by the
> +  SS_RW_REG_0[SUBSYS_MODE] field.
> +
> +  Reference-manual working modes described by this binding:
> +
> +  Mode  Lane0   Lane1   PHY refclk (MHz)  Description
> +  ------------------------------------------------------------
> +  0     PCIe    PCIe    100               PCIe x2
> +  1     PCIe    XPCS0   100               PCIe x1 + SGMII
> +  2     PCIe    XPCS1   100               PCIe x1 + SGMII
> +  3     XPCS0   XPCS1   100 or 125        dual SGMII, 1.25 Gbit/s
> +
> +  Which Ethernet MAC an XPCS instance feeds is fixed by the SoC integration
> +  and differs per SoC and per SerDes instance - on S32G3 SerDes_0, XPCS0
> +  feeds GMAC0 and XPCS1 feeds PFE_MAC2, while on SerDes_1 the same two
> +  instances feed PFE_MAC0 and PFE_MAC1. That mapping is a property of the
> +  SoC, not of this binding, and is resolved by the driver.

Roughly look like use argument is little bit better

<&phys PHY_MODE instance(0/1)>;

Frank


  reply	other threads:[~2026-10-12 18:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260919-s32g_serdes-v3-0-9d68868c1e89@oss.nxp.com>
2026-09-19  6:54 ` [PATCH RFC v3 01/12] dt-bindings: phy: Add NXP S32G SerDes subsystem Jan Petrous via B4 Relay
2026-10-12 18:57   ` Frank Li [this message]
2026-10-13 14:40     ` Jan Petrous
2026-09-19  6:54 ` [PATCH RFC v3 02/12] dt-bindings: net: nxp,s32-dwmac: Document pcs-handle Jan Petrous via B4 Relay
2026-09-19  6:54 ` [PATCH RFC v3 03/12] dt-bindings: PCI: nxp,s32g-pcie: Fix SerDes PHY phandle in example Jan Petrous via B4 Relay
2026-10-12 18:43   ` Frank Li
2026-10-13 14:37     ` Jan Petrous
2026-09-19  6:54 ` [PATCH RFC v3 04/12] net: pcs: add NXP SerDes XPCS shared core Jan Petrous via B4 Relay
2026-09-19 15:31   ` Maxime Chevallier
2026-09-19 16:31     ` Coia Prant
2026-10-11  6:01     ` Jan Petrous
2026-10-12 19:47       ` Coia Prant
2026-10-13 14:47         ` Jan Petrous
2026-09-20 18:39   ` Andrew Lunn
2026-10-11  6:03     ` Jan Petrous
2026-09-19  6:54 ` [PATCH RFC v3 07/12] net: stmmac: dwmac-s32: Add SGMII support Jan Petrous via B4 Relay
2026-09-19 12:04   ` Maxime Chevallier
2026-10-11  5:53     ` Jan Petrous
2026-09-19  6:54 ` [PATCH RFC v3 08/12] MAINTAINERS: Add NXP S32G SerDes and SerDes xPCS core entries Jan Petrous via B4 Relay
2026-09-19  6:54 ` [PATCH RFC v3 09/12] arm64: dts: s32g: Add SCMI reset controller Jan Petrous via B4 Relay
2026-09-19  6:54 ` [PATCH RFC v3 10/12] arm64: dts: s32g: Add SerDes controller nodes Jan Petrous via B4 Relay
2026-09-19  6:54 ` [PATCH RFC v3 11/12] arm64: dts: s32g: Add PCIe " Jan Petrous via B4 Relay
2026-09-19  6:54 ` [PATCH RFC v3 12/12] arm64: dts: s32g: Add S32G3-RDB3 SerDes routing variants Jan Petrous via B4 Relay
     [not found] ` <20260919-s32g_serdes-v3-5-9d68868c1e89@oss.nxp.com>
2026-09-20 17:07   ` [PATCH RFC v3 05/12] net: pcs: Add NXP S32G XPCS driver Andrew Lunn
2026-10-11  5:56     ` Jan Petrous

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=as0tiQwquNkdlF2i@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=bhelgaas@google.com \
    --cc=bogdan.hamciuc@nxp.com \
    --cc=chester62515@gmail.com \
    --cc=ciprianmarian.costea@oss.nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=festevam@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=ghennadi.procopciuc@nxp.com \
    --cc=ghennadi.procopciuc@oss.nxp.com \
    --cc=hkallweit1@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=ionut.vicovan@nxp.com \
    --cc=jan.petrous@oss.nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux@armlinux.org.uk \
    --cc=lpieralisi@kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mani@kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=mbrugger@suse.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=s32@nxp.com \
    --cc=vincent.guittot@linaro.org \
    --cc=vkoul@kernel.org \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox