Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Linus Walleij <linusw@kernel.org>
Cc: Muhammad Usama Anjum <usama.anjum@arm.com>,
	Leonardo Bras <leo.bras@arm.com>, Will Deacon <will@kernel.org>,
	Marc Zyngier <maz@kernel.org>, Oliver Upton <oupton@kernel.org>,
	Joey Gouly <joey.gouly@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev
Subject: Re: [PATCH v2] arm64: clear_page[s] using memset
Date: Wed, 14 Oct 2026 10:03:02 +0100	[thread overview]
Message-ID: <as9FRpnL7851aTVj@arm.com> (raw)
In-Reply-To: <CAD++jLmMoD_FPno2Q47WyWicpRaf8x46YREt0eyUzAXkOU5cFA@mail.gmail.com>

On Tue, Oct 13, 2026 at 06:28:54PM +0200, Linus Walleij wrote:
> On Tue, Oct 13, 2026 at 3:04 PM Catalin Marinas <catalin.marinas@arm.com> wrote:
> 
> > Trying to make sense of the above. So based on -next of 22nd of
> > September, the table means:
> >
> > vanilla         - next/master on that day (current clear_page())
> > patch           - memset()-based clear_page() patch (Linus's patch)
> > stnp            - vanilla clear_page() without DC ZVA
> > patch_stp       - memset()-based clear_page() patch without DC ZVA
> >
> > I assume the vanilla vs patch columns are just noise. Well, there's a
> > -1.17% regression (not flagged) on Ampere but what's the standard
> > deviation for this column? Similarly for the -1.15% on the AWS patch_stp
> > test (vs stnp in the same test, it's no worse).
> >
> > Vanilla vs stnp shows a regression on Ampere, however that's expected as
> > we no longer do the DC ZVA. Interestingly, the patch_stp result doesn't have
> > this regression, so I reckon DC ZVA behaves mostly in line with STP on
> > this hardware.
> >
> > Basically I was looking for the stnp vs patch_stp results. If I read it
> > correctly, there's no significant change going from non-temporal to
> > temporal stores (and a small improvement for Ampere). Assuming future
> > FEAT_MOPS will have similar behaviour, moving clear_page() to memset()
> > shouldn't cause any regressions. Before FEAT_MOPS, we'll use DC ZVA here
> > anyway.
> 
> That almost sounds like an Acked-by if Usama can confirm your
> assumptions above!

It's queued but we can revert it if it shows real regression.

-- 
Catalin


  reply	other threads:[~2026-10-14  9:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 10:03 [PATCH v2] arm64: clear_page[s] using memset Linus Walleij
2026-09-16 15:28 ` Leonardo Bras
2026-09-16 15:54   ` Leonardo Bras
2026-09-23 16:14     ` Catalin Marinas
2026-10-08 13:30       ` Muhammad Usama Anjum
2026-10-13 13:04         ` Catalin Marinas
2026-10-13 16:28           ` Linus Walleij
2026-10-14  9:03             ` Catalin Marinas [this message]
2026-10-14  9:57               ` Linus Walleij
2026-10-13 17:05 ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=as9FRpnL7851aTVj@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=joey.gouly@arm.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=leo.bras@arm.com \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=oupton@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=usama.anjum@arm.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox