* [PATCH] net: ethernet: mtk_wed: fix double free in mtk_wed_rx_reset
@ 2026-11-04 14:36 Zhi-Jun You
2026-11-05 8:33 ` Lorenzo Bianconi
0 siblings, 1 reply; 2+ messages in thread
From: Zhi-Jun You @ 2026-11-04 14:36 UTC (permalink / raw)
To: Felix Fietkau, Lorenzo Bianconi, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Matthias Brugger,
AngeloGioacchino Del Regno, Sujuan Chen
Cc: netdev, linux-kernel, linux-arm-kernel, linux-mediatek, Sashiko,
stable, Zhi-Jun You
mtk_wed_free_rx_buffer already calls mtk_wed_hwrro_free_buffer but
mtk_wed_rx_reset calls both subsequently. This would cause double free
because dma_free_coherent doesn't set freed desc to NULL.
Fix this by removing the mtk_wed_hwrro_free_buffer in mtk_wed_rx_reset.
Compile tested only because I don't own v3 hardware.
Fixes: 1543b8ff02f0 ("net: ethernet: mtk_wed: add wed 3.0 reset support")
Reported-by: Sashiko <sashiko-bot@kernel.org>
Link: https://sashiko.dev/#/map/216156
Cc: stable@vger.kernel.org
Signed-off-by: Zhi-Jun You <hujy652@gmail.com>
---
drivers/net/ethernet/mediatek/mtk_wed.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_wed.c b/drivers/net/ethernet/mediatek/mtk_wed.c
index f40ac5794341..5e9674c9e63a 100644
--- a/drivers/net/ethernet/mediatek/mtk_wed.c
+++ b/drivers/net/ethernet/mediatek/mtk_wed.c
@@ -1723,7 +1723,6 @@ mtk_wed_rx_reset(struct mtk_wed_device *dev)
false);
}
mtk_wed_free_rx_buffer(dev);
- mtk_wed_hwrro_free_buffer(dev);
return 0;
}
---
base-commit: 11140c51df12e594d6bf2c8d2af5dec63b0219ac
change-id: 20261104-double-free-b6b95c2539c6
Best regards,
--
Zhi-Jun You <hujy652@gmail.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ethernet: mtk_wed: fix double free in mtk_wed_rx_reset
2026-11-04 14:36 [PATCH] net: ethernet: mtk_wed: fix double free in mtk_wed_rx_reset Zhi-Jun You
@ 2026-11-05 8:33 ` Lorenzo Bianconi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Bianconi @ 2026-11-05 8:33 UTC (permalink / raw)
To: Zhi-Jun You
Cc: Felix Fietkau, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Matthias Brugger,
AngeloGioacchino Del Regno, Sujuan Chen, netdev, linux-kernel,
linux-arm-kernel, linux-mediatek, Sashiko, stable
[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]
> mtk_wed_free_rx_buffer already calls mtk_wed_hwrro_free_buffer but
> mtk_wed_rx_reset calls both subsequently. This would cause double free
> because dma_free_coherent doesn't set freed desc to NULL.
>
> Fix this by removing the mtk_wed_hwrro_free_buffer in mtk_wed_rx_reset.
>
> Compile tested only because I don't own v3 hardware.
>
> Fixes: 1543b8ff02f0 ("net: ethernet: mtk_wed: add wed 3.0 reset support")
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Link: https://sashiko.dev/#/map/216156
> Cc: stable@vger.kernel.org
> Signed-off-by: Zhi-Jun You <hujy652@gmail.com>
Reviewed-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> drivers/net/ethernet/mediatek/mtk_wed.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_wed.c b/drivers/net/ethernet/mediatek/mtk_wed.c
> index f40ac5794341..5e9674c9e63a 100644
> --- a/drivers/net/ethernet/mediatek/mtk_wed.c
> +++ b/drivers/net/ethernet/mediatek/mtk_wed.c
> @@ -1723,7 +1723,6 @@ mtk_wed_rx_reset(struct mtk_wed_device *dev)
> false);
> }
> mtk_wed_free_rx_buffer(dev);
> - mtk_wed_hwrro_free_buffer(dev);
>
> return 0;
> }
>
> ---
> base-commit: 11140c51df12e594d6bf2c8d2af5dec63b0219ac
> change-id: 20261104-double-free-b6b95c2539c6
>
> Best regards,
> --
> Zhi-Jun You <hujy652@gmail.com>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-05 8:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-04 14:36 [PATCH] net: ethernet: mtk_wed: fix double free in mtk_wed_rx_reset Zhi-Jun You
2026-11-05 8:33 ` Lorenzo Bianconi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox