[PATCH 0/2] spi: convert to subsys_platform_driver()

[PATCH 0/2] spi: convert to subsys_platform_driver()

[Brian Masney]

Reduce boilerplate code in these drivers and convert them over to use
the macro subsys_platform_driver().

Signed-off-by: Brian Masney <bmasney@redhat.com>
---
Brian Masney (2):
      spi: omap-uwire: convert to subsys_platform_driver()
      spi: pxa2xx: convert to subsys_platform_driver()

 drivers/spi/spi-omap-uwire.c      | 14 +-------------
 drivers/spi/spi-pxa2xx-platform.c | 14 ++------------
 2 files changed, 3 insertions(+), 25 deletions(-)
---
base-commit: ddfe51b0a0f5dc9e415cc2c8ad8db17532dd426b
base-tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
change-id: 20261106-spi-subsys-32156ad80403

Best regards,
--  
Brian Masney <bmasney@redhat.com>

[PATCH 1/2] spi: omap-uwire: convert to subsys_platform_driver()

[Brian Masney]

Reduce boilerplate code in this driver and convert it over to use
the macro subsys_platform_driver().

Signed-off-by: Brian Masney <bmasney@redhat.com>
---
 drivers/spi/spi-omap-uwire.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/drivers/spi/spi-omap-uwire.c b/drivers/spi/spi-omap-uwire.c
index 83e263eb6069..91bd733ca15d 100644
--- a/drivers/spi/spi-omap-uwire.c
+++ b/drivers/spi/spi-omap-uwire.c
@@ -528,19 +528,7 @@ static struct platform_driver uwire_driver = {
 	// resume ... use ck
 };
 
-static int __init omap_uwire_init(void)
-{
-	return platform_driver_register(&uwire_driver);
-}
-
-static void __exit omap_uwire_exit(void)
-{
-	platform_driver_unregister(&uwire_driver);
-}
-
-subsys_initcall(omap_uwire_init);
-module_exit(omap_uwire_exit);
+subsys_platform_driver(uwire_driver);
 
 MODULE_DESCRIPTION("MicroWire interface driver for OMAP");
 MODULE_LICENSE("GPL");
-

-- 
2.56.0

[PATCH 2/2] spi: pxa2xx: convert to subsys_platform_driver()

[Brian Masney]

Reduce boilerplate code in this driver and convert it over to use
the macro subsys_platform_driver().

Note that this needs to rename the driver variable to pxa2xx_spi_driver
to avoid a compilation error with the macro.

Signed-off-by: Brian Masney <bmasney@redhat.com>
---
 drivers/spi/spi-pxa2xx-platform.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/drivers/spi/spi-pxa2xx-platform.c b/drivers/spi/spi-pxa2xx-platform.c
index 849a14cd0343..2151ed168e57 100644
--- a/drivers/spi/spi-pxa2xx-platform.c
+++ b/drivers/spi/spi-pxa2xx-platform.c
@@ -198,7 +198,7 @@ static const struct of_device_id pxa2xx_spi_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, pxa2xx_spi_of_match);
 
-static struct platform_driver driver = {
+static struct platform_driver pxa2xx_spi_driver = {
 	.driver = {
 		.name	= "pxa2xx-spi",
 		.pm	= pm_ptr(&pxa2xx_spi_pm_ops),
@@ -209,17 +209,7 @@ static struct platform_driver driver = {
 	.remove = pxa2xx_spi_platform_remove,
 };
 
-static int __init pxa2xx_spi_init(void)
-{
-	return platform_driver_register(&driver);
-}
-subsys_initcall(pxa2xx_spi_init);
-
-static void __exit pxa2xx_spi_exit(void)
-{
-	platform_driver_unregister(&driver);
-}
-module_exit(pxa2xx_spi_exit);
+subsys_platform_driver(pxa2xx_spi_driver);
 
 MODULE_AUTHOR("Stephen Street");
 MODULE_DESCRIPTION("PXA2xx SSP SPI Controller platform driver");

-- 
2.56.0

Re: [PATCH 0/2] spi: convert to subsys_platform_driver()

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

On Fri, Nov 06, 2026 at 07:33:07PM -0500, Brian Masney wrote:
> Reduce boilerplate code in these drivers and convert them over to use
> the macro subsys_platform_driver().

This doesn't apply against current code, please check and resend.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 0/2] spi: convert to subsys_platform_driver()

[Brian Masney]

Hi Mark,

On Mon, Nov 09, 2026 at 07:14:33PM +0000, Mark Brown wrote:
> On Fri, Nov 06, 2026 at 07:33:07PM -0500, Brian Masney wrote:
> > Reduce boilerplate code in these drivers and convert them over to use
> > the macro subsys_platform_driver().
> 
> This doesn't apply against current code, please check and resend.

I see that Peng Fan already beat me to this! There's nothing else to add
from my series, so there will be no follow up from me.

Peng: Just a heads up that I posted patches across the tree Friday for
this migrated. I think I changed everything that can be easily migrated.
I suspect we may have collided in other subsystems.

Brian

Re: [PATCH 0/2] spi: convert to subsys_platform_driver()

[Peng Fan]

Hi Brian,

On Mon, Nov 09, 2026 at 04:10:05PM -0500, Brian Masney wrote:
>Hi Mark,
>
>On Mon, Nov 09, 2026 at 07:14:33PM +0000, Mark Brown wrote:
>> On Fri, Nov 06, 2026 at 07:33:07PM -0500, Brian Masney wrote:
>> > Reduce boilerplate code in these drivers and convert them over to use
>> > the macro subsys_platform_driver().
>> 
>> This doesn't apply against current code, please check and resend.
>
>I see that Peng Fan already beat me to this! There's nothing else to add
>from my series, so there will be no follow up from me.
>
>Peng: Just a heads up that I posted patches across the tree Friday for
>this migrated. I think I changed everything that can be easily migrated.
>I suspect we may have collided in other subsystems.

Thanks for the heads up.

I wasn't aware of your earlier treewide conversion series. Sorry for the
duplicated effort.

I generated these conversions using a Coccinelle rule and it appears to
have covered most of the straightforward subsys_platform_driver()
conversions across the tree. If there are any overlaps in other subsystems,
I can the corresponding parts from my series.

Thanks
Peng

>
>Brian
>
>
>