Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: Sudeep Holla <sudeep.holla@kernel.org>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org,
	linux-doc@vger.kernel.org, james.quinlan@broadcom.com,
	f.fainelli@gmail.com, vincent.guittot@linaro.org,
	etienne.carriere@st.com, peng.fan@oss.nxp.com,
	michal.simek@amd.com, d-gole@ti.com,
	jonathan.cameron@oss.qualcomm.com, elif.topuz@arm.com,
	lukasz.luba@arm.com, philip.radford@arm.com, david@kernel.org,
	souvik.chakravarty@arm.com, leitao@kernel.org, kas@kernel.org,
	puranjay@kernel.org, usama.arif@linux.dev, kernel-team@meta.com
Subject: Re: [PATCH v15 00/35] Introduce SCMI Telemetry support
Date: Tue, 17 Nov 2026 13:10:20 +0000	[thread overview]
Message-ID: <avxSPGYrREHtzjXi@pluto> (raw)
In-Reply-To: <20261117-enchanted-neat-donkey-8393a9@sudeepholla>

On Tue, Nov 17, 2026 at 12:43:15PM +0000, Sudeep Holla wrote:
> On Mon, Nov 09, 2026 at 09:11:46AM +0000, Cristian Marussi wrote:
> > Hi all,
> > 

Hi,

> -- 

[snip]

>    + hardened core iterator parsing of multi-part reply
> > 
> 
> You can drop the change log for earlier versions(just last 3 should suffice)
> in the future postings and add links to them instead if anyone is really
> interested to go back. Don't worry about older links now, just do that
> in the future.
> 

Ok.

> [...]
> 
> As mentioned in one of the thread, this is quite big series with not
> much feedback on the UABI part apart for Jonathan. So we need to take
> an approach of merging this in smaller parts initially.
>

Yes I have already split put unused features from V16 both from the
protocol layer and from the driver.

 - no GROUPS
 - no NOTIFICATION
 - no SAMPLE READ (async delayed response)

This way the series is roughly 6500 lines (without docs/ksft/test tool)

...now I was starting going through residual Sashiko bugs of the initial
part of the series (at least), assuming more discussion are needed around
the ABI anyway (still to reply to latest Jonathan mail)


> > Cristian Marussi (34):
> >   firmware: arm_scmi: Harden iterators state parsing
> 
> The above looks good.
> 
> >   firmware: arm_scmi: Add new SCMIv4.0 error codes definitions
> >   firmware: arm_scmi: Introduce a dedicated SCMI Errors header
> 
> As pointed out, better to swap the order of above 2.
>

Ok.
 
> >   firmware: arm_scmi: Allow registration of unknown-size events/reports
> >   firmware: arm_scmi: Refactor __scmi_event_handler_get_ops helper
> >   firmware: arm_scmi: Introduce protocol instance notifiers
> 
> All the above 3 refactor the code, so better to fix the Sashiko reported
> bugs around them before go for such additions/refactoring IMO.
>

I dropeed protocol protocol instance support and notification as
discussed, the new series layout is roughly (with docs/ksft/tool still
to apply split):

c1266f348da4 firmware: arm_scmi: Enable autoloading for System Telemetry driver
8ff6d68673ff firmware: arm_scmi: Add System Telemetry driver
2ab95adf4c0d uapi: Add ARM SCMI Telemetry definitions
8a79c0ca1d11 firmware: arm_scmi: Expose per-instance identifier
ec676846f78c firmware: arm_scmi: Add Telemetry debugfs ABI documentation
6798c6701682 firmware: arm_scmi: Add Telemetry debugfs SHMTI dump support
58cba74addfd firmware: arm_scmi: Add common per-protocol debugfs support
fdfd27649a6e firmware: arm_scmi: Add Telemetry boot-on support
6737d7a797c0 firmware: arm_scmi: Add Telemetry Single/Bulk DEs reads
5507b8b44d15 firmware: arm_scmi: Add Telemetry global configuration support
7aa4c04a61a8 firmware: arm_scmi: Add Telemetry DEs configuration support
e2eec907cddc firmware: arm_scmi: Add Telemetry TDCF parsing for UUID lines
d3c453be30c6 firmware: arm_scmi: Add Telemetry TDCF parsing for BLK_TS lines
328be9a8b32b firmware: arm_scmi: Add Telemetry TDCF areas parsing support
e5d64de593ee firmware: arm_scmi: Add Telemetry SHMTI areas enumeration
d5f25597262d firmware: arm_scmi: Add Telemetry global update intervals enumeration
e23dffd6a103 firmware: arm_scmi: Add Telemetry resources enumeration
dac0f7d33c76 firmware: arm_scmi: Add Telemetry basic attributes enumeration
fa02803cbb1a include: trace: Add Telemetry trace events
4b510f42e44d dt-bindings: firmware: arm,scmi: Add support for telemetry protocol
11f799fe30a4 firmware: arm_scmi: Refactor __scmi_event_handler_get_ops helper
3a2706fedd66 firmware: arm_scmi: Allow registration of unknown-size events/reports
5d196fe1290e firmware: arm_scmi: Introduce a dedicated SCMI Errors header
1877db16c4f5 firmware: arm_scmi: Add new SCMIv4.0 error codes definitions
38e65d778a52 firmware: arm_scmi: Harden iterators state parsing

...BUT especially the removal of GROUPS led to considerable rework so
the above commits does NOT really match the same commit in V15

> >   dt-bindings: firmware: arm,scmi: Add support for telemetry protocol
> >   include: trace: Add Telemetry trace events
> >   firmware: arm_scmi: Add Telemetry basic attributes enumeration
> >   firmware: arm_scmi: Add Telemetry resources enumeration
> >   firmware: arm_scmi: Add Telemetry groups initialization
> >   firmware: arm_scmi: Add Telemetry update intervals enumeration
> >   firmware: arm_scmi: Add Telemetry SHMTI areas enumeration
> >   firmware: arm_scmi: Add Telemetry TDCF areas parsing support
> >   firmware: arm_scmi: Add Telemetry TDCF parsing for BLK_TS lines
> >   firmware: arm_scmi: Add Telemetry TDCF parsing for UUID lines
> >   firmware: arm_scmi: Add Telemetry configuration operations
> >   firmware: arm_scmi: Add Telemetry DataEvent read capabilities
> >   firmware: arm_scmi: Add Telemetry reset logic
> >   firmware: arm_scmi: Add Telemetry notification support
> >   firmware: arm_scmi: Add Telemetry boot-on support
> >   firmware: arm-scmi: Add Telemetry generic event support
> >   firmware: arm_scmi: Add Telemetry generation counter event
> 
> I am thinking of initially merging upto the above commit initially so that
> no user ABI is established. I haven't done the thorough review yet.

Beside a lot of stuff that I removed (like groups all over) there are
outstanding Sashiko issue in the V15/V16 code that I was going to
address now.

Given that, as I understood the agreement was to shed a lot of still
unused features the current V15 and next V16 will be sensibly different.

Thanks,
Cristian


      reply	other threads:[~2026-11-17 13:10 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09  9:11 [PATCH v15 00/35] Introduce SCMI Telemetry support Cristian Marussi
2026-11-09  9:11 ` [PATCH v15 01/35] firmware: arm_scmi: Harden iterators state parsing Cristian Marussi
2026-11-09 21:57   ` Jonathan Cameron
2026-11-10  8:19     ` Cristian Marussi
2026-11-09  9:11 ` [PATCH v15 02/35] firmware: arm_scmi: Add new SCMIv4.0 error codes definitions Cristian Marussi
2026-11-09  9:11 ` [PATCH v15 03/35] firmware: arm_scmi: Introduce a dedicated SCMI Errors header Cristian Marussi
2026-11-09 22:01   ` Jonathan Cameron
2026-11-10  8:23     ` Cristian Marussi
2026-11-09  9:11 ` [PATCH v15 04/35] firmware: arm_scmi: Allow registration of unknown-size events/reports Cristian Marussi
2026-11-09 22:07   ` Jonathan Cameron
2026-11-10  8:27     ` Cristian Marussi
2026-11-09  9:11 ` [PATCH v15 05/35] firmware: arm_scmi: Refactor __scmi_event_handler_get_ops helper Cristian Marussi
2026-11-09  9:11 ` [PATCH v15 06/35] firmware: arm_scmi: Introduce protocol instance notifiers Cristian Marussi
2026-11-09 23:32   ` Jonathan Cameron
2026-11-09  9:11 ` [PATCH v15 07/35] dt-bindings: firmware: arm,scmi: Add support for telemetry protocol Cristian Marussi
2026-11-09  9:11 ` [PATCH v15 08/35] include: trace: Add Telemetry trace events Cristian Marussi
2026-11-09  9:11 ` [PATCH v15 09/35] firmware: arm_scmi: Add Telemetry basic attributes enumeration Cristian Marussi
2026-11-09 23:57   ` Jonathan Cameron
2026-11-09  9:11 ` [PATCH v15 10/35] firmware: arm_scmi: Add Telemetry resources enumeration Cristian Marussi
2026-11-10  1:36   ` Jonathan Cameron
2026-11-10 15:33     ` Cristian Marussi
2026-11-12 18:01   ` Jonathan Cameron
2026-11-12 19:56     ` Cristian Marussi
2026-11-16 21:36       ` Jonathan Cameron
2026-11-09  9:11 ` [PATCH v15 11/35] firmware: arm_scmi: Add Telemetry groups initialization Cristian Marussi
2026-11-10  1:53   ` Jonathan Cameron
2026-11-09  9:11 ` [PATCH v15 12/35] firmware: arm_scmi: Add Telemetry update intervals enumeration Cristian Marussi
2026-11-10  2:07   ` Jonathan Cameron
2026-11-09  9:11 ` [PATCH v15 13/35] firmware: arm_scmi: Add Telemetry SHMTI areas enumeration Cristian Marussi
2026-11-10  2:26   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 14/35] firmware: arm_scmi: Add Telemetry TDCF areas parsing support Cristian Marussi
2026-11-10 18:15   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 15/35] firmware: arm_scmi: Add Telemetry TDCF parsing for BLK_TS lines Cristian Marussi
2026-11-10 18:33   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 16/35] firmware: arm_scmi: Add Telemetry TDCF parsing for UUID lines Cristian Marussi
2026-11-10 18:49   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 17/35] firmware: arm_scmi: Add Telemetry configuration operations Cristian Marussi
2026-11-10 20:07   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 18/35] firmware: arm_scmi: Add Telemetry DataEvent read capabilities Cristian Marussi
2026-11-10 21:59   ` Jonathan Cameron
2026-11-12  4:30   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 19/35] firmware: arm_scmi: Add Telemetry reset logic Cristian Marussi
2026-11-10 22:07   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 20/35] firmware: arm_scmi: Add Telemetry notification support Cristian Marussi
2026-11-10 22:16   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 21/35] firmware: arm_scmi: Add Telemetry boot-on support Cristian Marussi
2026-11-10 22:25   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 22/35] firmware: arm-scmi: Add Telemetry generic event support Cristian Marussi
2026-11-10 22:33   ` Jonathan Cameron
2026-11-12 19:58     ` Cristian Marussi
2026-11-09  9:12 ` [PATCH v15 23/35] firmware: arm_scmi: Add Telemetry generation counter event Cristian Marussi
2026-11-10 22:46   ` Jonathan Cameron
2026-11-12 20:17     ` Cristian Marussi
2026-11-12 21:44       ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 24/35] firmware: arm_scmi: Add common per-protocol debugfs support Cristian Marussi
2026-11-10 22:50   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 25/35] firmware: arm_scmi: Add Telemetry debugfs SHMTI dump support Cristian Marussi
2026-11-10 22:54   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 26/35] firmware: arm_scmi: Add Telemetry debugfs ABI documentation Cristian Marussi
2026-11-10 22:55   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 27/35] firmware: arm_scmi: Expose per-instance identifier Cristian Marussi
2026-11-10 22:57   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 28/35] firmware: arm_scmi: Add un-managed methods to get/put protocols operations Cristian Marussi
2026-11-10 23:01   ` Jonathan Cameron
2026-11-10 23:18   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 29/35] uapi: Add ARM SCMI Telemetry definitions Cristian Marussi
2026-11-10 23:13   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 30/35] firmware: arm_scmi: Add System Telemetry driver Cristian Marussi
2026-11-10 23:46   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 31/35] firmware: arm_scmi: Enable autoloading for " Cristian Marussi
2026-11-09  9:12 ` [PATCH v15 32/35] docs: ioctl-number: Add SCMI Ioctls Cristian Marussi
2026-11-09  9:12 ` [PATCH v15 33/35] Documentation: Add SCMI System Telemetry documentation Cristian Marussi
2026-11-10 23:54   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 34/35] [RFC] kselftest/arm64: Add SCMI Telemetry UAPI compliance testcases Cristian Marussi
2026-11-11  0:13   ` Jonathan Cameron
2026-11-09  9:12 ` [PATCH v15 35/35] [RFC] tools/testing/scmi: Add SCMI Telemetry testing tool Cristian Marussi
2026-11-11  0:16   ` Jonathan Cameron
2026-11-11  0:38 ` [PATCH v15 00/35] Introduce SCMI Telemetry support Jonathan Cameron
2026-11-11  9:51   ` Sudeep Holla
2026-11-11 10:15   ` Cristian Marussi
2026-11-11 18:39     ` Jonathan Cameron
2026-11-17 12:43 ` Sudeep Holla
2026-11-17 13:10   ` Cristian Marussi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avxSPGYrREHtzjXi@pluto \
    --to=cristian.marussi@arm.com \
    --cc=arm-scmi@vger.kernel.org \
    --cc=d-gole@ti.com \
    --cc=david@kernel.org \
    --cc=elif.topuz@arm.com \
    --cc=etienne.carriere@st.com \
    --cc=f.fainelli@gmail.com \
    --cc=james.quinlan@broadcom.com \
    --cc=jonathan.cameron@oss.qualcomm.com \
    --cc=kas@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=leitao@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=michal.simek@amd.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=philip.radford@arm.com \
    --cc=puranjay@kernel.org \
    --cc=souvik.chakravarty@arm.com \
    --cc=sudeep.holla@kernel.org \
    --cc=usama.arif@linux.dev \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox