[PATCH v5] ARM: davinci: da8xx: Fix sleeping function called from invalid context

[abailon@baylibre.com (Alexandre Bailon)]

On 12/06/2016 07:56 PM, David Lechner wrote:
> On 12/06/2016 03:57 AM, Sekhar Nori wrote:
>> On Tuesday 06 December 2016 03:21 PM, Alexandre Bailon wrote:
>>> On 12/06/2016 10:33 AM, Sekhar Nori wrote:
>>>> On Monday 05 December 2016 07:43 PM, Alexandre Bailon wrote:
>>>>> Everytime the usb20 phy is enabled, there is a
>>>>> "sleeping function called from invalid context" BUG.
>>>>>
>>>>> clk_enable() from arch/arm/mach-davinci/clock.c uses
>>>>> spin_lock_irqsave()
>>>>> before to invoke the callback usb20_phy_clk_enable().
>>>>> usb20_phy_clk_enable() uses clk_get() and clk_enable_prepapre()
>>>>> which may sleep.
>>>>> Move clk_get() to da8xx_register_usb20_phy_clk() and
>>>>> replace clk_prepare_enable() by clk_enable().
>>>>>
>>>>> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
>>>>
>>>> This will still cause the recursive locking problem reported by David.
>>>> Not sure what the point of sending this version was.
>>>>
>>>> Thanks,
>>>> Sekhar
>>>>
>>
>>> What am I supposed to do ?
>>
>> That needs to be resolved between you and David. Perhaps convert the fix
>> sent by David into a proper patch and base this patch on that. Or wait
>> for David to send it himself and let him also make the modifications
>> needed in this patch.
>>
>> David ?
>>
>> Thanks,
>> Sekhar
>>
> 
> Alexandre, I was hoping that you would just squash my patch with your
> patch and take Sekhar's suggestion about a separate patch to make the
> private __clk_enable() public as davinci_clk_enable() when you re-submit.
OK.
> 
> You can add "Suggested-By: David Lechner <david@lechnology.com>" to the
> commit message if you would like to give me some credit for my ideas.
That was my concern. I will do that.

Thanks,
Alexandre