Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: abailon@baylibre.com (Alexandre Bailon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] ARM: davinci: da8xx: Fix sleeping function called from invalid context
Date: Tue, 6 Dec 2016 10:51:05 +0100	[thread overview]
Message-ID: <cbf4b99b-e453-acd5-d864-f709708fbab0@baylibre.com> (raw)
In-Reply-To: <2fc7a4ef-02ad-fc15-66ea-9f75756086f8@ti.com>

On 12/06/2016 10:33 AM, Sekhar Nori wrote:
> On Monday 05 December 2016 07:43 PM, Alexandre Bailon wrote:
>> Everytime the usb20 phy is enabled, there is a
>> "sleeping function called from invalid context" BUG.
>>
>> clk_enable() from arch/arm/mach-davinci/clock.c uses spin_lock_irqsave()
>> before to invoke the callback usb20_phy_clk_enable().
>> usb20_phy_clk_enable() uses clk_get() and clk_enable_prepapre()
>> which may sleep.
>> Move clk_get() to da8xx_register_usb20_phy_clk() and
>> replace clk_prepare_enable() by clk_enable().
>>
>> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> 
> This will still cause the recursive locking problem reported by David.
> Not sure what the point of sending this version was.
> 
> Thanks,
> Sekhar
> 
What am I supposed to do ?

Thanks,
Alexandre

  reply	other threads:[~2016-12-06  9:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-05 14:13 [PATCH v5] ARM: davinci: da8xx: Fix sleeping function called from invalid context Alexandre Bailon
2016-12-06  9:33 ` Sekhar Nori
2016-12-06  9:51   ` Alexandre Bailon [this message]
2016-12-06  9:57     ` Sekhar Nori
2016-12-06 18:56       ` David Lechner
2016-12-07  9:07         ` Alexandre Bailon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbf4b99b-e453-acd5-d864-f709708fbab0@baylibre.com \
    --to=abailon@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox