From: Guenter Roeck <linux@roeck-us.net>
To: Frank Li <Frank.Li@nxp.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Jean Delvare <jdelvare@suse.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 2/4] hwmon: tmp108: Add help function tmp108_common_probe()
Date: Fri, 8 Nov 2024 16:11:29 -0800 [thread overview]
Message-ID: <b262ff19-dc57-4a72-9395-25d81e48a476@roeck-us.net> (raw)
In-Reply-To: <c1b77ef0-f01b-4926-8259-e387166d0750@roeck-us.net>
On 11/8/24 15:55, Guenter Roeck wrote:
> On 11/8/24 14:26, Frank Li wrote:
>> Add help function tmp108_common_probe() to pave road to support i3c for
>
> help -> helper
>
>> P3T1085(NXP) chip.
>>
>> Using dev_err_probe() simple code.
>
> Use dev_err_probe() to simplify the code.
>
>>
>> Add compatible string "nxp,p3t1085".
>>
>
> This is borderline and problematic. First, it is the one functional change,
> and second, that functional change is not mentioned in the subject. At the very
> least it needs to be mentioned in the subject. I would, however, prefer two
> separate patches, even if that is just a one-liner.
>
I forgot: The additional chip support should also be mentioned in Kconfig and in
Documentation/hwmon/tmp108.rst.
Thanks,
Guenter
next prev parent reply other threads:[~2024-11-09 0:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 22:26 [PATCH v2 0/4] iio: temperature: Add support for P3T1085 Frank Li
2024-11-08 22:26 ` [PATCH v2 1/4] dt-bindings: hwmon: ti,tmp108: Add nxp,p3t1085 compatible string Frank Li
2024-11-09 10:37 ` Krzysztof Kozlowski
2024-11-08 22:26 ` [PATCH v2 2/4] hwmon: tmp108: Add help function tmp108_common_probe() Frank Li
2024-11-08 23:55 ` Guenter Roeck
2024-11-09 0:11 ` Guenter Roeck [this message]
2024-11-08 22:26 ` [PATCH v2 3/4] hwmon: tmp108: Add support for I3C device Frank Li
2024-11-09 0:10 ` Guenter Roeck
2024-11-09 13:16 ` Jonathan Cameron
2024-11-09 14:53 ` Guenter Roeck
2024-11-09 15:15 ` Jonathan Cameron
2024-11-09 16:18 ` Guenter Roeck
2024-11-11 15:08 ` Frank Li
2024-11-08 22:26 ` [PATCH v2 4/4] arm64: dts: imx93-9x9-qsb: add temp-sensor nxp,p3t1085 Frank Li
2024-11-08 23:56 ` [PATCH v2 0/4] iio: temperature: Add support for P3T1085 Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b262ff19-dc57-4a72-9395-25d81e48a476@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jdelvare@suse.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox