public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: Judith Mendez <jm@ti.com>, Bryan Brattlof <bb@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	"Tero Kristo" <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: ti: Add k3-am62l3-beaglebadge
Date: Tue, 5 May 2026 11:01:28 -0500	[thread overview]
Message-ID: <c8cf753b-f542-40bd-b1ef-a06720b2106c@ti.com> (raw)
In-Reply-To: <073e52f1-f5d0-43aa-b9f0-d4f179838f10@ti.com>

On 5/5/26 10:48 AM, Judith Mendez wrote:
> Hi Bryan, all,
> 
> On 5/4/26 11:19 AM, Bryan Brattlof wrote:
>> On May  1, 2026 thus sayeth Judith Mendez:
>>> BeagleBoard.org BeagleBadge is a compact, affordable open source
>>> hardware single board computer based on the Texas Instruments AM62L3
>>> SoC designed for IoT and embedded applications with low power consumption.
>>> Expansion is provided over open standards based headers including
>>> QWIIC and GPIO interfaces.
>>>
>>> https://beagleboard.org/
>>> https://github.com/beagleboard/BeagleBadge
>>>
>>> Co-developed-by: Andrew Davis <afd@ti.com>
>>> Signed-off-by: Judith Mendez <jm@ti.com>
>>> ---
>>>   arch/arm64/boot/dts/ti/Makefile            |   1 +
>>>   arch/arm64/boot/dts/ti/k3-am62l3-badge.dts | 655 +++++++++++++++++++++
>>
>> ...
>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am62l3-badge.dts
>>> b/arch/arm64/boot/dts/ti/k3-am62l3-badge.dts
>>> new file mode 100644
>>> index 000000000000..0125d3fec5e9
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/ti/k3-am62l3-badge.dts
>>> @@ -0,0 +1,655 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +/*
>>> + * https://www.beagleboard.org/boards/beaglebadge
>>> + *
>>> + * Copyright (C) 2026 Texas Instruments Incorporated - https://www.ti.com/
>>> + */
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include <dt-bindings/gpio/gpio.h>
>>> +#include <dt-bindings/input/input.h>
>>> +#include <dt-bindings/leds/common.h>
>>> +#include <dt-bindings/net/ti-dp83867.h>
>>> +#include "k3-am62l3.dtsi"
>>> +#include "k3-pinctrl.h"
>>> +
>>> +/ {
>>> +    compatible = "beagle,am62l3-badge", "ti,am62l3";
>>
>> I noticed the $subject calls it the k3-am62l3-beaglebadge do we want to
>> name the DT that as well?
>>
>>> +    model = "BeagleBoard.org BeagleBadge";
>>> +
>>
> 
> So I see other beagle boards have the following:
> 
> beagle,am67a-beagley-ai in k3-am67a-beagley-ai.dts
> beagle,am625-beagleplay in k3-am625-beagleplay.dts
> beagle,am62-pocketbeagle2 in k3-am62-pocketbeagle2.dts
> beagle,j721e-beagleboneai64 in k3-j721e-beagleboneai64.dts
> 
> so I think we should be using:
> 
> beagle,am62l3-beaglebadge in k3-am62l3-beaglebadge.dts
> 
> so if it is fine with everyone will update compatible
> & DT filename accordingly.
> 

Looks correct to me.

>>
>>> +&sdhci2 {
>>> +    vmmc-supply = <&wlan_en>;
>>> +    bus-width = <4>;
>>> +    non-removable;
>>> +    cap-power-off-card;
>>> +    keep-power-in-suspend;
>>> +    #address-cells = <1>;
>>> +    #size-cells = <0>;
>>> +    pinctrl-names = "default";
>>> +    pinctrl-0 = <&mmc2_pins_default>;
>>> +    ti,driver-strength-ohm = <50>;
>>> +    ti,fails-without-test-cd;
>>> +    status = "okay";
>>> +
>>> +    wlcore: wlcore@2 {
>>> +        compatible = "ti,cc3300";
>>
>> Sadly this only exists on our evil vendor tree :/
> 
> So sure, I saw that the WIFI driver is not in mainline,
> but I also referenced beagleplay series & it seems
> like as long as the hardware is described properly,
> the node can be upstreamed. Please correct me if I
> am wrong here..
> 

Only in some special cases, but in general the driver needs
to be upstreamed first. And even in those special cases a
DT binding is always needed first. Otherwise how would we know
if the node is described properly.

For Beagleplay I only see the CC1352P7 radio in DT upstream,
and it has a proper binding[0]. For now drop the CC3300, we
can simply add it when the driver gets upstream.

Andrew

[0] Documentation/devicetree/bindings/net/ti,cc1352p7.yaml

>>
>>> +        reg = <2>;
>>> +        interrupt-parent = <&gpio0>;
>>> +        interrupts = <52 IRQ_TYPE_EDGE_RISING>;
>>> +        pinctrl-names = "default";
>>> +        pinctrl-0 = <&wlirq_pins_default>;
>>> +    };
>>> +};
>>> +
>>
>> Scanning over the bootlog it looks like the VTM driver is active but
>> we're missing the thermal-zones{} node which is causing it issues.
> 
> Opps, will add. thanks.
> 
> ~ judith



  reply	other threads:[~2026-05-05 16:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-01 23:31 [PATCH 0/2] arm64: dts/bindings: Add support for BeagleBadge Judith Mendez
2026-05-01 23:31 ` [PATCH 1/2] dt-bindings: arm: ti: Add am62l3-badge Judith Mendez
2026-05-01 23:31 ` [PATCH 2/2] arm64: dts: ti: Add k3-am62l3-beaglebadge Judith Mendez
2026-05-03 11:25   ` Krzysztof Kozlowski
2026-05-05 15:07     ` Judith Mendez
2026-05-04 15:18   ` Andrew Davis
2026-05-05 15:08     ` Judith Mendez
2026-05-04 16:19   ` Bryan Brattlof
2026-05-05 15:48     ` Judith Mendez
2026-05-05 16:01       ` Andrew Davis [this message]
2026-05-05 16:26         ` Judith Mendez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8cf753b-f542-40bd-b1ef-a06720b2106c@ti.com \
    --to=afd@ti.com \
    --cc=bb@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jm@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox