From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Phil Elwell <phil@raspberrypi.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Dan Carpenter <dan.carpenter@oracle.com>,
Stefan Wahren <stefan.wahren@i2se.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH v2 0/3] A trio of vchiq bulk transfer fixes
Date: Mon, 11 Jan 2021 16:43:59 +0100 [thread overview]
Message-ID: <c8e5077c4b7c8ec73316d9c07c088b648e4f03d4.camel@suse.de> (raw)
In-Reply-To: <20210105162030.1415213-1-phil@raspberrypi.com>
[-- Attachment #1.1: Type: text/plain, Size: 1177 bytes --]
On Tue, 2021-01-05 at 16:20 +0000, Phil Elwell wrote:
> The recent batch of vchiq improvements broke bulk transfers in two ways:
>
> 1. The userdata associated with a transfer was lost in the case that a
> non-blocking mode was used.
>
> 2. The 64-bit ioctl compatibility shim for a bulk transfer used the
> wrong ioctl command.
>
> This patch set fixes both of those bugs, and adds a security-related
> note to the TODO file.
>
> Changes in v2:
> - Expand the commit message on patch 1 to clarify the impact of the
> bug, and add Tested-by.
> - Add commit 3 with an additional TODO item.
> - Change the name of the patch set to be numerically accurate.
>
> Phil Elwell (3):
> staging: vchiq: Fix bulk userdata handling
> staging: vchiq: Fix bulk transfers on 64-bit builds
> staging: vc04_services: Add a note to the TODO
>
> drivers/staging/vc04_services/interface/TODO | 4 ++++
> .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 ++++--
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Regards,
Nicolas
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-01-11 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 16:20 [PATCH v2 0/3] A trio of vchiq bulk transfer fixes Phil Elwell
2021-01-05 16:20 ` [PATCH v2 1/3] staging: vchiq: Fix bulk userdata handling Phil Elwell
2021-01-05 16:20 ` [PATCH v2 2/3] staging: vchiq: Fix bulk transfers on 64-bit builds Phil Elwell
2021-01-05 18:18 ` Arnd Bergmann
2021-01-05 16:20 ` [PATCH v2 3/3] staging: vc04_services: Add a note to the TODO Phil Elwell
2021-01-05 17:04 ` [PATCH v2 0/3] A trio of vchiq bulk transfer fixes Dan Carpenter
2021-01-11 15:43 ` Nicolas Saenz Julienne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8e5077c4b7c8ec73316d9c07c088b648e4f03d4.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=phil@raspberrypi.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox