From: nicolas saenz julienne <nsaenz@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>,
Scott Branden <sbranden@broadcom.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: linux-rpi-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Phil Elwell <phil@raspberrypi.com>,
Tim Gover <tim.gover@raspberrypi.com>,
Dom Cobley <dom@raspberrypi.com>,
devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 0/5] drm/vc4: Use the firmware to stop the display pipeline
Date: Tue, 30 Nov 2021 12:45:49 +0100 [thread overview]
Message-ID: <cad0e66b5cb88f224bbbe54e7ed8552275864733.camel@kernel.org> (raw)
In-Reply-To: <20211117145040.334827-1-maxime@cerno.tech>
Hi Maxime,
On Wed, 2021-11-17 at 15:50 +0100, Maxime Ripard wrote:
> Hi,
>
> The VC4 driver has had limited support to disable the HDMI controllers and
> pixelvalves at boot if the firmware has enabled them.
>
> However, this proved to be limited, and a bit unreliable so a new firmware
> command has been introduced some time ago to make it free all its resources and
> disable any display output it might have enabled.
>
> This series takes advantage of that command to call it once the transition from
> simplefb to the KMS driver has been done.
I think it would make sense to integrate this funtionality into
'reset/reset-raspberrypi.c' and pass it to VC4 as a reset controller. It fits
the same startup situation as the one we have with the USB controller. Also, it
would contain the firmware weirdness in a single spot.
Otherwise, please use 'devm_rpi_firmware_get()'.
Regards,
Nicolas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-30 11:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 14:50 [PATCH 0/5] drm/vc4: Use the firmware to stop the display pipeline Maxime Ripard
2021-11-17 14:50 ` [PATCH 1/5] dt-bindings: display: vc4: Add optional phandle to firmware Maxime Ripard
2021-11-29 22:49 ` Rob Herring
2021-11-17 14:50 ` [PATCH 2/5] firmware: raspberrypi: Add RPI_FIRMWARE_NOTIFY_DISPLAY_DONE Maxime Ripard
2021-11-17 14:50 ` [PATCH 3/5] drm/vc4: Remove conflicting framebuffers before callind bind_all Maxime Ripard
2021-11-17 14:50 ` [PATCH 4/5] drm/vc4: Notify the firmware when DRM is in charge Maxime Ripard
2021-11-17 14:50 ` [PATCH 5/5] ARM: dts: rpi: Add the firmware node to vc4 Maxime Ripard
2021-11-30 11:45 ` nicolas saenz julienne [this message]
2021-12-03 13:50 ` [PATCH 0/5] drm/vc4: Use the firmware to stop the display pipeline Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cad0e66b5cb88f224bbbe54e7ed8552275864733.camel@kernel.org \
--to=nsaenz@kernel.org \
--cc=airlied@linux.ie \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.vetter@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dom@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=phil@raspberrypi.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=tim.gover@raspberrypi.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox