Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] coresight: dummy: add missing MODULE_DEVICE_TABLE()
@ 2026-07-04 12:16 Pengpeng Hou
  2026-07-06  0:35 ` Jie Gan
  0 siblings, 1 reply; 2+ messages in thread
From: Pengpeng Hou @ 2026-07-04 12:16 UTC (permalink / raw)
  To: Suzuki K Poulose, Mike Leach, James Clark, Leo Yan,
	Alexander Shishkin
  Cc: Pengpeng Hou, coresight, linux-arm-kernel, linux-kernel

The driver has an OF match table wired to .of_match_table, but does
not export the table with MODULE_DEVICE_TABLE().

Add the missing MODULE_DEVICE_TABLE(of, ...) entry so module alias
information is generated for OF based module autoloading.

This is a source-level fix.  It does not claim dynamic hardware
reproduction; the evidence is the driver-owned match table, its use by
the platform driver, and the missing module alias publication.

Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
 drivers/hwtracing/coresight/coresight-dummy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hwtracing/coresight/coresight-dummy.c b/drivers/hwtracing/coresight/coresight-dummy.c
index c176a2f57300..04880d38feb7 100644
--- a/drivers/hwtracing/coresight/coresight-dummy.c
+++ b/drivers/hwtracing/coresight/coresight-dummy.c
@@ -212,6 +212,7 @@ static const struct of_device_id dummy_match[] = {
 	{.compatible = "arm,coresight-dummy-sink"},
 	{},
 };
+MODULE_DEVICE_TABLE(of, dummy_match);
 
 static struct platform_driver dummy_driver = {
 	.probe	= dummy_probe,



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] coresight: dummy: add missing MODULE_DEVICE_TABLE()
  2026-07-04 12:16 [PATCH] coresight: dummy: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
@ 2026-07-06  0:35 ` Jie Gan
  0 siblings, 0 replies; 2+ messages in thread
From: Jie Gan @ 2026-07-06  0:35 UTC (permalink / raw)
  To: Pengpeng Hou, Suzuki K Poulose, Mike Leach, James Clark, Leo Yan,
	Alexander Shishkin
  Cc: coresight, linux-arm-kernel, linux-kernel



On 7/4/2026 8:16 PM, Pengpeng Hou wrote:
> The driver has an OF match table wired to .of_match_table, but does
> not export the table with MODULE_DEVICE_TABLE().
> 
> Add the missing MODULE_DEVICE_TABLE(of, ...) entry so module alias
> information is generated for OF based module autoloading.
> 
> This is a source-level fix.  It does not claim dynamic hardware
> reproduction; the evidence is the driver-owned match table, its use by
> the platform driver, and the missing module alias publication.
> 

Thanks for fixing the autoload issue.
Please add the fixes tag for the fix patch.

Fixes: 9d3ba0b6c056 ("Coresight: Add coresight dummy driver")

With the tag:

Reviewed-by: Jie Gan <jie.gan@oss.qualcomm.com>

> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
>   drivers/hwtracing/coresight/coresight-dummy.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-dummy.c b/drivers/hwtracing/coresight/coresight-dummy.c
> index c176a2f57300..04880d38feb7 100644
> --- a/drivers/hwtracing/coresight/coresight-dummy.c
> +++ b/drivers/hwtracing/coresight/coresight-dummy.c
> @@ -212,6 +212,7 @@ static const struct of_device_id dummy_match[] = {
>   	{.compatible = "arm,coresight-dummy-sink"},
>   	{},
>   };
> +MODULE_DEVICE_TABLE(of, dummy_match);
>   
>   static struct platform_driver dummy_driver = {
>   	.probe	= dummy_probe,
> 
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-06  0:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-04 12:16 [PATCH] coresight: dummy: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
2026-07-06  0:35 ` Jie Gan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox