From: Samuel Holland <samuel@sholland.org>
To: Andre Przywara <andre.przywara@arm.com>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>,
SASANO Takayoshi <uaa@mx5.nisiq.net>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] pinctrl: sunxi: Fix H616 I2S3 pin data
Date: Thu, 6 Jan 2022 20:14:33 -0600 [thread overview]
Message-ID: <ccc2aae8-1265-adfa-d749-1a9d54bd8443@sholland.org> (raw)
In-Reply-To: <20220105172952.23347-1-andre.przywara@arm.com>
On 1/5/22 11:29 AM, Andre Przywara wrote:
> Two bugs have sneaked in the H616 pinctrl data:
> - PH9 uses the mux value of 0x3 twice (one should be 0x5 instead)
> - PH8 and PH9 use the "i2s3" function name twice in each pin
>
> For the double pin name we use the same trick we pulled for i2s0: append
> the pin function to the group name to designate the special function.
>
> Fixes: 25adc29407fb ("pinctrl: sunxi: Add support for the Allwinner H616 pin controller")
> Reported-by: SASANO Takayoshi <uaa@mx5.nisiq.net>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Samuel Holland <samuel@sholland.org>
Verified against the manual, which ironically also has the function numbers
wrong: it lists two function 4's (and no function 5) for each pin in port H.
> ---
> drivers/pinctrl/sunxi/pinctrl-sun50i-h616.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/sunxi/pinctrl-sun50i-h616.c b/drivers/pinctrl/sunxi/pinctrl-sun50i-h616.c
> index ce1917e230f4..152b71226a80 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-sun50i-h616.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-sun50i-h616.c
> @@ -363,16 +363,16 @@ static const struct sunxi_desc_pin h616_pins[] = {
> SUNXI_FUNCTION(0x0, "gpio_in"),
> SUNXI_FUNCTION(0x1, "gpio_out"),
> SUNXI_FUNCTION(0x2, "uart2"), /* CTS */
> - SUNXI_FUNCTION(0x3, "i2s3"), /* DO0 */
> + SUNXI_FUNCTION(0x3, "i2s3_dout0"), /* DO0 */
> SUNXI_FUNCTION(0x4, "spi1"), /* MISO */
> - SUNXI_FUNCTION(0x5, "i2s3"), /* DI1 */
> + SUNXI_FUNCTION(0x5, "i2s3_din1"), /* DI1 */
> SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 8)), /* PH_EINT8 */
> SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 9),
> SUNXI_FUNCTION(0x0, "gpio_in"),
> SUNXI_FUNCTION(0x1, "gpio_out"),
> - SUNXI_FUNCTION(0x3, "i2s3"), /* DI0 */
> + SUNXI_FUNCTION(0x3, "i2s3_din0"), /* DI0 */
> SUNXI_FUNCTION(0x4, "spi1"), /* CS1 */
> - SUNXI_FUNCTION(0x3, "i2s3"), /* DO1 */
> + SUNXI_FUNCTION(0x5, "i2s3_dout1"), /* DO1 */
> SUNXI_FUNCTION_IRQ_BANK(0x6, 6, 9)), /* PH_EINT9 */
> SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 10),
> SUNXI_FUNCTION(0x0, "gpio_in"),
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-07 2:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 17:29 [PATCH] pinctrl: sunxi: Fix H616 I2S3 pin data Andre Przywara
2022-01-07 2:14 ` Samuel Holland [this message]
2022-01-13 7:09 ` Jernej Škrabec
2022-01-16 1:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccc2aae8-1265-adfa-d749-1a9d54bd8443@sholland.org \
--to=samuel@sholland.org \
--cc=andre.przywara@arm.com \
--cc=jernej.skrabec@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=uaa@mx5.nisiq.net \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox