Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/2] Add R8A77980/Condor PCIe support
Date: Mon, 18 Jun 2018 19:16:47 +0300	[thread overview]
Message-ID: <cfa599bd-d244-0032-490b-553f7870d07c@cogentembedded.com> (raw)
In-Reply-To: <20180618093623.s33bkiptazxem463@verge.net.au>

On 06/18/2018 12:36 PM, Simon Horman wrote:

>> Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's
>> 'renesas-devel-20180614v2-v4.17' tag. We're adding the R8A77980 PCIe related
>> device nodes and then enable PCIe on the Condor board. These patches depend
>> on the R8A77980 PCIe PHY driver support in order to work properly. Note that
>> in case the PCIe PHY driver is not enabled, the kernel will BUG() due to I/O
>> space page leak in the PCIe driver...
> 
> Is that problem specific to the presence of PCIe nodes for
> condor/r8a77980

   The nodes are safe unless they are enabled, so the Condor patch may be
deferred untl I fix the PCI code.
> condor/r8a77980 or is it also true of other (R-Car) boards where
> PCIe is enabled?

   The leak happens every time the driver fails to probe later than
pci_remap_iospace() is called but the BUG_ON() is only triggered by rhe 2nd try
with EPROBE_DEFER returned previously.

> Regardless, it sounds like these patches expose a kernel bug.
> Is it being fixed?

   I'm working on a fix (which embraces several PCI drivers)...

>> [1/2] arm64: dts: renesas: r8a77980: add PCIe support
>> [2/2] arm64: dts: renesas: condor: add PCIe support

WBR, Sergei

  reply	other threads:[~2018-06-18 16:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14 19:16 [PATCH v2 0/2] Add R8A77980/Condor PCIe support Sergei Shtylyov
2018-06-14 19:17 ` [PATCH v2 1/2] arm64: dts: renesas: r8a77980: add " Sergei Shtylyov
2018-06-20  8:49   ` Simon Horman
2018-06-14 19:19 ` [PATCH v2 2/2] arm64: dts: renesas: condor: " Sergei Shtylyov
2018-06-18  9:36 ` [PATCH v2 0/2] Add R8A77980/Condor " Simon Horman
2018-06-18 16:16   ` Sergei Shtylyov [this message]
2018-06-20  8:50     ` Simon Horman
  -- strict thread matches above, loose matches on Subject: below --
2018-08-27 18:48 Sergei Shtylyov
2018-08-27 18:52 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfa599bd-d244-0032-490b-553f7870d07c@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox