From: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bryan O'Donoghue <bod@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Robert Foss <rfoss@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
Suresh Vankadara <quic_svankada@quicinc.com>,
Vikram Sharma <vikram.sharma@oss.qualcomm.com>
Subject: Re: [PATCH v4 4/6] arm64: dts: qcom: shikra: Add pin configuration for mclks
Date: Sun, 21 Jun 2026 11:30:59 +0530 [thread overview]
Message-ID: <cfe1778b-c204-46cd-a9c8-2bcda8ea63ac@oss.qualcomm.com> (raw)
In-Reply-To: <6e760884-87b1-4ec8-9ae1-e53901451b65@oss.qualcomm.com>
On 19-06-2026 21:06, Konrad Dybcio wrote:
>> + cam_mclk3_default: cam-mclk3-default-state {
>> + pins = "gpio98";
>> + function = "cam_mclk";
>> + drive-strength = <2>;
>> + bias-disable;
>> + };
> Please try to keep the entries roughly sorted by the pin index
>
> For the entries themselves:
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
ACK, will fix pin ordering in v5 - qup_uart0 (gpio0/1/...) first,
then cci_i2c(gpio36/37/41/42), then mclk0-3(gpio34/35/96/98).
Could you please review the other DTS patches too?
--
Regards,
Nihal Kumar Gupta
next prev parent reply other threads:[~2026-06-21 6:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 8:33 [PATCH v4 0/6] Add CAMSS and IMX577 sensor support for Shikra EVK Nihal Kumar Gupta
2026-06-15 8:33 ` [PATCH v4 1/6] dt-bindings: media: qcom: Add Shikra CAMSS compatible Nihal Kumar Gupta
2026-06-15 8:33 ` [PATCH v4 2/6] arm64: dts: qcom: shikra: Add CAMSS node Nihal Kumar Gupta
2026-06-15 8:33 ` [PATCH v4 3/6] arm64: dts: qcom: shikra: Add CCI definitions Nihal Kumar Gupta
2026-06-15 8:33 ` [PATCH v4 4/6] arm64: dts: qcom: shikra: Add pin configuration for mclks Nihal Kumar Gupta
2026-06-19 15:36 ` Konrad Dybcio
2026-06-21 6:00 ` Nihal Kumar Gupta [this message]
2026-06-15 8:33 ` [PATCH v4 5/6] arm64: dts: qcom: shikra-cqm-cqs-evk-imx577-camera: Add DT overlay Nihal Kumar Gupta
2026-06-15 8:33 ` [PATCH v4 6/6] arm64: dts: qcom: shikra-iqs-evk-imx577-camera: " Nihal Kumar Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfe1778b-c204-46cd-a9c8-2bcda8ea63ac@oss.qualcomm.com \
--to=nihal.gupta@oss.qualcomm.com \
--cc=Frank.Li@nxp.com \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=quic_svankada@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=vikram.sharma@oss.qualcomm.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox