[PATCH v4 0/3] arm64: dts: k3: Resolve remaining dtbs_check warnings

[PATCH v4 0/3] arm64: dts: k3: Resolve remaining dtbs_check warnings

[Jan Kiszka]

Changes in v4:
 - drop no longer applicable mux-controller
 - model dss-oldi-io-ctrl@41e0 and clock-controller@4140 as regular property

Changes in v3:
 - convert mux-controller from patternProperties to regular one
 - dropped k3-j72xx-mcu-wakeup patch after simple-bus conversion

Changes in v2:
 - reference reg-mux.yaml in am654-system-controller child node
 - base on top of dedicated am654-serdes-ctrl schema patch

This goes on top of
https://patchwork.kernel.org/project/linux-arm-kernel/cover/20240518-dt-bindings-ti-soc-mfd-v1-0-b3952f104c9a@linaro.org/

As we are working in this area, having a zero-warning baseline helps a
lot finding own issues quicker. Maybe not all of the suggested
resolutions are optimal, open for feedback, just want to have them all
fixed now soon.

Jan

Jan Kiszka (3):
  arm64: dts: ti: k3-am642-evm: Silence schema warning
  dt-bindings: soc: ti: am645-system-controller: add child nodes used by
    main domain
  arm64: dts: ti: k3-am65-main: add system controller compatible

 .../soc/ti/ti,am654-system-controller.yaml    | 19 +++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-am642-evm.dts       |  4 ++++
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi      |  2 +-
 3 files changed, 24 insertions(+), 1 deletion(-)

-- 
2.43.0

[PATCH v4 1/3] arm64: dts: ti: k3-am642-evm: Silence schema warning

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

The resolves

k3-am642-evm.dtb: adc: 'ti,adc-channels' is a required property
        from schema $id: http://devicetree.org/schemas/iio/adc/ti,am3359-adc.yaml#

As the adc is reserved, thus not used by Linux, this has no practical
impact.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 arch/arm64/boot/dts/ti/k3-am642-evm.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
index 6bb1ad2e56ec..42015a55e0d3 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
@@ -646,6 +646,10 @@ cpsw3g_phy0: ethernet-phy@0 {
 &tscadc0 {
 	/* ADC is reserved for R5 usage */
 	status = "reserved";
+
+	adc {
+		ti,adc-channels = <0 1 2 3 4 5 6 7>;
+	};
 };
 
 &ospi0 {
-- 
2.43.0

[PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

Expand bindings to cover both the MCU and the main usage of the AM654
system controller.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 .../soc/ti/ti,am654-system-controller.yaml    | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
index e79803e586ca..cb9da3ec39a8 100644
--- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
@@ -29,11 +29,30 @@ properties:
 
   ranges: true
 
+  dss-oldi-io-ctrl@41e0:
+    type: object
+    $ref: /schemas/mfd/syscon.yaml#
+    properties:
+      compatible:
+        items:
+          - const: ti,am654-dss-oldi-io-ctrl
+          - const: syscon
+
+  clock-controller@4140:
+    type: object
+    $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml#
+    description:
+      Clock provider for TI EHRPWM nodes.
+
 patternProperties:
   "^phy@[0-9a-f]+$":
     type: object
     $ref: /schemas/phy/ti,phy-gmii-sel.yaml#
 
+  "^clock@[0-9a-f]+$":
+    type: object
+    $ref: /schemas/soc/ti/ti,am654-serdes-ctrl.yaml#
+
 required:
   - compatible
   - reg
-- 
2.43.0

Re: [PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

On Wed, Aug 14, 2024 at 06:37:18PM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Expand bindings to cover both the MCU and the main usage of the AM654
> system controller.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain

[Nishanth Menon]

On 18:37-20240814, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Expand bindings to cover both the MCU and the main usage of the AM654
> system controller.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  .../soc/ti/ti,am654-system-controller.yaml    | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> index e79803e586ca..cb9da3ec39a8 100644
> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml

As per linux-next, this file does not exist? looks like you might need
to rebase on latest next?

> @@ -29,11 +29,30 @@ properties:
>  
>    ranges: true
>  
> +  dss-oldi-io-ctrl@41e0:
> +    type: object
> +    $ref: /schemas/mfd/syscon.yaml#
> +    properties:
> +      compatible:
> +        items:
> +          - const: ti,am654-dss-oldi-io-ctrl
> +          - const: syscon
> +
> +  clock-controller@4140:
> +    type: object
> +    $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml#
> +    description:
> +      Clock provider for TI EHRPWM nodes.
> +
>  patternProperties:
>    "^phy@[0-9a-f]+$":
>      type: object
>      $ref: /schemas/phy/ti,phy-gmii-sel.yaml#
>  
> +  "^clock@[0-9a-f]+$":
> +    type: object
> +    $ref: /schemas/soc/ti/ti,am654-serdes-ctrl.yaml#
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.43.0
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain

[Jan Kiszka]

On 24.08.24 19:58, Nishanth Menon wrote:
> On 18:37-20240814, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Expand bindings to cover both the MCU and the main usage of the AM654
>> system controller.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  .../soc/ti/ti,am654-system-controller.yaml    | 19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
>> index e79803e586ca..cb9da3ec39a8 100644
>> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> 
> As per linux-next, this file does not exist? looks like you might need
> to rebase on latest next?
> 

"This goes on top of
https://patchwork.kernel.org/project/linux-arm-kernel/cover/20240518-dt-bindings-ti-soc-mfd-v1-0-b3952f104c9a@linaro.org/"

Is that series obsolete by now?

Jan

>> @@ -29,11 +29,30 @@ properties:
>>  
>>    ranges: true
>>  
>> +  dss-oldi-io-ctrl@41e0:
>> +    type: object
>> +    $ref: /schemas/mfd/syscon.yaml#
>> +    properties:
>> +      compatible:
>> +        items:
>> +          - const: ti,am654-dss-oldi-io-ctrl
>> +          - const: syscon
>> +
>> +  clock-controller@4140:
>> +    type: object
>> +    $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml#
>> +    description:
>> +      Clock provider for TI EHRPWM nodes.
>> +
>>  patternProperties:
>>    "^phy@[0-9a-f]+$":
>>      type: object
>>      $ref: /schemas/phy/ti,phy-gmii-sel.yaml#
>>  
>> +  "^clock@[0-9a-f]+$":
>> +    type: object
>> +    $ref: /schemas/soc/ti/ti,am654-serdes-ctrl.yaml#
>> +
>>  required:
>>    - compatible
>>    - reg
>> -- 
>> 2.43.0
>>
> 

-- 
Siemens AG, Technology
Linux Expert Center

Re: [PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain

[Nishanth Menon]

On 13:31-20240826, Jan Kiszka wrote:
> On 24.08.24 19:58, Nishanth Menon wrote:
> > On 18:37-20240814, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> Expand bindings to cover both the MCU and the main usage of the AM654
> >> system controller.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >> ---
> >>  .../soc/ti/ti,am654-system-controller.yaml    | 19 +++++++++++++++++++
> >>  1 file changed, 19 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> >> index e79803e586ca..cb9da3ec39a8 100644
> >> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> >> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> > 
> > As per linux-next, this file does not exist? looks like you might need
> > to rebase on latest next?
> > 
> 
> "This goes on top of
> https://patchwork.kernel.org/project/linux-arm-kernel/cover/20240518-dt-bindings-ti-soc-mfd-v1-0-b3952f104c9a@linaro.org/"
> 
> Is that series obsolete by now?

This dependency information would have been useful when provided under the
diffstat section of the representative patch. :(

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain

[Jan Kiszka]

On 26.08.24 13:42, Nishanth Menon wrote:
> On 13:31-20240826, Jan Kiszka wrote:
>> On 24.08.24 19:58, Nishanth Menon wrote:
>>> On 18:37-20240814, Jan Kiszka wrote:
>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>
>>>> Expand bindings to cover both the MCU and the main usage of the AM654
>>>> system controller.
>>>>
>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>>> ---
>>>>  .../soc/ti/ti,am654-system-controller.yaml    | 19 +++++++++++++++++++
>>>>  1 file changed, 19 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
>>>> index e79803e586ca..cb9da3ec39a8 100644
>>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
>>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
>>>
>>> As per linux-next, this file does not exist? looks like you might need
>>> to rebase on latest next?
>>>
>>
>> "This goes on top of
>> https://patchwork.kernel.org/project/linux-arm-kernel/cover/20240518-dt-bindings-ti-soc-mfd-v1-0-b3952f104c9a@linaro.org/"
>>
>> Is that series obsolete by now?
> 
> This dependency information would have been useful when provided under the
> diffstat section of the representative patch. :(
> 

Yeah, who reads cover letters? ;) Will try to do that next time.

Jan

-- 
Siemens AG, Technology
Linux Expert Center

Re: [PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain

[Nishanth Menon]

On 14:01-20240826, Jan Kiszka wrote:
> On 26.08.24 13:42, Nishanth Menon wrote:
> > On 13:31-20240826, Jan Kiszka wrote:
> >> On 24.08.24 19:58, Nishanth Menon wrote:
> >>> On 18:37-20240814, Jan Kiszka wrote:
> >>>> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>>>
> >>>> Expand bindings to cover both the MCU and the main usage of the AM654
> >>>> system controller.
> >>>>
> >>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >>>> ---
> >>>>  .../soc/ti/ti,am654-system-controller.yaml    | 19 +++++++++++++++++++
> >>>>  1 file changed, 19 insertions(+)
> >>>>
> >>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> >>>> index e79803e586ca..cb9da3ec39a8 100644
> >>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> >>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> >>>
> >>> As per linux-next, this file does not exist? looks like you might need
> >>> to rebase on latest next?
> >>>
> >>
> >> "This goes on top of
> >> https://patchwork.kernel.org/project/linux-arm-kernel/cover/20240518-dt-bindings-ti-soc-mfd-v1-0-b3952f104c9a@linaro.org/"
> >>
> >> Is that series obsolete by now?
> > 
> > This dependency information would have been useful when provided under the
> > diffstat section of the representative patch. :(
> > 
> 
> Yeah, who reads cover letters? ;) Will try to do that next time.

Looking at what we included in v6.11, looks like the above series from
krystoff will need to be re-thought through.
[1] makes the patches un-necessary to an extent by modelling the node as
a simple-bus - Looks like k3-am62-wakeup.dtsi was missed, but it should
be trivial enough fixup. Did you try applying the series on latest next?
it should not apply anymore (Doesn't apply on master either).

[1] https://lore.kernel.org/all/20240628151518.40100-1-afd@ti.com/

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain

[Jan Kiszka]

On 26.08.24 21:59, Nishanth Menon wrote:
> On 14:01-20240826, Jan Kiszka wrote:
>> On 26.08.24 13:42, Nishanth Menon wrote:
>>> On 13:31-20240826, Jan Kiszka wrote:
>>>> On 24.08.24 19:58, Nishanth Menon wrote:
>>>>> On 18:37-20240814, Jan Kiszka wrote:
>>>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>>>
>>>>>> Expand bindings to cover both the MCU and the main usage of the AM654
>>>>>> system controller.
>>>>>>
>>>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>>>>> ---
>>>>>>  .../soc/ti/ti,am654-system-controller.yaml    | 19 +++++++++++++++++++
>>>>>>  1 file changed, 19 insertions(+)
>>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
>>>>>> index e79803e586ca..cb9da3ec39a8 100644
>>>>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
>>>>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
>>>>>
>>>>> As per linux-next, this file does not exist? looks like you might need
>>>>> to rebase on latest next?
>>>>>
>>>>
>>>> "This goes on top of
>>>> https://patchwork.kernel.org/project/linux-arm-kernel/cover/20240518-dt-bindings-ti-soc-mfd-v1-0-b3952f104c9a@linaro.org/"
>>>>
>>>> Is that series obsolete by now?
>>>
>>> This dependency information would have been useful when provided under the
>>> diffstat section of the representative patch. :(
>>>
>>
>> Yeah, who reads cover letters? ;) Will try to do that next time.
> 
> Looking at what we included in v6.11, looks like the above series from
> krystoff will need to be re-thought through.
> [1] makes the patches un-necessary to an extent by modelling the node as
> a simple-bus - Looks like k3-am62-wakeup.dtsi was missed, but it should
> be trivial enough fixup. Did you try applying the series on latest next?
> it should not apply anymore (Doesn't apply on master either).
> 
> [1] https://lore.kernel.org/all/20240628151518.40100-1-afd@ti.com/
> 

Krystoff's and my patches still apply on top of master and next.

I don't mind via which patches we finally get to zero dtbs_check
warnings, just that we get there.

Jan

-- 
Siemens AG, Technology
Linux Expert Center

Re: [PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain

[Nishanth Menon]

On 22:13-20240826, Jan Kiszka wrote:
[..]
> I don't mind via which patches we finally get to zero dtbs_check
> warnings, just that we get there.

Sure. Since we are on the cleanup path towards simple-bus, lets just get
there.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

[PATCH v4 3/3] arm64: dts: ti: k3-am65-main: add system controller compatible

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

Now that the TI K3 AM654 system controller bindings also cover the usage
in the main domain, add its compatible to address dtbs_check complaints:

  k3-am654-base-board.dtb: scm-conf@100000: compatible: ['syscon', 'simple-mfd'] is too short

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index 06ed74197f89..a8664b246795 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -471,7 +471,7 @@ sdhci1: mmc@4fa0000 {
 	};
 
 	scm_conf: scm-conf@100000 {
-		compatible = "syscon", "simple-mfd";
+		compatible = "ti,am654-system-controller", "syscon", "simple-mfd";
 		reg = <0 0x00100000 0 0x1c000>;
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
2.43.0

Re: (subset) [PATCH v4 0/3] arm64: dts: k3: Resolve remaining dtbs_check warnings

[Nishanth Menon]

Hi Jan Kiszka,

On Wed, 14 Aug 2024 18:37:16 +0200, Jan Kiszka wrote:
> Changes in v4:
>  - drop no longer applicable mux-controller
>  - model dss-oldi-io-ctrl@41e0 and clock-controller@4140 as regular property
> 
> Changes in v3:
>  - convert mux-controller from patternProperties to regular one
>  - dropped k3-j72xx-mcu-wakeup patch after simple-bus conversion
> 
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
I have picked Andrew's fixups, so just 1 patch in this series
is relevant. Let me know if you disagree. Thank you!

[1/3] arm64: dts: ti: k3-am642-evm: Silence schema warning
      commit: 182a862560097dec7adf774af58076984cd6c1ed

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D