From: Paolo Abeni <pabeni@redhat.com>
To: "Pandey, Radhey Shyam" <radheys@amd.com>,
phucduc.bui@gmail.com,
Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Michal Simek <michal.simek@amd.com>,
Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] net: xilinx: axienet: Handle optional IRQ return value correctly
Date: Thu, 20 Aug 2026 11:42:28 +0200 [thread overview]
Message-ID: <d6770227-a034-48e8-ae36-ff49ef3f83ec@redhat.com> (raw)
In-Reply-To: <38099370-269b-4d3e-a686-5b29d806e6a3@amd.com>
On 8/18/26 8:39 AM, Pandey, Radhey Shyam wrote:
> On 8/17/2026 4:22 PM, phucduc.bui@gmail.com wrote:
>> From: bui duc phuc <phucduc.bui@gmail.com>
>>
>> lp->eth_irq is assigned from platform_get_irq_optional(), which returns
>> a non-zero interrupt number on success or a negative error number on
>> failure. Errors other than -ENXIO are handled before this check,
>> so -ENXIO is the only error value that can reach this point.
>>
>> Check for a negative value instead of treating 0 as an undefined IRQ.
>>
>> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
>
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> Thanks!
IMHO even this one is 'net' material deserving a fixes tag.
@bui: please re-submit the whole series targeting the proper tree and
including the needed tags. Be sure to read and understand the relevant
documentation including:
Documentation/process/maintainer-netdev.rst
before submitting the next revision.
/P
next prev parent reply other threads:[~2026-08-20 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 10:52 [PATCH v3 1/3] net: xilinx: axienet: Propagate errors from optional IRQ lookup phucduc.bui
2026-08-17 10:52 ` [PATCH v3 2/3] net: xilinx: axienet: Handle optional IRQ return value correctly phucduc.bui
2026-08-18 6:39 ` Pandey, Radhey Shyam
2026-08-20 9:42 ` Paolo Abeni [this message]
2026-08-20 11:19 ` Bui Duc Phuc
2026-08-17 10:52 ` [PATCH v3 3/3] net: xilinx: axienet: Propagate errors from platform_get_irq() phucduc.bui
2026-08-18 6:41 ` Pandey, Radhey Shyam
2026-08-17 13:58 ` [PATCH v3 1/3] net: xilinx: axienet: Propagate errors from optional IRQ lookup Pandey, Radhey Shyam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6770227-a034-48e8-ae36-ff49ef3f83ec@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=phucduc.bui@gmail.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=radheys@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox