Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/2] dt-bindings: pwm: rockchip: add RK3506 and RK3576 PWM
       [not found] <20261121065936.1125919-1-1194781887@qq.com>
@ 2026-11-21  6:59 ` ZhuXiangyu
  2026-11-21 13:35   ` Heiko Stübner
  0 siblings, 1 reply; 2+ messages in thread
From: ZhuXiangyu @ 2026-11-21  6:59 UTC (permalink / raw)
  To: Uwe Kleine-König, Heiko Stuebner
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-pwm,
	linux-arm-kernel, linux-rockchip, linux-kernel, devicetree,
	ZhuXiangyu

Document the PWM v4 controllers found on RK3506 and RK3576. They use
the pwm/pclk clocks and may additionally provide the osc and rc
clocks used by the extended features.

Signed-off-by: ZhuXiangyu <1194781887@qq.com>
---
 .../devicetree/bindings/pwm/pwm-rockchip.yaml | 54 +++++++++++++++----
 1 file changed, 45 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
index c8cdfb72..ea6622d9 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
@@ -15,6 +15,8 @@ properties:
       - const: rockchip,rk2928-pwm
       - const: rockchip,rk3288-pwm
       - const: rockchip,rk3328-pwm
+      - const: rockchip,rk3506-pwm
+      - const: rockchip,rk3576-pwm
       - const: rockchip,vop-pwm
       - items:
           - const: rockchip,rk3036-pwm
@@ -42,10 +44,16 @@ properties:
 
   clocks:
     minItems: 1
-    maxItems: 2
+    maxItems: 4
 
   clock-names:
-    maxItems: 2
+    minItems: 1
+    maxItems: 4
+    items:
+      - const: pwm
+      - const: pclk
+      - const: osc
+      - const: rc
 
   "#pwm-cells":
     enum: [2, 3]
@@ -66,25 +74,50 @@ allOf:
           contains:
             enum:
               - rockchip,rk3328-pwm
+              - rockchip,rk3506-pwm
+              - rockchip,rk3576-pwm
               - rockchip,rv1108-pwm
 
     then:
       properties:
         clocks:
-          items:
-            - description: Used to derive the functional clock for the device.
-            - description: Used as the APB bus clock.
+          minItems: 2
 
         clock-names:
-          items:
-            - const: pwm
-            - const: pclk
+          minItems: 2
 
       required:
         - clocks
         - clock-names
 
-    else:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - rockchip,rk3328-pwm
+              - rockchip,rv1108-pwm
+
+    then:
+      properties:
+        clocks:
+          maxItems: 2
+
+        clock-names:
+          maxItems: 2
+
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - rockchip,rk3328-pwm
+                - rockchip,rk3506-pwm
+                - rockchip,rk3576-pwm
+                - rockchip,rv1108-pwm
+
+    then:
       properties:
         clocks:
           maxItems: 1
@@ -92,6 +125,9 @@ allOf:
             Used both to derive the functional clock
             for the device and as the bus clock.
 
+        clock-names:
+          maxItems: 1
+
       required:
         - clocks
 
-- 
2.47.3



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2] dt-bindings: pwm: rockchip: add RK3506 and RK3576 PWM
  2026-11-21  6:59 ` [PATCH 2/2] dt-bindings: pwm: rockchip: add RK3506 and RK3576 PWM ZhuXiangyu
@ 2026-11-21 13:35   ` Heiko Stübner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stübner @ 2026-11-21 13:35 UTC (permalink / raw)
  To: Uwe Kleine-König, ZhuXiangyu
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-pwm,
	linux-arm-kernel, linux-rockchip, linux-kernel, devicetree,
	ZhuXiangyu

Am Samstag, 21. November 2026, 07:59:36 Mitteleuropäische Normalzeit schrieb ZhuXiangyu:
> Document the PWM v4 controllers found on RK3506 and RK3576. They use
> the pwm/pclk clocks and may additionally provide the osc and rc
> clocks used by the extended features.
> 
> Signed-off-by: ZhuXiangyu <1194781887@qq.com>


please check mailing lists, before submitting duplicate work.
There is already a better (yet unfinished implementation pending,
that also incorporates the counter input).

Especially as this is a new IP block - including a different hardware
structure, this should most likely not live inside the previous binding.

All the process issues, Krzysztof pointed out in another thread still
apply too.


Heiko





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-21 13:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20261121065936.1125919-1-1194781887@qq.com>
2026-11-21  6:59 ` [PATCH 2/2] dt-bindings: pwm: rockchip: add RK3506 and RK3576 PWM ZhuXiangyu
2026-11-21 13:35   ` Heiko Stübner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox