From: Samuel Holland <samuel@sholland.org>
To: Jernej Skrabec <jernej.skrabec@gmail.com>,
mchehab@kernel.org, hverkuil-cisco@xs4all.nl
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
wens@csie.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: allwinner: h6: Add deinterlace node
Date: Fri, 4 Nov 2022 22:01:18 -0500 [thread overview]
Message-ID: <dfb0958a-2575-e5f4-a61c-a17297ac6c07@sholland.org> (raw)
In-Reply-To: <20221101123201.3021129-4-jernej.skrabec@gmail.com>
On 11/1/22 07:32, Jernej Skrabec wrote:
> H6 has deinterlace core. Add a node for it.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Reviewed-by: Samuel Holland <samuel@sholland.org>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> index 0aa6dfafc197..badc6afd6941 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> @@ -154,6 +154,18 @@ mixer0_out_tcon_top_mixer0: endpoint {
> };
> };
>
> + deinterlace@1420000 {
> + compatible = "allwinner,sun50i-h6-deinterlace";
> + reg = <0x01420000 0x2000>;
Not that it matters, as long as the range is big enough, but how did you
come up with this size? The only thing I find in the vendor devicetrees
is 0x20c, the offset of the last documented register.
Regards,
Samuel
> + clocks = <&ccu CLK_BUS_DEINTERLACE>,
> + <&ccu CLK_DEINTERLACE>,
> + <&ccu CLK_MBUS_DEINTERLACE>;
> + clock-names = "bus", "mod", "ram";
> + resets = <&ccu RST_BUS_DEINTERLACE>;
> + interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
> + iommus = <&iommu 2>;
> + };
> +
> video-codec-g2@1c00000 {
> compatible = "allwinner,sun50i-h6-vpu-g2";
> reg = <0x01c00000 0x1000>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-05 3:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 12:31 [PATCH 0/3] media: sunxi: Add H6 deinterlace driver Jernej Skrabec
2022-11-01 12:31 ` [PATCH 1/3] media: dt-bindings: media: Add Allwinner H6 Deinterlace binding Jernej Skrabec
2022-11-02 17:14 ` Rob Herring
2022-11-05 3:02 ` Samuel Holland
2022-11-01 12:32 ` [PATCH 2/3] media: sunxi: Add H6 deinterlace driver Jernej Skrabec
2022-11-05 3:28 ` Samuel Holland
2022-11-01 12:32 ` [PATCH 3/3] arm64: dts: allwinner: h6: Add deinterlace node Jernej Skrabec
2022-11-05 3:01 ` Samuel Holland [this message]
2022-11-04 11:33 ` [PATCH 0/3] media: sunxi: Add H6 deinterlace driver Hans Verkuil
2022-11-04 17:36 ` Jernej Škrabec
2022-11-04 22:47 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfb0958a-2575-e5f4-a61c-a17297ac6c07@sholland.org \
--to=samuel@sholland.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox