Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Muhammad Usama Anjum <usama.anjum@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: usama.anjum@arm.com, Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Shuah Khan <shuah@kernel.org>,
	Andrey Konovalov <andreyknvl@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Amit Daniel Kachhap <amit.kachhap@arm.com>,
	Yeoreum Yun <yeoreum.yun@arm.com>,
	open list <linux-kernel@vger.kernel.org>,
	"moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)"
	<linux-arm-kernel@lists.infradead.org>,
	"open list:KERNEL SELFTEST FRAMEWORK"
	<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v2 3/5] selftests/arm64: Treat KSM merge_across_nodes as optional
Date: Fri, 21 Aug 2026 16:56:12 +0100	[thread overview]
Message-ID: <e076f415-f785-48de-81fb-8f475253ac31@arm.com> (raw)
In-Reply-To: <918c46fc-f6ca-43a7-9629-0d8abb1c1e54@sirena.org.uk>

On 21/08/2026 4:43 pm, Mark Brown wrote:
> On Fri, Aug 21, 2026 at 03:15:51PM +0100, Muhammad Usama Anjum wrote:
> 
>> +static bool merge_across_nodes_available(void)
>> +{
>> +	const char *path = PATH_KSM "merge_across_nodes";
>> +
>> +	if (!access(path, R_OK | W_OK))
>> +		return true;
>> +	if (errno == ENOENT)
>> +		return false;
>> +
>> +	ksft_exit_fail_msg("Unable to read and write %s: %s\n", path,
>> +			   strerror(errno));
>> +}
> 
> If prerequistites for the test aren't available I'd expect this to be a
> skip rather than a fail.

You're right. Access to the attribute is a prerequisite rather than the
behavior under test, so I'll report access failures as KSFT_SKIP.

-- 
Thanks,
Usama

-- 
Thanks,
Usama


  reply	other threads:[~2026-08-21 15:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 14:15 [PATCH v2 0/5] selftest/arm64: Fix MTE test setup and TAP reporting Muhammad Usama Anjum
2026-08-21 14:15 ` [PATCH v2 1/5] selftests/arm64: Print TAP header Muhammad Usama Anjum
2026-08-21 14:15 ` [PATCH v2 2/5] selftests/arm64: Print missing MTE TAP headers Muhammad Usama Anjum
2026-08-21 16:04   ` Mark Brown
2026-08-21 16:11     ` Muhammad Usama Anjum
2026-08-21 16:21       ` Mark Brown
2026-08-25 10:21         ` Muhammad Usama Anjum
2026-08-21 14:15 ` [PATCH v2 3/5] selftests/arm64: Treat KSM merge_across_nodes as optional Muhammad Usama Anjum
2026-08-21 15:43   ` Mark Brown
2026-08-21 15:56     ` Muhammad Usama Anjum [this message]
2026-08-21 14:15 ` [PATCH v2 4/5] selftests/arm64: Fix MTE prctl TAP plan Muhammad Usama Anjum
2026-08-21 14:15 ` [PATCH v2 5/5] selftests/arm64: Add MTE test config fragment Muhammad Usama Anjum
2026-08-21 16:07   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e076f415-f785-48de-81fb-8f475253ac31@arm.com \
    --to=usama.anjum@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=amit.kachhap@arm.com \
    --cc=andreyknvl@gmail.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=shuah@kernel.org \
    --cc=vincenzo.frascino@arm.com \
    --cc=will@kernel.org \
    --cc=yeoreum.yun@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox