* [PATCH -next] PCI: mediatek-gen3: Remove unneeded semicolon
@ 2024-11-11 1:09 Yang Li
2024-11-13 8:49 ` AngeloGioacchino Del Regno
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yang Li @ 2024-11-11 1:09 UTC (permalink / raw)
To: matthias.bgg, angelogioacchino.delregno, kw
Cc: linux-pci, linux-mediatek, linux-kernel, linux-arm-kernel,
Yang Li, Abaci Robot
This patch removes an redundant semicolon.
./drivers/pci/controller/pcie-mediatek-gen3.c:414:2-3: Unneeded
semicolon
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11789
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/pci/controller/pcie-mediatek-gen3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
index f333afb92a21..be52e3a123ab 100644
--- a/drivers/pci/controller/pcie-mediatek-gen3.c
+++ b/drivers/pci/controller/pcie-mediatek-gen3.c
@@ -411,7 +411,7 @@ static int mtk_pcie_startup_port(struct mtk_gen3_pcie *pcie)
if (pcie->num_lanes > 1)
val |= FIELD_PREP(PCIE_SETTING_LINK_WIDTH,
GENMASK(fls(pcie->num_lanes >> 2), 0));
- };
+ }
writel_relaxed(val, pcie->base + PCIE_SETTING_REG);
/* Set Link Control 2 (LNKCTL2) speed restriction, if any */
--
2.32.0.3.g01195cf9f
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] PCI: mediatek-gen3: Remove unneeded semicolon
2024-11-11 1:09 [PATCH -next] PCI: mediatek-gen3: Remove unneeded semicolon Yang Li
@ 2024-11-13 8:49 ` AngeloGioacchino Del Regno
2024-11-13 9:27 ` Matthias Brugger
2024-11-13 20:43 ` Krzysztof Wilczyński
2 siblings, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-11-13 8:49 UTC (permalink / raw)
To: Yang Li, matthias.bgg, kw
Cc: linux-pci, linux-mediatek, linux-kernel, linux-arm-kernel,
Abaci Robot
Il 11/11/24 02:09, Yang Li ha scritto:
> This patch removes an redundant semicolon.
>
> ./drivers/pci/controller/pcie-mediatek-gen3.c:414:2-3: Unneeded
> semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11789
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/pci/controller/pcie-mediatek-gen3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
> index f333afb92a21..be52e3a123ab 100644
> --- a/drivers/pci/controller/pcie-mediatek-gen3.c
> +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
> @@ -411,7 +411,7 @@ static int mtk_pcie_startup_port(struct mtk_gen3_pcie *pcie)
> if (pcie->num_lanes > 1)
> val |= FIELD_PREP(PCIE_SETTING_LINK_WIDTH,
> GENMASK(fls(pcie->num_lanes >> 2), 0));
> - };
> + }
> writel_relaxed(val, pcie->base + PCIE_SETTING_REG);
>
> /* Set Link Control 2 (LNKCTL2) speed restriction, if any */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] PCI: mediatek-gen3: Remove unneeded semicolon
2024-11-11 1:09 [PATCH -next] PCI: mediatek-gen3: Remove unneeded semicolon Yang Li
2024-11-13 8:49 ` AngeloGioacchino Del Regno
@ 2024-11-13 9:27 ` Matthias Brugger
2024-11-13 20:43 ` Krzysztof Wilczyński
2 siblings, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2024-11-13 9:27 UTC (permalink / raw)
To: Yang Li, angelogioacchino.delregno, kw
Cc: linux-pci, linux-mediatek, linux-kernel, linux-arm-kernel,
Abaci Robot
On 11/11/2024 02:09, Yang Li wrote:
> This patch removes an redundant semicolon.
>
> ./drivers/pci/controller/pcie-mediatek-gen3.c:414:2-3: Unneeded
> semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11789
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/pci/controller/pcie-mediatek-gen3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
> index f333afb92a21..be52e3a123ab 100644
> --- a/drivers/pci/controller/pcie-mediatek-gen3.c
> +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
> @@ -411,7 +411,7 @@ static int mtk_pcie_startup_port(struct mtk_gen3_pcie *pcie)
> if (pcie->num_lanes > 1)
> val |= FIELD_PREP(PCIE_SETTING_LINK_WIDTH,
> GENMASK(fls(pcie->num_lanes >> 2), 0));
> - };
> + }
> writel_relaxed(val, pcie->base + PCIE_SETTING_REG);
>
> /* Set Link Control 2 (LNKCTL2) speed restriction, if any */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] PCI: mediatek-gen3: Remove unneeded semicolon
2024-11-11 1:09 [PATCH -next] PCI: mediatek-gen3: Remove unneeded semicolon Yang Li
2024-11-13 8:49 ` AngeloGioacchino Del Regno
2024-11-13 9:27 ` Matthias Brugger
@ 2024-11-13 20:43 ` Krzysztof Wilczyński
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Wilczyński @ 2024-11-13 20:43 UTC (permalink / raw)
To: Yang Li
Cc: matthias.bgg, angelogioacchino.delregno, linux-pci,
linux-mediatek, linux-kernel, linux-arm-kernel, Abaci Robot
Hello,
> This patch removes an redundant semicolon.
>
> ./drivers/pci/controller/pcie-mediatek-gen3.c:414:2-3: Unneeded
> semicolon
Applied to controller/mediatek, thank you!
[01/01] PCI: mediatek-gen3: Remove unneeded semicolon
https://git.kernel.org/pci/pci/c/d19ea320d302
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-13 20:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-11 1:09 [PATCH -next] PCI: mediatek-gen3: Remove unneeded semicolon Yang Li
2024-11-13 8:49 ` AngeloGioacchino Del Regno
2024-11-13 9:27 ` Matthias Brugger
2024-11-13 20:43 ` Krzysztof Wilczyński
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox