From: Umang Jain <umang.jain@ideasonboard.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>
Cc: linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
kernel-list@raspberrypi.com, Stefan Wahren <wahrenst@gmx.net>
Subject: Re: [PATCH 0/2] staging: vchiq_arm: Fix drv_mgmt leak
Date: Sun, 13 Oct 2024 14:17:49 +0530 [thread overview]
Message-ID: <e65783aa-11a6-4476-977c-898f4ae8744b@ideasonboard.com> (raw)
In-Reply-To: <20241013084529.377488-1-umang.jain@ideasonboard.com>
Hi,
[Treat this series as RFC]
On 13/10/24 2:15 pm, Umang Jain wrote:
> 1/2 is a drive by fix.
> 2/2 uses devres resouce management helper devm_kzalloc() to auto-free
> struct vchiq_drv_mgmt on error and .remove() paths.
>
> It might be good to aware the devres issue and following talk might
> give reviewers a helpful context:
>
> - https://lpc.events/event/16/contributions/1227/
> - https://archive.fosdem.org/2023/schedule/event/devm_kzalloc/
>
> I am not totally sure if these problems, causes a blockers for these
> patches. There are a couple of memory management issues I've spotted
> which can be fixed? by devres (similar to this series) but probably I
> will wait for initial feedback on this series.
Was supposed to mark this as RFC for discussion and yes, I have realised
I've not written a commit message for 2/2.
>
> Umang Jain (2):
> staging: vchiq_arm: Drop blank lines
> staging: vchiq_arm: Use devm_kzalloc for mgmt
>
> .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
prev parent reply other threads:[~2024-10-13 8:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-13 8:45 [PATCH 0/2] staging: vchiq_arm: Fix drv_mgmt leak Umang Jain
2024-10-13 8:45 ` [PATCH 1/2] staging: vchiq_arm: Drop blank lines Umang Jain
2024-10-13 9:08 ` Stefan Wahren
2024-10-13 8:45 ` [PATCH 2/2] staging: vchiq_arm: Use devm_kzalloc for mgmt Umang Jain
2024-10-13 9:13 ` Stefan Wahren
2024-10-13 10:36 ` Umang Jain
2024-10-13 10:46 ` Stefan Wahren
2024-10-13 8:47 ` Umang Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e65783aa-11a6-4476-977c-898f4ae8744b@ideasonboard.com \
--to=umang.jain@ideasonboard.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-list@raspberrypi.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox