Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Nishanth Menon <nm@ti.com>, Rob Herring <robh+dt@kernel.org>
Cc: Tero Kristo <t-kristo@ti.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH 1/2] arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes
Date: Mon, 14 Sep 2020 16:53:42 +0530	[thread overview]
Message-ID: <e914e527-00fc-2614-fa74-f2137dbcfaf9@ti.com> (raw)
In-Reply-To: <4b17cace-09d5-af8c-6e7f-9358cfdceb4d@ti.com>

Hi Rob,

On 02/09/20 1:07 pm, Kishon Vijay Abraham I wrote:
> Hi Rob,
> 
> On 02/09/20 10:24 am, Kishon Vijay Abraham I wrote:
>> Hi Nishanth,
>>
>> On 01/09/20 8:22 pm, Nishanth Menon wrote:
>>> On 19:36-20200901, Kishon Vijay Abraham I wrote:
>>>> Add PCIe device tree node (both RC and EP) for the four
>>>> PCIe instances here.
>>>>
>>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>>>> ---
>>>>   arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 218
>>>> ++++++++++++++++++++++
>>>>   arch/arm64/boot/dts/ti/k3-j721e.dtsi      |   5 +-
>>>>   2 files changed, 222 insertions(+), 1 deletion(-)
>>>
>>>
>>> Did you look at the diff of the dtbs_check before and after this
>>> series? I see: https://pastebin.ubuntu.com/p/9fyfrTjx9M/
>>
>> I didn't see any errors when I checked for individual bindings
>> a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check
>> DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml"
>>
>>    SCHEMA  Documentation/devicetree/bindings/processed-schema.yaml
>>    DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml
>>    DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml
>>    CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml
>>    CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml
>> a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check
>> DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml"
>>
>>    SCHEMA  Documentation/devicetree/bindings/processed-schema.yamlsimple-bus
>>    DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml
>>    DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml
>>    CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml
>>    CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml
> 
> Can you give hint on why I get ranges is too long error
> https://pastebin.ubuntu.com/p/cPm2tg3dcV/ which I give mkconfig64
> dtbs_check but don't see an error when I include "DT_SCHEMA_FILES"?

I debugged this and looks like PCIe "ranges" property conflicts with
simple-bus.

A diff like below helps to solve the issue
diff --git a/schemas/simple-bus.yaml b/schemas/simple-bus.yaml
index 248ac9d..ed818ef 100644
--- a/schemas/simple-bus.yaml
+++ b/schemas/simple-bus.yaml
@@ -39,7 +39,7 @@ patternProperties:
         oneOf:
           - items:
               minItems: 3
-              maxItems: 6
+              maxItems: 7
             minItems: 0
             maxItems: 1024
           - $ref: "types.yaml#/definitions/flag"

If this looks right to you, I can post a patch for it. Without fixing
this we would see false errors for PCIe DT nodes.

Thanks
Kishon

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-14 11:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01 14:06 [RESEND PATCH 0/2] Add DT to get PCIe working in J721E SoC Kishon Vijay Abraham I
2020-09-01 14:06 ` [RESEND PATCH 1/2] arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes Kishon Vijay Abraham I
2020-09-01 14:52   ` Nishanth Menon
2020-09-02  4:54     ` Kishon Vijay Abraham I
2020-09-02  7:37       ` Kishon Vijay Abraham I
2020-09-14 11:23         ` Kishon Vijay Abraham I [this message]
2020-09-14 11:52           ` Nishanth Menon
2020-09-14 12:13             ` Kishon Vijay Abraham I
2020-09-14 13:14               ` Nishanth Menon
2020-09-14 14:58                 ` Kishon Vijay Abraham I
2020-09-01 14:06 ` [RESEND PATCH 2/2] arm64: dts: ti: k3-j721e-common-proc-board: Configure the PCIe instances Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e914e527-00fc-2614-fa74-f2137dbcfaf9@ti.com \
    --to=kishon@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox