From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<krzysztof.kozlowski+dt@linaro.org>
Cc: <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>,
<robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <srk@ti.com>,
<s-vadapalli@ti.com>
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j721e: Add overlay to enable CPSW9G ports in QSGMII mode
Date: Fri, 10 Mar 2023 15:49:13 +0530 [thread overview]
Message-ID: <eb097dd5-8689-0598-780e-5f9a00128d8f@ti.com> (raw)
In-Reply-To: <af686c3d-8a24-3066-ea6d-59d435c470b6@linaro.org>
Hello Krzysztof,
On 10/03/23 14:59, Krzysztof Kozlowski wrote:
> On 10/03/2023 10:28, Siddharth Vadapalli wrote:
>> The J7 Quad Port Add-On Ethernet Card for J721E Common-Proc-Board supports
>> QSGMII mode. Use the overlay to configure CPSW9G ports in QSGMII mode.
>>
>> Add support to reset the PHY from kernel by using gpio-hog and gpio-reset.
>>
>> Add aliases for CPSW9G ports to enable kernel to fetch MAC addresses
>> directly from U-Boot.
>>
>
>
>> +&exp2 {
>> + qsgmii-line-hog {
>> + gpio-hog;
>> + gpios = <16 GPIO_ACTIVE_HIGH>;
>> + output-low;
>> + line-name = "qsgmii-pwrdn-line";
>> + };
>> +};
>> +
>> +&main_pmx0 {
>> + mdio_pins_default: mdio_pins_default {
>
> No underscores in node names. Didn't you already get such comments?
Sorry, I overlooked this. I am aware that underscores shouldn't be used. I will
post the v2 series fixing this.
Regards,
Siddharth.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-03-10 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 9:28 [PATCH 0/2] Add device-tree support for CPSW9G on J721E SoC Siddharth Vadapalli
2023-03-10 9:28 ` [PATCH 1/2] arm64: dts: ti: k3-j721e: Add CPSW9G nodes Siddharth Vadapalli
2023-03-10 9:28 ` [PATCH 2/2] arm64: dts: ti: k3-j721e: Add overlay to enable CPSW9G ports in QSGMII mode Siddharth Vadapalli
2023-03-10 9:29 ` Krzysztof Kozlowski
2023-03-10 10:19 ` Siddharth Vadapalli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb097dd5-8689-0598-780e-5f9a00128d8f@ti.com \
--to=s-vadapalli@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox