Re: [PATCH 02/10] dt-bindings: pinctrl: Add devicetree bindings for DM816x SoC Pinctrl

[Krzysztof Kozlowski <krzk@kernel.org>]

On 16/10/2026 16:41, Ettore Chimenti wrote:
> Add devicetree bindings for TI DM816x SoC pinctrl configuration.
> Using same definition as OMAP2/3 except pullup/down enable macros, which
> are inverted in this SoC.
> 
> Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>
> ---
>  include/dt-bindings/pinctrl/dm816x.h | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/include/dt-bindings/pinctrl/dm816x.h b/include/dt-bindings/pinctrl/dm816x.h
> new file mode 100644
> index 000000000000..15aa15bca9bd
> --- /dev/null
> +++ b/include/dt-bindings/pinctrl/dm816x.h
> @@ -0,0 +1,20 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * This header provides constants specific to DM816X pinctrl bindings.
> + */
> +
> +#ifndef _DT_BINDINGS_PINCTRL_DM816X_H
> +#define _DT_BINDINGS_PINCTRL_DM816X_H
> +
> +#include <dt-bindings/pinctrl/omap.h>

I do not see this being used here, IWYU.

> +
> +#undef PULL_UP
> +#undef PULL_ENA

Why are you undefining other macros? That's not a easy to follow code.


> +
> +/* DM81xx mux bit defines */
> +#define PULL_ENA		(0 << 3)  /* Pullup enabled  => 0 */
> +#define PULL_DIS		(1 << 3)  /* Pullup disabled => 1 */
> +#define PULL_DN			(0 << 4)
> +#define PULL_UP			(1 << 4)

I do not see this used by drivers, so why do we need one more header?
What part of SW are you binding here?


Best regards,
Krzysztof