From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, "Dom Cobley" <popcornmix@gmail.com>,
"Phil Elwell" <phil@raspberrypi.com>,
"Jim Quinlan" <jim2101024@gmail.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Hans Zhang" <18255117159@163.com>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI: brcmstb: Assign pcie->gen from pcie_get_link_speed()
Date: Fri, 1 May 2026 15:05:02 -0700 [thread overview]
Message-ID: <ef1c9256-7fed-4476-bf84-9dc46bca2232@broadcom.com> (raw)
In-Reply-To: <20260501220359.GA522578@bhelgaas>
On 5/1/26 15:03, Bjorn Helgaas wrote:
> On Fri, May 01, 2026 at 01:24:38PM -0700, Florian Fainelli wrote:
>> After commit 03f920936977 ("PCI: controller: Validate max-link-speed"),
>> pcie->gen stopped being assigned and as a result the established PCIe
>> link would stop supporting Gen3 speeds on 2712 since pcie->gen is used
>> to populate LnkCntl2 and LnkCap in brcm_pcie_set_gen().
>>
>> Link: https://github.com/raspberrypi/linux/issues/7343
>> Reported-by: Dom Cobley <popcornmix@gmail.com>
>> Reported-by: Phil Elwell <phil@raspberrypi.com>
>> Fixes: 03f920936977 ("PCI: controller: Validate max-link-speed")
>> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
>
> Applied to pci/for-linus for v7.1, thanks, and sorry for the breakage.
I reviewed the original change and completely missed that, so no
worries, the fault is mine to have missed it in the first place. Thanks
for fast tracking this!
--
Florian
next prev parent reply other threads:[~2026-05-01 22:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 20:24 [PATCH] PCI: brcmstb: Assign pcie->gen from pcie_get_link_speed() Florian Fainelli
2026-05-01 22:03 ` Bjorn Helgaas
2026-05-01 22:05 ` Florian Fainelli [this message]
2026-05-02 11:40 ` Bjorn Helgaas
2026-05-04 16:58 ` Florian Fainelli
2026-05-04 17:26 ` Hans Zhang
2026-05-04 23:46 ` Florian Fainelli
2026-05-05 12:54 ` Hans Zhang
2026-05-05 16:01 ` Bjorn Helgaas
2026-05-05 17:58 ` Florian Fainelli
2026-05-05 21:31 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef1c9256-7fed-4476-bf84-9dc46bca2232@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=18255117159@163.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jim2101024@gmail.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=phil@raspberrypi.com \
--cc=popcornmix@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox