From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Andrey Konovalov <andreyknvl@google.com>,
Alexander Potapenko <glider@google.com>
Cc: Branislav Rankov <Branislav.Rankov@arm.com>,
Marco Elver <elver@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Evgenii Stepanov <eugenis@google.com>,
LKML <linux-kernel@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Andrew Morton <akpm@linux-foundation.org>,
Will Deacon <will@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v9 3/4] kasan: Add report for async mode
Date: Fri, 29 Jan 2021 18:16:31 +0000 [thread overview]
Message-ID: <f1ad988d-6385-45e0-d683-048bfca0b9c0@arm.com> (raw)
In-Reply-To: <CAAeHK+x5O595yU9q03G8xPvwpU_3Y6bQhW=+09GziOuTPZNVHw@mail.gmail.com>
On 1/29/21 6:09 PM, Andrey Konovalov wrote:
> On Fri, Jan 29, 2021 at 6:56 PM Vincenzo Frascino
> <vincenzo.frascino@arm.com> wrote:
>>
>> Hi Andrey,
>>
>> On 1/29/21 5:40 PM, Andrey Konovalov wrote:
>>> I suggest to call end_report(&flags, 0) here and check addr !=0 in
>>> end_report() before calling trace_error_report_end().
>>>
>>
>> Probably this is better as:
>>
>> if (!IS_ENABLED(CONFIG_KASAN_HW_TAGS))
>>
>> Because that condition passes always addr == 0.
>
> Not sure I understand. Call report_end(&flags, 0) and then there do:
>
> if (addr) trace_error_report_end(...);
>
> Although maybe it makes sense to still trace all async bugs to address
> 0. Or to some magic address.
>
> Alex, WDYT?
>
What I meant is instead of:
if (addr) trace_error_report_end(...);
you might want to do:
if (!IS_ENABLED(CONFIG_KASAN_HW_TAGS)) trace_error_report_end(...);
because, could make sense to trace 0 in other cases?
I could not find the implementation of trace_error_report_end() hence I am not
really sure on what it does.
--
Regards,
Vincenzo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-29 18:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 13:45 [PATCH v9 0/4] arm64: ARMv8.5-A: MTE: Add async mode support Vincenzo Frascino
2021-01-26 13:46 ` [PATCH v9 1/4] arm64: mte: Add asynchronous " Vincenzo Frascino
2021-01-26 13:46 ` [PATCH v9 2/4] kasan: Add KASAN mode kernel parameter Vincenzo Frascino
2021-01-26 13:46 ` [PATCH v9 3/4] kasan: Add report for async mode Vincenzo Frascino
2021-01-29 17:40 ` Andrey Konovalov
2021-01-29 17:48 ` Vincenzo Frascino
2021-01-29 17:56 ` Andrey Konovalov
2021-01-29 18:01 ` Vincenzo Frascino
2021-01-29 18:10 ` Andrey Konovalov
2021-01-29 18:18 ` Vincenzo Frascino
2021-01-29 18:00 ` Vincenzo Frascino
2021-01-29 18:09 ` Andrey Konovalov
2021-01-29 18:16 ` Vincenzo Frascino [this message]
2021-01-29 18:46 ` Vincenzo Frascino
2021-01-29 18:44 ` Andrey Konovalov
2021-01-26 13:46 ` [PATCH v9 4/4] arm64: mte: Enable async tag check fault Vincenzo Frascino
2021-01-27 20:00 ` [PATCH v9 0/4] arm64: ARMv8.5-A: MTE: Add async mode support Andrey Konovalov
2021-01-27 22:19 ` Will Deacon
2021-01-29 17:54 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1ad988d-6385-45e0-d683-048bfca0b9c0@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=Branislav.Rankov@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox