* [PATCH] arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process
@ 2024-04-23 9:35 Wei Li
2024-04-30 15:06 ` Will Deacon
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Wei Li @ 2024-04-23 9:35 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon, Joel Granados, Luis Chamberlain
Cc: Wei Li, xiexiuqi, linux-arm-kernel
The function run_all_insn_set_hw_mode() is registered as startup callback
of 'CPUHP_AP_ARM64_ISNDEP_STARTING', it invokes set_hw_mode() methods of
all emulated instructions.
As the STARTING callbacks are not expected to fail, if one of the
set_hw_mode() fails, e.g. due to el0 mixed-endian is not supported for
'setend', it will report a warning:
```
CPU[2] cannot support the emulation of setend
CPU 2 UP state arm64/isndep:starting (136) failed (-22)
CPU2: Booted secondary processor 0x0000000002 [0x414fd0c1]
```
To fix it, add a check for INSN_UNAVAILABLE status and skip the process.
Signed-off-by: Wei Li <liwei391@huawei.com>
---
arch/arm64/kernel/armv8_deprecated.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
index dd6ce86d4332..b776e7424fe9 100644
--- a/arch/arm64/kernel/armv8_deprecated.c
+++ b/arch/arm64/kernel/armv8_deprecated.c
@@ -462,6 +462,9 @@ static int run_all_insn_set_hw_mode(unsigned int cpu)
for (int i = 0; i < ARRAY_SIZE(insn_emulations); i++) {
struct insn_emulation *insn = insn_emulations[i];
bool enable = READ_ONCE(insn->current_mode) == INSN_HW;
+ if (insn->status == INSN_UNAVAILABLE)
+ continue;
+
if (insn->set_hw_mode && insn->set_hw_mode(enable)) {
pr_warn("CPU[%u] cannot support the emulation of %s",
cpu, insn->name);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process
2024-04-23 9:35 [PATCH] arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process Wei Li
@ 2024-04-30 15:06 ` Will Deacon
2024-05-21 3:10 ` liwei (GF)
2024-05-15 7:46 ` lihuisong (C)
2024-06-05 12:34 ` Will Deacon
2 siblings, 1 reply; 6+ messages in thread
From: Will Deacon @ 2024-04-30 15:06 UTC (permalink / raw)
To: Wei Li
Cc: Catalin Marinas, Joel Granados, Luis Chamberlain, xiexiuqi,
linux-arm-kernel
On Tue, Apr 23, 2024 at 05:35:01PM +0800, Wei Li wrote:
> The function run_all_insn_set_hw_mode() is registered as startup callback
> of 'CPUHP_AP_ARM64_ISNDEP_STARTING', it invokes set_hw_mode() methods of
> all emulated instructions.
>
> As the STARTING callbacks are not expected to fail, if one of the
> set_hw_mode() fails, e.g. due to el0 mixed-endian is not supported for
> 'setend', it will report a warning:
>
> ```
> CPU[2] cannot support the emulation of setend
> CPU 2 UP state arm64/isndep:starting (136) failed (-22)
> CPU2: Booted secondary processor 0x0000000002 [0x414fd0c1]
> ```
>
> To fix it, add a check for INSN_UNAVAILABLE status and skip the process.
>
> Signed-off-by: Wei Li <liwei391@huawei.com>
> ---
> arch/arm64/kernel/armv8_deprecated.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
> index dd6ce86d4332..b776e7424fe9 100644
> --- a/arch/arm64/kernel/armv8_deprecated.c
> +++ b/arch/arm64/kernel/armv8_deprecated.c
> @@ -462,6 +462,9 @@ static int run_all_insn_set_hw_mode(unsigned int cpu)
> for (int i = 0; i < ARRAY_SIZE(insn_emulations); i++) {
> struct insn_emulation *insn = insn_emulations[i];
> bool enable = READ_ONCE(insn->current_mode) == INSN_HW;
> + if (insn->status == INSN_UNAVAILABLE)
> + continue;
> +
> if (insn->set_hw_mode && insn->set_hw_mode(enable)) {
> pr_warn("CPU[%u] cannot support the emulation of %s",
> cpu, insn->name);
Isn't this part of the warning useful, though? ^^^
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process
2024-04-30 15:06 ` Will Deacon
@ 2024-05-21 3:10 ` liwei (GF)
2024-06-04 15:15 ` Will Deacon
0 siblings, 1 reply; 6+ messages in thread
From: liwei (GF) @ 2024-05-21 3:10 UTC (permalink / raw)
To: Will Deacon
Cc: Catalin Marinas, Joel Granados, Luis Chamberlain, xiexiuqi,
linux-arm-kernel
On 2024/4/30 23:06, Will Deacon wrote:
> On Tue, Apr 23, 2024 at 05:35:01PM +0800, Wei Li wrote:
>> The function run_all_insn_set_hw_mode() is registered as startup callback
>> of 'CPUHP_AP_ARM64_ISNDEP_STARTING', it invokes set_hw_mode() methods of
>> all emulated instructions.
>>
>> As the STARTING callbacks are not expected to fail, if one of the
>> set_hw_mode() fails, e.g. due to el0 mixed-endian is not supported for
>> 'setend', it will report a warning:
>>
>> ```
>> CPU[2] cannot support the emulation of setend
>> CPU 2 UP state arm64/isndep:starting (136) failed (-22)
>> CPU2: Booted secondary processor 0x0000000002 [0x414fd0c1]
>> ```
>>
>> To fix it, add a check for INSN_UNAVAILABLE status and skip the process.
>>
>> Signed-off-by: Wei Li <liwei391@huawei.com>
>> ---
>> arch/arm64/kernel/armv8_deprecated.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
>> index dd6ce86d4332..b776e7424fe9 100644
>> --- a/arch/arm64/kernel/armv8_deprecated.c
>> +++ b/arch/arm64/kernel/armv8_deprecated.c
>> @@ -462,6 +462,9 @@ static int run_all_insn_set_hw_mode(unsigned int cpu)
>> for (int i = 0; i < ARRAY_SIZE(insn_emulations); i++) {
>> struct insn_emulation *insn = insn_emulations[i];
>> bool enable = READ_ONCE(insn->current_mode) == INSN_HW;
>> + if (insn->status == INSN_UNAVAILABLE)
>> + continue;
>> +
>> if (insn->set_hw_mode && insn->set_hw_mode(enable)) {
>> pr_warn("CPU[%u] cannot support the emulation of %s",
>> cpu, insn->name);
>
> Isn't this part of the warning useful, though? ^^^
>
Sorry I missed your replay, I think the warning here is unexpected.
As far as setend is concerned, the 'INSN_UNAVAILABLE' state is marked in armv8_deprecated_init(),
with a prompt message, and skipped in following register process too. So the warning here should
be intended to indicate the situation where set_hw_mode() should succeed.
Thanks,
Wei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process
2024-05-21 3:10 ` liwei (GF)
@ 2024-06-04 15:15 ` Will Deacon
0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2024-06-04 15:15 UTC (permalink / raw)
To: liwei (GF)
Cc: Catalin Marinas, Joel Granados, Luis Chamberlain, xiexiuqi,
linux-arm-kernel
On Tue, May 21, 2024 at 11:10:43AM +0800, liwei (GF) wrote:
>
>
> On 2024/4/30 23:06, Will Deacon wrote:
> > On Tue, Apr 23, 2024 at 05:35:01PM +0800, Wei Li wrote:
> >> The function run_all_insn_set_hw_mode() is registered as startup callback
> >> of 'CPUHP_AP_ARM64_ISNDEP_STARTING', it invokes set_hw_mode() methods of
> >> all emulated instructions.
> >>
> >> As the STARTING callbacks are not expected to fail, if one of the
> >> set_hw_mode() fails, e.g. due to el0 mixed-endian is not supported for
> >> 'setend', it will report a warning:
> >>
> >> ```
> >> CPU[2] cannot support the emulation of setend
> >> CPU 2 UP state arm64/isndep:starting (136) failed (-22)
> >> CPU2: Booted secondary processor 0x0000000002 [0x414fd0c1]
> >> ```
> >>
> >> To fix it, add a check for INSN_UNAVAILABLE status and skip the process.
> >>
> >> Signed-off-by: Wei Li <liwei391@huawei.com>
> >> ---
> >> arch/arm64/kernel/armv8_deprecated.c | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
> >> index dd6ce86d4332..b776e7424fe9 100644
> >> --- a/arch/arm64/kernel/armv8_deprecated.c
> >> +++ b/arch/arm64/kernel/armv8_deprecated.c
> >> @@ -462,6 +462,9 @@ static int run_all_insn_set_hw_mode(unsigned int cpu)
> >> for (int i = 0; i < ARRAY_SIZE(insn_emulations); i++) {
> >> struct insn_emulation *insn = insn_emulations[i];
> >> bool enable = READ_ONCE(insn->current_mode) == INSN_HW;
> >> + if (insn->status == INSN_UNAVAILABLE)
> >> + continue;
> >> +
> >> if (insn->set_hw_mode && insn->set_hw_mode(enable)) {
> >> pr_warn("CPU[%u] cannot support the emulation of %s",
> >> cpu, insn->name);
> >
> > Isn't this part of the warning useful, though? ^^^
> >
>
> Sorry I missed your replay, I think the warning here is unexpected.
>
> As far as setend is concerned, the 'INSN_UNAVAILABLE' state is marked in
> armv8_deprecated_init(), with a prompt message, and skipped in following
> register process too. So the warning here should be intended to indicate
> the situation where set_hw_mode() should succeed.
Thanks, I agree with you.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process
2024-04-23 9:35 [PATCH] arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process Wei Li
2024-04-30 15:06 ` Will Deacon
@ 2024-05-15 7:46 ` lihuisong (C)
2024-06-05 12:34 ` Will Deacon
2 siblings, 0 replies; 6+ messages in thread
From: lihuisong (C) @ 2024-05-15 7:46 UTC (permalink / raw)
To: Wei Li, Catalin Marinas, Will Deacon, Joel Granados,
Luis Chamberlain
Cc: xiexiuqi, linux-arm-kernel
在 2024/4/23 17:35, Wei Li 写道:
> The function run_all_insn_set_hw_mode() is registered as startup callback
> of 'CPUHP_AP_ARM64_ISNDEP_STARTING', it invokes set_hw_mode() methods of
> all emulated instructions.
>
> As the STARTING callbacks are not expected to fail, if one of the
> set_hw_mode() fails, e.g. due to el0 mixed-endian is not supported for
> 'setend', it will report a warning:
>
> ```
> CPU[2] cannot support the emulation of setend
> CPU 2 UP state arm64/isndep:starting (136) failed (-22)
> CPU2: Booted secondary processor 0x0000000002 [0x414fd0c1]
> ```
>
> To fix it, add a check for INSN_UNAVAILABLE status and skip the process.
>
> Signed-off-by: Wei Li <liwei391@huawei.com>
> ---
> arch/arm64/kernel/armv8_deprecated.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
> index dd6ce86d4332..b776e7424fe9 100644
> --- a/arch/arm64/kernel/armv8_deprecated.c
> +++ b/arch/arm64/kernel/armv8_deprecated.c
> @@ -462,6 +462,9 @@ static int run_all_insn_set_hw_mode(unsigned int cpu)
> for (int i = 0; i < ARRAY_SIZE(insn_emulations); i++) {
> struct insn_emulation *insn = insn_emulations[i];
> bool enable = READ_ONCE(insn->current_mode) == INSN_HW;
> + if (insn->status == INSN_UNAVAILABLE)
> + continue;
> +
I happen to have this problem too. Thanks.
Tested-by: Huisong Li <lihuisong@huawei.com>
> if (insn->set_hw_mode && insn->set_hw_mode(enable)) {
> pr_warn("CPU[%u] cannot support the emulation of %s",
> cpu, insn->name);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process
2024-04-23 9:35 [PATCH] arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process Wei Li
2024-04-30 15:06 ` Will Deacon
2024-05-15 7:46 ` lihuisong (C)
@ 2024-06-05 12:34 ` Will Deacon
2 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2024-06-05 12:34 UTC (permalink / raw)
To: Catalin Marinas, Joel Granados, Luis Chamberlain, Wei Li
Cc: kernel-team, Will Deacon, xiexiuqi, linux-arm-kernel
On Tue, 23 Apr 2024 17:35:01 +0800, Wei Li wrote:
> The function run_all_insn_set_hw_mode() is registered as startup callback
> of 'CPUHP_AP_ARM64_ISNDEP_STARTING', it invokes set_hw_mode() methods of
> all emulated instructions.
>
> As the STARTING callbacks are not expected to fail, if one of the
> set_hw_mode() fails, e.g. due to el0 mixed-endian is not supported for
> 'setend', it will report a warning:
>
> [...]
Applied to arm64 (for-next/fixes), thanks!
[1/1] arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process
https://git.kernel.org/arm64/c/14951beaec93
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-06-05 12:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-23 9:35 [PATCH] arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process Wei Li
2024-04-30 15:06 ` Will Deacon
2024-05-21 3:10 ` liwei (GF)
2024-06-04 15:15 ` Will Deacon
2024-05-15 7:46 ` lihuisong (C)
2024-06-05 12:34 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox