[PATCH] arm64: check return value of of_flat_dt_get_machine_name

[PATCH] arm64: check return value of of_flat_dt_get_machine_name

[Kefeng Wang]

+ linux-arm-kernel

On 2017/5/16 15:54, Geert Uytterhoeven wrote:
> Hi Kefeng,
> 
> On Tue, May 16, 2017 at 9:36 AM, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>> It's useless to print machine name and setup arch-specific system
>> identifiers if of_flat_dt_get_machine_name() return NULL, especially
>> when ACPI-based boot.
> 
> Is there an ACPI-equivalent of the machine name?
> If yes, it would be useful to use that instead.

We will get system identification string(machine name) from SMBIOS, see drivers/firmware/dmi_scan.c
and arch/arm64/kernel/efi.c.
arm64_dmi_init
--dmi_scan_machine
  --dmi_present/dmi_smbios3_present
    --pr_info("DMI: %s\n", dmi_ids_string);
--dmi_set_dump_stack_arch_desc

Kefeng.
> 
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>>  arch/arm64/kernel/setup.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
>> index 2c822ef..d4b7405 100644
>> --- a/arch/arm64/kernel/setup.c
>> +++ b/arch/arm64/kernel/setup.c
>> @@ -194,6 +194,9 @@ static void __init setup_machine_fdt(phys_addr_t dt_phys)
>>         }
>>
>>         name = of_flat_dt_get_machine_name();
>> +       if (!name)
>> +               return;
>> +
>>         pr_info("Machine model: %s\n", name);
>>         dump_stack_set_arch_desc("%s (DT)", name);
>>  }
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 
> .
> 

[PATCH] arm64: check return value of of_flat_dt_get_machine_name

[Geert Uytterhoeven]

Hi Kefeng,

On Tue, May 16, 2017 at 10:11 AM, Kefeng Wang
<wangkefeng.wang@huawei.com> wrote:
> On 2017/5/16 15:54, Geert Uytterhoeven wrote:
>> On Tue, May 16, 2017 at 9:36 AM, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>>> It's useless to print machine name and setup arch-specific system
>>> identifiers if of_flat_dt_get_machine_name() return NULL, especially
>>> when ACPI-based boot.
>>
>> Is there an ACPI-equivalent of the machine name?
>> If yes, it would be useful to use that instead.
>
> We will get system identification string(machine name) from SMBIOS, see drivers/firmware/dmi_scan.c
> and arch/arm64/kernel/efi.c.
> arm64_dmi_init
> --dmi_scan_machine
>   --dmi_present/dmi_smbios3_present
>     --pr_info("DMI: %s\n", dmi_ids_string);
> --dmi_set_dump_stack_arch_desc

OK, and you have dump_stack_set_arch_desc() there.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds