* [PATCH] remoteproc: stm32_rproc: Propagate errors from optional IRQ lookup
@ 2026-08-10 5:19 phucduc.bui
2026-08-18 17:09 ` Mathieu Poirier
2026-08-26 13:09 ` [Linux-stm32] " Arnaud POULIQUEN
0 siblings, 2 replies; 4+ messages in thread
From: phucduc.bui @ 2026-08-10 5:19 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier, Maxime Coquelin,
Alexandre Torgue
Cc: linux-remoteproc, linux-stm32, linux-arm-kernel, linux-kernel,
bui duc phuc
From: bui duc phuc <phucduc.bui@gmail.com>
platform_get_irq_optional() returns a positive IRQ number on success or
a negative error code on failure. For an optional IRQ, -ENXIO indicates
that no IRQ is available, while other errors should be propagated.
Instead of only checking for -EPROBE_DEFER, propagate all error codes
returned by platform_get_irq_optional() other than -ENXIO, so that
failures are properly reported to the caller.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
drivers/remoteproc/stm32_rproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
index 632614013dc6..9301e1dab830 100644
--- a/drivers/remoteproc/stm32_rproc.c
+++ b/drivers/remoteproc/stm32_rproc.c
@@ -705,7 +705,7 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
int err, irq;
irq = platform_get_irq_optional(pdev, 0);
- if (irq == -EPROBE_DEFER)
+ if (irq < 0 && irq != -ENXIO)
return irq;
if (irq > 0) {
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] remoteproc: stm32_rproc: Propagate errors from optional IRQ lookup
2026-08-10 5:19 [PATCH] remoteproc: stm32_rproc: Propagate errors from optional IRQ lookup phucduc.bui
@ 2026-08-18 17:09 ` Mathieu Poirier
2026-08-19 1:49 ` Bui Duc Phuc
2026-08-26 13:09 ` [Linux-stm32] " Arnaud POULIQUEN
1 sibling, 1 reply; 4+ messages in thread
From: Mathieu Poirier @ 2026-08-18 17:09 UTC (permalink / raw)
To: phucduc.bui
Cc: Bjorn Andersson, Maxime Coquelin, Alexandre Torgue,
linux-remoteproc, linux-stm32, linux-arm-kernel, linux-kernel
On Sun, 9 Aug 2026 at 23:19, <phucduc.bui@gmail.com> wrote:
>
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> platform_get_irq_optional() returns a positive IRQ number on success or
> a negative error code on failure. For an optional IRQ, -ENXIO indicates
> that no IRQ is available, while other errors should be propagated.
>
> Instead of only checking for -EPROBE_DEFER, propagate all error codes
> returned by platform_get_irq_optional() other than -ENXIO, so that
> failures are properly reported to the caller.
>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
> drivers/remoteproc/stm32_rproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
I'll pick this up when rc1 comes out.
Thanks,
Mathieu
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index 632614013dc6..9301e1dab830 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -705,7 +705,7 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
> int err, irq;
>
> irq = platform_get_irq_optional(pdev, 0);
> - if (irq == -EPROBE_DEFER)
> + if (irq < 0 && irq != -ENXIO)
> return irq;
>
> if (irq > 0) {
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] remoteproc: stm32_rproc: Propagate errors from optional IRQ lookup
2026-08-18 17:09 ` Mathieu Poirier
@ 2026-08-19 1:49 ` Bui Duc Phuc
0 siblings, 0 replies; 4+ messages in thread
From: Bui Duc Phuc @ 2026-08-19 1:49 UTC (permalink / raw)
To: Mathieu Poirier
Cc: Bjorn Andersson, Maxime Coquelin, Alexandre Torgue,
linux-remoteproc, linux-stm32, linux-arm-kernel, linux-kernel
Hi Mathieu,
Thank you for your feedback.
>
> I'll pick this up when rc1 comes out.
>
Thanks, I’ll wait for rc1.
Best regards,
Phuc
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Linux-stm32] [PATCH] remoteproc: stm32_rproc: Propagate errors from optional IRQ lookup
2026-08-10 5:19 [PATCH] remoteproc: stm32_rproc: Propagate errors from optional IRQ lookup phucduc.bui
2026-08-18 17:09 ` Mathieu Poirier
@ 2026-08-26 13:09 ` Arnaud POULIQUEN
1 sibling, 0 replies; 4+ messages in thread
From: Arnaud POULIQUEN @ 2026-08-26 13:09 UTC (permalink / raw)
To: phucduc.bui, Bjorn Andersson, Mathieu Poirier, Maxime Coquelin,
Alexandre Torgue
Cc: linux-remoteproc, linux-stm32, linux-arm-kernel, linux-kernel
On 8/10/26 07:19, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> platform_get_irq_optional() returns a positive IRQ number on success or
> a negative error code on failure. For an optional IRQ, -ENXIO indicates
> that no IRQ is available, while other errors should be propagated.
>
> Instead of only checking for -EPROBE_DEFER, propagate all error codes
> returned by platform_get_irq_optional() other than -ENXIO, so that
> failures are properly reported to the caller.
>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Acked-by: Arnaud Pouliquen arnaud.pouliquen@foss.st.com
Thanks!
Arnaud
> ---
> drivers/remoteproc/stm32_rproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index 632614013dc6..9301e1dab830 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -705,7 +705,7 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
> int err, irq;
>
> irq = platform_get_irq_optional(pdev, 0);
> - if (irq == -EPROBE_DEFER)
> + if (irq < 0 && irq != -ENXIO)
> return irq;
>
> if (irq > 0) {
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-26 13:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-10 5:19 [PATCH] remoteproc: stm32_rproc: Propagate errors from optional IRQ lookup phucduc.bui
2026-08-18 17:09 ` Mathieu Poirier
2026-08-19 1:49 ` Bui Duc Phuc
2026-08-26 13:09 ` [Linux-stm32] " Arnaud POULIQUEN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox