* [PATCH 2.6.31] ixp4xx: timer and clocks cleanups
[not found] <200909102259.n8AMx7dB014927@pilspetsen.it.uu.se>
@ 2009-09-15 21:59 ` Krzysztof Halasa
2009-09-16 10:34 ` Mikael Pettersson
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Halasa @ 2009-09-15 21:59 UTC (permalink / raw)
To: linux-arm-kernel
Mikael Pettersson <mikpe@it.uu.se> writes:
> This patch does a few simple cleanups of the ixp4xx timer
> and clocksource/clockevent code in mach-ixp4xx/common.c:
>
> - ixp4xx_clocksource_init() is static and always returns 0,
> which is ignored by its only caller: make it return void
> - ixp4xx_clockevent_init(): ditto
> - ixp4xx_get_cycles() is only referenced locally: make it static
> - use the ixp4xx_timer_irq.dev_id field to pass &clockevent_ixp4xx
> to ixp4xx_timer_interrupt() via its dev_id parameter, allowing
> the code in ixp4xx_timer_interrupt() to be smaller and faster
Thanks.
--
Krzysztof Halasa
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 2.6.31] ixp4xx: timer and clocks cleanups
2009-09-15 21:59 ` [PATCH 2.6.31] ixp4xx: timer and clocks cleanups Krzysztof Halasa
@ 2009-09-16 10:34 ` Mikael Pettersson
2009-09-16 12:24 ` Krzysztof Halasa
0 siblings, 1 reply; 3+ messages in thread
From: Mikael Pettersson @ 2009-09-16 10:34 UTC (permalink / raw)
To: linux-arm-kernel
Krzysztof Halasa writes:
> Mikael Pettersson <mikpe@it.uu.se> writes:
>
> > This patch does a few simple cleanups of the ixp4xx timer
> > and clocksource/clockevent code in mach-ixp4xx/common.c:
> >
> > - ixp4xx_clocksource_init() is static and always returns 0,
> > which is ignored by its only caller: make it return void
> > - ixp4xx_clockevent_init(): ditto
> > - ixp4xx_get_cycles() is only referenced locally: make it static
> > - use the ixp4xx_timer_irq.dev_id field to pass &clockevent_ixp4xx
> > to ixp4xx_timer_interrupt() via its dev_id parameter, allowing
> > the code in ixp4xx_timer_interrupt() to be smaller and faster
>
> Thanks.
Great. Do you want to push these two patches via git or should
I add your Acked-by and submit them to the patch system?
/Mikael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-16 12:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200909102259.n8AMx7dB014927@pilspetsen.it.uu.se>
2009-09-15 21:59 ` [PATCH 2.6.31] ixp4xx: timer and clocks cleanups Krzysztof Halasa
2009-09-16 10:34 ` Mikael Pettersson
2009-09-16 12:24 ` Krzysztof Halasa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox