* [RFC 1/5] [media] rc: update sunxi-ir driver to get base frequency from devicetree
From: Philipp Rossak @ 2017-12-16 17:30 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171216071855.0ef43f7b@recife.lan>
Hey Mauro,
Thanks for your fast feedback!
I will rework the driver like you suggested it.
Does somebody have any concerns about the Devicetree property
(base-clk-frequency = < frequency >;)?
Regards,
Philipp
On 16.12.2017 10:18, Mauro Carvalho Chehab wrote:
> Em Sat, 16 Dec 2017 03:49:10 +0100
> Philipp Rossak <embed3d@gmail.com> escreveu:
>
> Hi Phillip,
>
> This is not a full review of this patchset. I just want to point you
> that you should keep supporting existing DT files.
>
>> This patch updates the sunxi-ir driver to set the ir base clock from
>> devicetree.
>>
>> This is neccessary since there are different ir recievers on the
>> market, that operate with different frequencys. So this value needs to
>> be set depending on the attached receiver.
>
> Please don't break backward compatibility with old DT files. In this
> specific case, it seems simple enough to be backward-compatible.
>
>>
>> Signed-off-by: Philipp Rossak <embed3d@gmail.com>
>> ---
>> drivers/media/rc/sunxi-cir.c | 20 +++++++++++---------
>> 1 file changed, 11 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c
>> index 97f367b446c4..55b53d6463e9 100644
>> --- a/drivers/media/rc/sunxi-cir.c
>> +++ b/drivers/media/rc/sunxi-cir.c
>> @@ -72,12 +72,6 @@
>> /* CIR_REG register idle threshold */
>> #define REG_CIR_ITHR(val) (((val) << 8) & (GENMASK(15, 8)))
>>
>> -/* Required frequency for IR0 or IR1 clock in CIR mode */
>> -#define SUNXI_IR_BASE_CLK 8000000
>> -/* Frequency after IR internal divider */
>> -#define SUNXI_IR_CLK (SUNXI_IR_BASE_CLK / 64)
>
> Keep those to definitions...
>
>> -/* Sample period in ns */
>> -#define SUNXI_IR_SAMPLE (1000000000ul / SUNXI_IR_CLK)
>> /* Noise threshold in samples */
>> #define SUNXI_IR_RXNOISE 1
>> /* Idle Threshold in samples */
>> @@ -122,7 +116,7 @@ static irqreturn_t sunxi_ir_irq(int irqno, void *dev_id)
>> /* for each bit in fifo */
>> dt = readb(ir->base + SUNXI_IR_RXFIFO_REG);
>> rawir.pulse = (dt & 0x80) != 0;
>> - rawir.duration = ((dt & 0x7f) + 1) * SUNXI_IR_SAMPLE;
>> + rawir.duration = ((dt & 0x7f) + 1) * ir->rc->rx_resolution;
>> ir_raw_event_store_with_filter(ir->rc, &rawir);
>> }
>> }
>> @@ -148,6 +142,7 @@ static int sunxi_ir_probe(struct platform_device *pdev)
>> struct device_node *dn = dev->of_node;
>> struct resource *res;
>> struct sunxi_ir *ir;
>> + u32 b_clk_freq;
>>
>> ir = devm_kzalloc(dev, sizeof(struct sunxi_ir), GFP_KERNEL);
>> if (!ir)
>> @@ -172,6 +167,12 @@ static int sunxi_ir_probe(struct platform_device *pdev)
>> return PTR_ERR(ir->clk);
>> }
>>
>> + /* Required frequency for IR0 or IR1 clock in CIR mode */
>> + if (of_property_read_u32(dn, "base-clk-frequency", &b_clk_freq)) {
>> + dev_err(dev, "failed to get ir base clock frequency.\n");
>> + return -ENODATA;
>> + }
>> +
>
> And here, instead of returning an error, if the property can't be read,
> it means it is an older DT file. Just default to SUNXI_IR_BASE_CLK.
> This will make it backward-compatible with old DT files that don't have
> such property.
>
> Regards,
> Mauro
>
>
>> /* Reset (optional) */
>> ir->rst = devm_reset_control_get_optional_exclusive(dev, NULL);
>> if (IS_ERR(ir->rst))
>> @@ -180,7 +181,7 @@ static int sunxi_ir_probe(struct platform_device *pdev)
>> if (ret)
>> return ret;
>>
>> - ret = clk_set_rate(ir->clk, SUNXI_IR_BASE_CLK);
>> + ret = clk_set_rate(ir->clk, b_clk_freq);
>> if (ret) {
>> dev_err(dev, "set ir base clock failed!\n");
>> goto exit_reset_assert;
>> @@ -225,7 +226,8 @@ static int sunxi_ir_probe(struct platform_device *pdev)
>> ir->rc->map_name = ir->map_name ?: RC_MAP_EMPTY;
>> ir->rc->dev.parent = dev;
>> ir->rc->allowed_protocols = RC_PROTO_BIT_ALL_IR_DECODER;
>> - ir->rc->rx_resolution = SUNXI_IR_SAMPLE;
>> + /* Frequency after IR internal divider with sample period in ns */
>> + ir->rc->rx_resolution = (1000000000ul / (b_clk_freq / 64));
>> ir->rc->timeout = MS_TO_NS(SUNXI_IR_TIMEOUT);
>> ir->rc->driver_name = SUNXI_IR_DEV;
>>
>
> Thanks,
> Mauro
>
^ permalink raw reply
* [RESEND PATCH v2 01/15] dt-bindings: soc: qcom: Add bindings for APR bus
From: Rob Herring @ 2017-12-16 17:27 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171214173402.19074-2-srinivas.kandagatla@linaro.org>
On Thu, Dec 14, 2017 at 05:33:48PM +0000, srinivas.kandagatla at linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
> This patch add dt bindings for Qualcomm APR bus driver
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> .../devicetree/bindings/soc/qcom/qcom,apr.txt | 28 ++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt
> new file mode 100644
> index 000000000000..4e93213ae98d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt
> @@ -0,0 +1,28 @@
> +Qualcomm APR (Asynchronous Packet Router) binding
> +
> +This binding describes the Qualcomm APR. APR is a IPC protocol for
> +communication between Application processor and QDSP. APR is mainly
> +used for audio/voice services on the QDSP.
> +
> +- compatible:
> + Usage: required
> + Value type: <stringlist>
> + Definition: must be "qcom,apr-<SOC-NAME>" example: "qcom,apr-msm8996"
<soc>-apr is the more standard order. With that,
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* [PATCH] of: build dbts with symbols when CONFIG_OF_OVERLAY is set
From: Andre Heider @ 2017-12-16 17:25 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <aada8c54-2c26-bf37-8782-4edc43195daf@gmail.com>
Hi Frank,
On 15/12/17 22:06, Frank Rowand wrote:
> On 12/14/17 07:12, Andre Heider wrote:
>> The overlay feature requires the base dtb to be built with symbols, so
>> lets build the dtbs with symbols when overlay support was explicitly
>> enabled.
>>
>> With CONFIG_OF_ALL_DTBS on ARCH=arm the 989 dtb files grow about ~38% on
>> average.
>>
>> Totals in bytes with the 3 biggest ones:
>>
>> Before:
>> 90471 arch/arm/boot/dts/am57xx-beagle-x15-revc.dtb
>> 90521 arch/arm/boot/dts/am57xx-beagle-x15-revb1.dtb
>> 92639 arch/arm/boot/dts/dra7-evm.dtb
>> 25731296 total
>>
>> After:
>> 133203 arch/arm/boot/dts/am57xx-beagle-x15-revc.dtb
>> 133237 arch/arm/boot/dts/am57xx-beagle-x15-revb1.dtb
>> 134545 arch/arm/boot/dts/dra7-evm.dtb
>> 35464440 total
>>
>> Signed-off-by: Andre Heider <a.heider@gmail.com>
>> ---
>>
>> Hi,
>>
>> while playing around with overlays I noticed that I needed to rebuilt
>> my distro's device trees because they didn't come with symbols.
>>
>> Is that for a reason, maybe the not so minor increase in size?
>
> Yes, size is the issue.
>
>
>>
>> Thanks,
>> Andre
>>
>> drivers/of/unittest-data/Makefile | 7 -------
>> scripts/Makefile.lib | 5 +++++
>> 2 files changed, 5 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/of/unittest-data/Makefile b/drivers/of/unittest-data/Makefile
>> index 32389acfa616..b65061013512 100644
>> --- a/drivers/of/unittest-data/Makefile
>> +++ b/drivers/of/unittest-data/Makefile
>> @@ -15,13 +15,6 @@ targets += overlay.dtb overlay.dtb.S
>> targets += overlay_bad_phandle.dtb overlay_bad_phandle.dtb.S
>> targets += overlay_bad_symbol.dtb overlay_bad_symbol.dtb.S
>> targets += overlay_base.dtb overlay_base.dtb.S
>> -
>> -# enable creation of __symbols__ node
>> -DTC_FLAGS_overlay := -@
>> -DTC_FLAGS_overlay_bad_phandle := -@
>> -DTC_FLAGS_overlay_bad_symbol := -@
>> -DTC_FLAGS_overlay_base := -@
>> -
>> endif
>>
>> .PRECIOUS: \
>
> No. The unittests require these to be set unconditionally.
>
>
>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>> index 1ca4dcd2d500..c7ba4aa8a07a 100644
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -278,6 +278,11 @@ DTC_FLAGS += -Wnode_name_chars_strict \
>> -Wproperty_name_chars_strict
>> endif
>>
>> +ifeq ($(CONFIG_OF_OVERLAY),y)
>> +# enable creation of __symbols__ node
>> +DTC_FLAGS += -@
>> +endif
>> +
>> DTC_FLAGS += $(DTC_FLAGS_$(basetarget))
>>
>> # Generate an assembly file to wrap the output of the device tree compiler
>>
>
> Not needed. Instead set DTC_FLAGS in the make command. For example:
>
> DTC_FLAGS=-@ make qcom-apq8074-dragonboard.dtb
>
> There are a few architecture Makefiles that need to be fixed to not unconditionally
> set DTC_FLAGS.
Rebuilding the dts files manually with symbols isn't the problem. The
idea was to enable it with a switch which distros simply can flip.
Passing DTC_FLAGS to `make` would work too I guess, but on multi
platform builds that's still the same issue if there're boards which
can't handle that because of the size increase.
Would a solution which enables symbols per family work?
E.g. CONFIG_MACH_SUN7I chooses to use -@ because it can handle it.
Thanks,
Andre
^ permalink raw reply
* [PATCH 0/3] arm64: dts: Support Mali450 on rk3328
From: Heiko Stuebner @ 2017-12-16 17:17 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171209000738.32187-1-heiko@sntech.de>
Am Samstag, 9. Dezember 2017, 01:07:35 CET schrieb Heiko Stuebner:
> Pretty standard setup. Tested with the kmscube demo running
> using the lima kernel and gallium driver.
>
>
> Heiko Stuebner (3):
> dt-bindings: gpu: mali-utgard: add rockchip,rk3328-mali compatible
> arm64: dts: rockchip: add rk3328 mali gpu node
> arm64: dts: rockchip: enable gpu on rk3328-rock64
applied for 4.16 with Robs review and following his suggestion
of making the gpu simply always-on and thus droppping patch 3.
^ permalink raw reply
* [PATCH v3 1/5] arm64: dts: rockchip: add extcon nodes and enable tcphy.
From: Heiko Stuebner @ 2017-12-16 17:08 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171215110005.7564-1-enric.balletbo@collabora.com>
Am Freitag, 15. Dezember 2017, 12:00:01 CET schrieb Enric Balletbo i Serra:
> Enable tcphy and create the cros-ec's extcon node for the USB Type-C port.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
applied for 4.16
Thanks
Heiko
^ permalink raw reply
* [PATCH v3 3/5] arm64: dts: rockchip: add usb3-phy otg-port support for rk3399.
From: Heiko Stuebner @ 2017-12-16 17:06 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171215110005.7564-3-enric.balletbo@collabora.com>
Am Freitag, 15. Dezember 2017, 12:00:03 CET schrieb Enric Balletbo i Serra:
> Add the usb3 phyter for the USB3.0 OTG controller.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
applied for 4.16
^ permalink raw reply
* [PATCH v3 5/5] arm64: dts: rockchip: add reset property for dwc3 controllers on rk3399.
From: Heiko Stuebner @ 2017-12-16 17:01 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171215110005.7564-5-enric.balletbo@collabora.com>
Am Freitag, 15. Dezember 2017, 12:00:05 CET schrieb Enric Balletbo i Serra:
> After commit '06c47e6286d usb: dwc3: of-simple: Add support to get resets
> for the device' you can add the reset property to the dwc3 node, the reset
> is required for the controller to work properly, otherwise bind / unbind
> stress testing of the USB controller on rk3399 we'd often end up with lots
> of failures that looked like this:
>
> phy phy-ff800000.phy.9: phy poweron failed --> -110
> dwc3 fe900000.dwc3: failed to initialize core
> dwc3: probe of fe900000.dwc3 failed with error -110
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
applied for 4.16
Thanks
Heiko
^ permalink raw reply
* [PATCH v3 2/5] arm64: dts: rockchip: add the aclk_usb3 clocks for USB3.
From: Heiko Stuebner @ 2017-12-16 17:00 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171215110005.7564-2-enric.balletbo@collabora.com>
Am Freitag, 15. Dezember 2017, 12:00:02 CET schrieb Enric Balletbo i Serra:
> The aclk_usb3 must be enabled to support USB3 for rk3399.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
applied for 4.16
^ permalink raw reply
* [PATCH v3 4/5] arm64: dts: rockchip: add pd_usb3 power-domain node for rk3399.
From: Heiko Stuebner @ 2017-12-16 16:55 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171215110005.7564-4-enric.balletbo@collabora.com>
Am Freitag, 15. Dezember 2017, 12:00:04 CET schrieb Enric Balletbo i Serra:
> Add the usb3 power-domain, its qos area and assign it to the usb device
> node.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
applied for 4.16
Thanks
Heiko
^ permalink raw reply
* [PATCH 10/12] dt-bindings: sdhci-omap: Add K2G specific binding
From: Rob Herring @ 2017-12-16 16:49 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171214130941.26666-11-kishon@ti.com>
On Thu, Dec 14, 2017 at 06:39:39PM +0530, Kishon Vijay Abraham I wrote:
> Add binding for the TI's sdhci-omap controller present in K2G.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> Documentation/devicetree/bindings/mmc/sdhci-omap.txt | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* [PATCH v2 1/4] dt-bindings: usb: add DT binding for RK3328 dwc3 controller
From: Heiko Stuebner @ 2017-12-16 15:52 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171204094041.25439-1-heiko@sntech.de>
Hi Greg, Felipe,
Am Montag, 4. Dezember 2017, 10:40:38 CET schrieb Heiko Stuebner:
> From: William Wu <william.wu@rock-chips.com>
>
> Adds the device tree bindings description for RK3328 and
> compatible USB DWC3 controller.
>
> Signed-off-by: William Wu <william.wu@rock-chips.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
do you want to pick this patch with only the small dt-binding
change or Ack it for me to pick up together with the actual
devicetree changes in the other patches?
Thanks
Heiko
> ---
> changes in v2:
> - add Rob's Ack
>
> Ideally usb maintainers would pick up this patch to the binding
> document and I'll take the devicetree changes after that.
>
> But if so desired, I can also pick up the binding change myself
> but would need an Ack for that.
>
> Documentation/devicetree/bindings/usb/rockchip,dwc3.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
> index 50a31536e975..2c3f6a467fda 100644
> --- a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
> @@ -1,7 +1,9 @@
> Rockchip SuperSpeed DWC3 USB SoC controller
>
> Required properties:
> -- compatible: should contain "rockchip,rk3399-dwc3" for rk3399 SoC
> +- compatible: should be one of the following:
> + - "rockchip,rk3399-dwc3": for rk3399 SoC
> + - "rockchip,rk3328-dwc3", "rockchip,rk3399-dwc3": for rk3328 SoC
> - clocks: A list of phandle + clock-specifier pairs for the
> clocks listed in clock-names
> - clock-names: Should contain the following:
>
^ permalink raw reply
* [PATCH 9/9] ARM: dts: imx7: add Toradex Colibri iMX7D 1GB (eMMC) support
From: Philippe Ombredanne @ 2017-12-16 14:18 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <CAOMZO5Dv5dRbbHeqMtitXaHjJbMF4nGQWg0dpyHu0hh+2TaxGA@mail.gmail.com>
Dear Stefan,
On Sat, Dec 16, 2017 at 3:09 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Wed, Dec 6, 2017 at 1:30 PM, Stefan Agner <stefan@agner.ch> wrote:
>
>> diff --git a/arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dts b/arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dts
>> new file mode 100644
>> index 000000000000..5d5bb4c2843f
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dts
>> @@ -0,0 +1,55 @@
>> +/*
>> + * Copyright 2017 Toradex AG
>> + *
>> + * This file is dual-licensed: you can use it either under the terms
>> + * of the GPL or the X11 license, at your option. Note that this dual
>> + * licensing only applies to this file, and not this project as a
>> + * whole.
>> + *
>> + * a) This file is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License
>> + * version 2 as published by the Free Software Foundation.
>> + *
>> + * This file is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * Or, alternatively,
>> + *
>> + * b) Permission is hereby granted, free of charge, to any person
>> + * obtaining a copy of this software and associated documentation
>> + * files (the "Software"), to deal in the Software without
>> + * restriction, including without limitation the rights to use,
>> + * copy, modify, merge, publish, distribute, sublicense, and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> + * Software is furnished to do so, subject to the following
>> + * conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> + * included in all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
>> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>> + * OTHER DEALINGS IN THE SOFTWARE.
>> + */
>
> Patch looks good.
>
> Just a comment: people have been starting to use SPDX license identifiers.
>
> This would really make all this huge license text much shorter :-)
Oh yes, please! Every time there are more than three lines of legalese
in a kernel source code file, a kitten dies somewhere. That's sad. We
all love kitten, right? See also Thomas doc patches for details [1]
though he forgot to mention this cat fact.
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
^ permalink raw reply
* [PATCH 9/9] ARM: dts: imx7: add Toradex Colibri iMX7D 1GB (eMMC) support
From: Fabio Estevam @ 2017-12-16 14:09 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171206153005.6144-9-stefan@agner.ch>
On Wed, Dec 6, 2017 at 1:30 PM, Stefan Agner <stefan@agner.ch> wrote:
> diff --git a/arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dts b/arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dts
> new file mode 100644
> index 000000000000..5d5bb4c2843f
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dts
> @@ -0,0 +1,55 @@
> +/*
> + * Copyright 2017 Toradex AG
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + * a) This file is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * version 2 as published by the Free Software Foundation.
> + *
> + * This file is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + * b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */
Patch looks good.
Just a comment: people have been starting to use SPDX license identifiers.
This would really make all this huge license text much shorter :-)
^ permalink raw reply
* [PATCH 8/9] ARM: dts: imx7-colibri: add MCP2515 CAN controller
From: Fabio Estevam @ 2017-12-16 14:05 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171206153005.6144-8-stefan@agner.ch>
On Wed, Dec 6, 2017 at 1:30 PM, Stefan Agner <stefan@agner.ch> wrote:
> +&ecspi3 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ecspi3 &pinctrl_ecspi3_cs>;
> + num-cs = <1>;
num-cs can be dropped.
^ permalink raw reply
* [PATCH 7/9] ARM: dts: imx7-colibri: specify backlight GPIO
From: Fabio Estevam @ 2017-12-16 14:03 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171206153005.6144-7-stefan@agner.ch>
On Wed, Dec 6, 2017 at 1:30 PM, Stefan Agner <stefan@agner.ch> wrote:
> The Colibri standard defines SODIMM 71 as backlight enable
> GPIO. Assign the GPIO to the backlight node in the module
> level device tree.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply
* [PATCH 6/9] ARM: dts: imx7-colibri: specify usdhc1 supplies
From: Fabio Estevam @ 2017-12-16 14:03 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171206153005.6144-6-stefan@agner.ch>
On Wed, Dec 6, 2017 at 1:30 PM, Stefan Agner <stefan@agner.ch> wrote:
> The usdhc1 controller instance is used to provide the default
> SD/MMC capabilities of the Colibri standard. The IO pins are
> supplied to the SoC on the module whereas the SD-card is powered
> by the Carrier Board supply.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply
* [PATCH 4/9] ARM: dts: imx7-colibri: use NAND_CE1 as GPIO
From: Fabio Estevam @ 2017-12-16 14:02 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171206153005.6144-4-stefan@agner.ch>
On Wed, Dec 6, 2017 at 1:30 PM, Stefan Agner <stefan@agner.ch> wrote:
> All Colibri iMX7 SKUs use either single-die NAND or eMMC, hence
> NAND_CE1 is not used on the module and can be used as a GPIO by
> carrier boards.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply
* [PATCH 3/9] ARM: dts: imx7-colibri: mux pull-ups where appropriate
From: Fabio Estevam @ 2017-12-16 14:02 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171206153005.6144-3-stefan@agner.ch>
On Wed, Dec 6, 2017 at 1:29 PM, Stefan Agner <stefan@agner.ch> wrote:
> Use pull-ups instead of pull-downs for the pins which are already
> pulled-up externally.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply
* [PATCH 2/9] ARM: dts: imx7-colibri: make sure multiplexed pins are not active
From: Fabio Estevam @ 2017-12-16 14:01 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171206153005.6144-2-stefan@agner.ch>
On Wed, Dec 6, 2017 at 1:29 PM, Stefan Agner <stefan@agner.ch> wrote:
> The Colibri pins PWM<A> and <D> are multiplexed on the module, make
> sure the secondary SoC pin is not active.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
I haven't really understood the commit message, but this is probably
because I don't have access to the schematics.
Anyway:
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply
* [PATCH 1/9] ARM: dts: imx7-colibri: move and rename USB Host power regulator
From: Fabio Estevam @ 2017-12-16 14:00 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171206153005.6144-1-stefan@agner.ch>
On Wed, Dec 6, 2017 at 1:29 PM, Stefan Agner <stefan@agner.ch> wrote:
> The Colibri default which enables USB Host power is not necessarily
> tied to the OTG2 controller, some carrier board use the pin to
> control USB power for both controllers. Hence name the pinctrl
> group more generic.
>
> Also move the regulator to the generic eval-v3 device tree since
> the regulator is always on the carrier board. In the Colibri iMX7S
> case the regulator is just not used. This allows to reuse the
> regulator in a upcoming SKU Colibri iMX7D 1GB with eMMC.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply
* [PATCH 5/9] ARM: dts: imx7-colibri: specify cpu-supply
From: Fabio Estevam @ 2017-12-16 13:59 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171206153005.6144-5-stefan@agner.ch>
Hi Stefan,
On Wed, Dec 6, 2017 at 1:30 PM, Stefan Agner <stefan@agner.ch> wrote:
> Specify CPU supply using the "cpu-supply" property instead of
> the invalid "arm-supply" property.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> arch/arm/boot/dts/imx7-colibri.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi
> index f61041af026a..6498c1136ef1 100644
> --- a/arch/arm/boot/dts/imx7-colibri.dtsi
> +++ b/arch/arm/boot/dts/imx7-colibri.dtsi
> @@ -86,7 +86,7 @@
> };
>
> &cpu0 {
> - arm-supply = <®_DCDC2>;
> + cpu-supply = <®_DCDC2>;
Good catch. I need to apply this same fix for some other imx7 board dts:
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply
* [PATCH 00/20] Add Hummingboard 2 support
From: Fabio Estevam @ 2017-12-16 13:58 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171211165631.GW10595@n2100.armlinux.org.uk>
On Mon, Dec 11, 2017 at 2:56 PM, Russell King - ARM Linux
<linux@armlinux.org.uk> wrote:
> Hi,
>
> This series adds the long awaited Hummingboard 2 support to the
> mainline kernel.
>
> While I could squash the patch set down, I've not done this because
> this is the result of several different people over the course of
> the last couple of years, and I believe it's not right to lose the
> detail of their contributions.
>
> This builds upon the previous set of changes for the Hummingboard,
> which re-organised the way we deal with the uSOM and baseboards.
For the series:
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply
* [PATCH] drivers: gpio: remove duplicate includes
From: Pravin Shedge @ 2017-12-16 12:56 UTC (permalink / raw)
To: linux-arm-kernel
These duplicate includes have been found with scripts/checkincludes.pl
but they have been removed manually to avoid removing false positives.
Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
---
drivers/gpio/gpio-brcmstb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
index 545d43a..3dcbead 100644
--- a/drivers/gpio/gpio-brcmstb.c
+++ b/drivers/gpio/gpio-brcmstb.c
@@ -19,7 +19,6 @@
#include <linux/irqdomain.h>
#include <linux/irqchip/chained_irq.h>
#include <linux/interrupt.h>
-#include <linux/bitops.h>
enum gio_reg_index {
GIO_REG_ODEN = 0,
--
2.7.4
^ permalink raw reply related
* [PATCH v3 01/11] dt-bindings: thermal: Describe Armada AP806 and CP110
From: Miquel RAYNAL @ 2017-12-16 12:50 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171215232854.n23biqelqoqjsevm@rob-hp-laptop>
Hello Rob,
On Fri, 15 Dec 2017 17:28:54 -0600
Rob Herring <robh@kernel.org> wrote:
> On Fri, Dec 15, 2017 at 11:52:30AM +0100, Miquel RAYNAL wrote:
> > Hello Baruch and Gregory,
> >
> > On Fri, 15 Dec 2017 09:44:19 +0100
> > Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:
> >
> > > Hi Miquel,
> > >
> > > On ven., d?c. 15 2017, Miquel RAYNAL
> > > <miquel.raynal@free-electrons.com> wrote:
> > >
> > > > Hello Baruch,
> > > >
> > > > On Fri, 15 Dec 2017 10:27:59 +0200
> > > > Baruch Siach <baruch@tkos.co.il> wrote:
> > > >
> > > >> Hi Miquel
> > > >>
> > > >> On Thu, Dec 14, 2017 at 11:30:01AM +0100, Miquel Raynal
> > > >> wrote:
> > > >> > +- marvell,thermal-zone-name: The name to identify the
> > > >> > thermal zone
> > > >> > + within the sysfs, useful when
> > > >> > multiple
> > > >> > + thermal zones are registered
> > > >> > (AP, CPx...).
> > > >>
> > > >> I don't think that would be acceptable. DT is about describing
> > > >> the hardware. sysfs is a Linux implementation detail which is
> > > >> not tied to any specific hardware. If this is accepted, the
> > > >> property should be named 'linux,thermal-zone-name'.
> > > >
> > > > You are right the sysfs mention should not appear in the
> > > > description.
> >
> > Actually, you are right for all of it, this property should not
> > exist, sorry for my too quick answer.
> >
> > > >
> > > > Otherwise for the naming I'm not sure "linux," is a valid
> > > > prefix in that case.
> >
> > Thank you both for your explanations, I was also wrong about the
> > prefix.
> > >
> > > Actually the choice between linux or marvell make me realize that
> > > there is something wrong. Having a name associated to a device is
> > > something pretty usual with the device tree, however it is as the
> > > class device level, such as clock-names, line-name, or
> > > regulator-name. So in my opinion if we want to support naming from
> > > device tree it would be done for all the thermal device not just
> > > for the Marvell one.
> > >
> > > However I don't think we need it. For example for the clocks we
> > > created the name dynamically using of the base address of the
> > > register to keep them unique.
> >
> > I was convinced that dev_name's would be the same but after trying
> > it on a 8040-DB, using dev_name(&pdev->dev) gives:
> >
> > f06f808c.thermal
> > f2400078.thermal
> > f4400078.thermal
> >
> > which I found meaningful enough.
> >
> > I will drop the property and use dev_name instead. I still need your
> > help to solve one problem though: how to make the distinction
> > between using "armada_thermal" (the previous name) and dev_name() ?
> > If I don't it kind of breaks userspace, doesn't it ?
>
> No. The /sys/devices/... or /sys/bus/platform/... paths and names are
> not guaranteed to be stable. These changed for every platform
> converted to DT for example. Userspace should be accessing things
> through /sys/class/... (or deal with changes).
Ok, thanks for the explanation.
I will sent a v4 early next week about all the changes requested.
Thank you all for reviewing.
Miqu?l
^ permalink raw reply
* [PATCH] ARM: dts: imx6q-h100: use usdhc2 VSELECT
From: Fabio Estevam @ 2017-12-16 12:47 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <20171215092624.12806-1-m.tretter@pengutronix.de>
Hi Michael,
On Fri, Dec 15, 2017 at 7:26 AM, Michael Tretter
<m.tretter@pengutronix.de> wrote:
> The uSDHC controller directly provides a VSELECT signal that can be
> muxed to the external voltage select. Mux the VSELECT directly to avoid
> using a GPIO.
>
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
Much simpler :-)
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox