From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Yuanjie Yang <quic_yuanjiey@quicinc.com>,
ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, bhupesh.sharma@linaro.org,
andersson@kernel.org, konradybcio@kernel.org,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
quic_tingweiz@quicinc.com
Subject: Re: [PATCH v3 1/2] arm64: dts: qcom: qcs615: add SDHC1 and SDHC2
Date: Tue, 26 Nov 2024 10:26:57 +0100 [thread overview]
Message-ID: <03b6f863-ccdd-4e07-9574-ee9dd7c20ab5@kernel.org> (raw)
In-Reply-To: <frjnnd7bvrdn5frfo4xnz35rb5zxa33eayu3oc5wux7casay64@t2tfbsf5jrva>
On 26/11/2024 01:07, Dmitry Baryshkov wrote:
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
>>> index 590beb37f441..37c6ab217c96 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
>>> @@ -399,6 +399,65 @@ qfprom: efuse@780000 {
>>> #size-cells = <1>;
>>> };
>>>
>>> + sdhc_1: mmc@7c4000 {
>>> + compatible = "qcom,qcs615-sdhci", "qcom,sdhci-msm-v5";
>>> + reg = <0x0 0x007c4000 0x0 0x1000>,
>>> + <0x0 0x007c5000 0x0 0x1000>;
>>> + reg-names = "hc",
>>> + "cqhci";
>>
>> There's an "ice" region at 0x007c8000
>
> Shouldn't ice now be handled by a separate device?
It should and UFS bindings expect that. However I am not sure if MMC was
improved to support external ICE device. Also for example on SM8550 the
ICE has entirely different (further) address space, so it also suggests
it is separate device. Here address space looks almost continuous.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-26 9:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 6:50 [PATCH v3 0/2] Enable SDHC1 and SDHC2 on QCS615 Yuanjie Yang
2024-11-22 6:51 ` [PATCH v3 1/2] arm64: dts: qcom: qcs615: add SDHC1 and SDHC2 Yuanjie Yang
2024-11-22 7:04 ` Krzysztof Kozlowski
2024-11-22 8:40 ` Yuanjie Yang
2024-11-22 12:35 ` Krzysztof Kozlowski
2024-11-25 2:20 ` Yuanjie Yang
2024-11-25 7:35 ` Krzysztof Kozlowski
[not found] ` <Z0Qv8lh1I7yeS4W+@cse-cd02-lnx.ap.qualcomm.com>
[not found] ` <ddedecca-4241-4a5b-876e-a2724d361e74@kernel.org>
2024-11-25 8:52 ` Yuanjie Yang
2024-11-25 12:50 ` Konrad Dybcio
2024-11-25 13:13 ` Konrad Dybcio
2024-11-26 0:07 ` Dmitry Baryshkov
2024-11-26 9:26 ` Krzysztof Kozlowski [this message]
2024-11-28 20:51 ` Konrad Dybcio
2024-11-26 9:07 ` Yuanjie Yang
2024-11-26 9:11 ` Yuanjie Yang
2024-11-22 6:51 ` [PATCH v3 2/2] arm64: dts: qcom: qcs615-ride: enable " Yuanjie Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03b6f863-ccdd-4e07-9574-ee9dd7c20ab5@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_yuanjiey@quicinc.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox