Re: [PATCH] media: venus: core: Drop local dma_parms

[Robin Murphy <robin.murphy@arm.com>]

On 2020-10-06 06:23, Sai Prakash Ranjan wrote:
> On 2020-10-06 06:32, Stephen Boyd wrote:
>> Quoting Sai Prakash Ranjan (2020-10-02 05:45:03)
>>> On 2020-10-02 16:57, Stanimir Varbanov wrote:
>>> > On 10/2/20 11:06 AM, Sai Prakash Ranjan wrote:
>>> >> On 2020-09-04 02:44, Robin Murphy wrote:
>>> >>> Since commit 9495b7e92f71 ("driver core: platform: Initialize
>>> >>> dma_parms
>>> >>> for platform devices"), struct platform_device already provides a
>>> >>> dma_parms structure, so we can save allocating another one.
>>> >>
>>> >
>>> > Do you have the mentioned above commit when you see this warning ?
>>>
>>> +Stephen reported this, this was recently backported to 5.4 kernel
>>> where playing youtube with dma api debug enabled would throw this
>>> warning and I am almost 100% certain this is the commit which caused
>>> the warning to appear again.
>>>
>>
>> We don't have commit 9495b7e92f71 though so I guess we need that one
>> if we take this patch.
> 
> Oh so Stan was referring to that commit, oops my bad. I thought
> he was referring to this patch. So I suppose everything is good
> if we backport both patches.

Right, this patch is just some trivial housekeeping which certainly 
doesn't deserve backporting in its own right. However if it's because 
you're doing something like backporting an entire chunk of the media 
tree as a unit, then yeah, you'll need to track down all the functional 
dependencies, especially any that *weren't* helpfully called out in 
commit messages ;)

Robin.