From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
andersson@kernel.org, konradybcio@kernel.org,
sudeep.holla@kernel.org, angelogioacchino.delregno@collabora.com,
viresh.kumar@linaro.org, neil.armstrong@linaro.org,
festevam@gmail.com, Frank.Li@nxp.com, danila@jiaxyga.com,
lpieralisi@kernel.org, dmitry.baryshkov@oss.qualcomm.com,
tengfei.fan@oss.qualcomm.com, jingyi.wang@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH 3/3] arm64: dts: qcom: kaanapali: Fix deprecated cpu compatibles
Date: Wed, 11 Mar 2026 11:21:10 +0100 [thread overview]
Message-ID: <0469c476-cf42-46ed-a9e5-b6f10cb61770@kernel.org> (raw)
In-Reply-To: <20260311-observant-cyber-griffin-ace587@quoll>
On 11/03/2026 11:04, Krzysztof Kozlowski wrote:
> On Tue, Mar 10, 2026 at 09:37:51AM +0530, Sibi Sankar wrote:
>> The generic Qualcomm Oryon CPU compatible used by the Kaanapali
>> SoC is deprecated and incorrect since it uses a single compatible
>> to describe two different core variants. It is now replaced with
>> two different core-specific compatibles based on MIDR part and
>> variant number.
>>
>> CPUS 0-5:
>> MIDR_EL1[PART_NUM] - 0x2
>> MIDR_EL1[VARIANT] - 0x2
>>
>> CPUS 6-7:
>> MIDR_EL1[PART_NUM] - 0x2
>> MIDR_EL1[VARIANT] - 0x3
>>
>> Fixes: 2eeb5767d53f ("arm64: dts: qcom: Introduce Kaanapali SoC")
>> Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> I explained you in off-list communication what you have to do - this
> MUST go via fixes and you MUST annotate that.
>
> Where did you describe that? Nothing in cover letter, nothing here.
Although then binding should go via fixes but it depends on patch in
next branch, so it cannot be done. Sorry, this waited way tooooo long,
so you cannot make this change anymore.
Please drop it and you are stuck with the compatible you sent earlier,
which reviewers requested multiple times to change.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-11 10:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 4:07 [PATCH 0/3] dt-bindings: arm: cpus: Extend Qualcomm Oryon compatibles Sibi Sankar
2026-03-10 4:07 ` [PATCH 1/3] " Sibi Sankar
2026-03-11 10:03 ` Krzysztof Kozlowski
2026-03-11 10:21 ` Sibi Sankar
2026-03-10 4:07 ` [PATCH 2/3] arm64: dts: qcom: glymur: Fix deprecated cpu compatibles Sibi Sankar
2026-03-10 4:07 ` [PATCH 3/3] arm64: dts: qcom: kaanapali: " Sibi Sankar
2026-03-11 10:04 ` Krzysztof Kozlowski
2026-03-11 10:21 ` Krzysztof Kozlowski [this message]
2026-03-11 10:32 ` Sibi Sankar
2026-03-11 10:36 ` Krzysztof Kozlowski
2026-03-11 10:38 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0469c476-cf42-46ed-a9e5-b6f10cb61770@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=danila@jiaxyga.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=festevam@gmail.com \
--cc=jingyi.wang@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=sibi.sankar@oss.qualcomm.com \
--cc=sudeep.holla@kernel.org \
--cc=tengfei.fan@oss.qualcomm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox