Re: [PATCH v1 3/8] arm64: dts: qcom: qcs6490-rb3gen2: Modify WSA and VA macro clock nodes for audioreach solution

[Prasad Kumpatla <quic_pkumpatl@quicinc.com>]

On 4/4/2025 12:42 PM, Luca Weiss wrote:
> Hi Konrad,
> 
> On Tue Apr 1, 2025 at 6:05 PM CEST, Konrad Dybcio wrote:
>> On 3/17/25 6:41 AM, Prasad Kumpatla wrote:
>>> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>>>
>>> Modify and enable WSA, VA and lpass_tlmm clock properties.
>>> For audioreach solution mclk, npl and fsgen clocks
>>> are enabled through the q6prm clock driver.
>>>
>>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>>> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>>> ---
>>
>> Instead, put the inverse changes in sc7280-chrome-common.dtsi please
> 
> How are we going to handle other sc7280-based platforms, such as my
> QCM6490 Fairphone 5 needing to use q6afecc instead of q6prmcc which gets
> used in this patchset?
> 
> One solution might be to put q6afecc into the base sc7280.dtsi file,
> then we have a sc7280-audioreach.dtsi which overwrites q6afecc with
> q6prmcc which then gets included by boards using audioreach.
> 
> I also don't think we can split this across sc7280 vs qcm6490 vs sm7325,
> there seems to be any combination possible on any of these SoCs -
> depending on the firmware shipped with it.
> 
> So somewhat similar to the current sc7280-chrome-common.dtsi but just
> for audioreach.
> 
> Regards
> Luca
ACK, We will handle in next patchset version by creating a new 
qcs6490-audioreach.dtsi file.

Thanks,
Prasad>
>>
>> Konrad
>