Re: [PATCH v1 5/8] arm64: dts: qcom: qcs6490-rb3gen2: Add sound card

[Prasad Kumpatla <quic_pkumpatl@quicinc.com>]

On 4/2/2025 3:02 AM, Konrad Dybcio wrote:
> On 3/17/25 6:41 AM, Prasad Kumpatla wrote:
>> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>>
>> Add the sound card node with tested playback over WSA8835 speakers
>> and msm mics.
>>
>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 80 ++++++++++++++++++++
>>   1 file changed, 80 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> index a1a3df77ad57..5d4d3df6eff9 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> @@ -219,6 +219,56 @@ vph_pwr: vph-pwr-regulator {
>>   		regulator-min-microvolt = <3700000>;
>>   		regulator-max-microvolt = <3700000>;
>>   	};
>> +
>> +	sound: sound {
> 
> The label is not used, please drop

ACK,
Will fix it.

> 
>> +		compatible = "qcom,qcs6490-rb3gen2-sndcard";
>> +		model = "qcs6490-rb3gen2-snd-card";
>> +
>> +		audio-routing =
> 
> Please don't break the line here

Yes, Will update.

> 
>> +			"SpkrLeft IN", "WSA_SPK1 OUT",
>> +			"SpkrRight IN", "WSA_SPK2 OUT",
>> +			"VA DMIC0", "vdd-micb",
>> +			"VA DMIC1", "vdd-micb",
>> +			"VA DMIC2", "vdd-micb",
>> +			"VA DMIC3", "vdd-micb";
>> +
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +
>> +		wsa-dai-link {
>> +			link-name = "CODEC_DMA-LPAIF_WSA-RX-0";
> 
> Very unusual link name

ACK,
Will check and update.

> 
>> +
>> +			cpu {
>> +				sound-dai = <&q6apmbedai WSA_CODEC_DMA_RX_0>;
>> +			};
>> +
>> +			codec {
>> +				sound-dai = <&left_spkr>, <&right_spkr>, <&swr2 0>,
>> +					    <&lpass_wsa_macro 0>;
>> +			};
> 
> 'co'dec < 'cp'u

ACK,
Will update in next patchset.

Thanks,
Prasad

> 
> 
> Konrad