From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>,
lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, sboyd@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, alexey.klimov@linaro.org,
r.mereu@arduino.cc, srini@kenrel.org
Subject: Re: [PATCH v2 3/5] arm64: dts: qcom: agatti: add LPASS devices
Date: Tue, 24 Feb 2026 13:28:49 +0100 [thread overview]
Message-ID: <07cb095b-7765-4810-a8e3-db2bd9ba6276@oss.qualcomm.com> (raw)
In-Reply-To: <20260223133950.221234-4-srinivas.kandagatla@oss.qualcomm.com>
On 2/23/26 2:39 PM, Srinivas Kandagatla wrote:
> From: Alexey Klimov <alexey.klimov@linaro.org>
>
> The rxmacro, txmacro, vamacro, soundwire nodes, lpass clock
> controllers are required to support audio playback and
> audio capture on sm6115 and its derivatives.
>
> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> ---
[...]
> + lpass_audiocc: clock-controller@a6a9000 {
> + compatible = "qcom,sm6115-lpassaudiocc";
> + reg = <0x0 0x0a6a9000 0x0 0x1000>;
> + #reset-cells = <1>;
> + };
This should be called "qcom,sm6115-lpass-audio-csr" and should probably
have a syscon fallback as there's a lot of various magic tunables in
there, in addition to the CGCR bits. The clock driver can continue to
bind to this new compatible, like we do with the SoC-side TCSR on e.g.
8550 and the tcsrcc-sm8550 driver.
[...]
> + lpasscc: clock-controller@a7ec000 {
> + compatible = "qcom,sm6115-lpasscc";
> + reg = <0x0 0x0a7e0000 0x0 0x12000>;
> + #reset-cells = <1>;
> + };
All the same, except "qcom,sm6115-lpass-tcsr"
I'm once again sorry for not getting this right n years ago, but I did not
have the sufficient documentation back then
Konrad
next prev parent reply other threads:[~2026-02-24 12:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 13:39 [PATCH v2 0/5] arm64: dts: arduino-imola: add support for sound Srinivas Kandagatla
2026-02-23 13:39 ` [PATCH v2 1/5] clk: qcom: fix SM6115 lpasscc register offset Srinivas Kandagatla
2026-02-24 12:20 ` Konrad Dybcio
2026-02-23 13:39 ` [PATCH v2 2/5] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for pm4124-codec Srinivas Kandagatla
2026-02-23 16:56 ` Rob Herring
2026-02-23 18:14 ` Srinivas Kandagatla
2026-02-23 13:39 ` [PATCH v2 3/5] arm64: dts: qcom: agatti: add LPASS devices Srinivas Kandagatla
2026-02-24 2:58 ` Dmitry Baryshkov
2026-02-24 12:24 ` Konrad Dybcio
2026-02-24 12:28 ` Konrad Dybcio [this message]
2026-05-15 8:29 ` Srinivas Kandagatla
2026-02-23 13:39 ` [PATCH v2 4/5] arm64: dts: arduino-imola: add support for sound Srinivas Kandagatla
2026-02-24 11:48 ` Konrad Dybcio
2026-02-23 13:39 ` [PATCH v2 5/5] arm64: defconfig: Enable configs for audio drivers on Arduino UnoQ Srinivas Kandagatla
2026-02-24 2:57 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07cb095b-7765-4810-a8e3-db2bd9ba6276@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=alexey.klimov@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=r.mereu@arduino.cc \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=srini@kenrel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox