* [PATCH 3/3] arm64: dts: qcom: Add EC to Lenovo Yoga Slim 7x
[not found] <20240927185345.3680-1-maccraft123mc@gmail.com>
@ 2024-09-27 18:53 ` Maya Matuszczyk
2024-09-30 3:10 ` Bjorn Andersson
2024-09-30 12:45 ` Konrad Dybcio
0 siblings, 2 replies; 3+ messages in thread
From: Maya Matuszczyk @ 2024-09-27 18:53 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Maya Matuszczyk, linux-arm-msm, devicetree, linux-kernel
This device has an EC on i2c5 bus at address 0x76, driver for the EC was
added in a previous patch.
Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
---
.../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 22 +++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
index 3c13331a9ef4..63b627f60ec7 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
@@ -536,6 +536,22 @@ keyboard@3a {
};
};
+&i2c5 {
+ clock-frequency = <400000>;
+
+ status = "okay";
+
+ embedded-controller@76 {
+ compatible = "lenovo,yoga-slim7x-ec";
+ reg = <0x76>;
+
+ interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>;
+
+ pinctrl-0 = <&ec_int_n_default>;
+ pinctrl-names = "default";
+ };
+};
+
&i2c8 {
clock-frequency = <400000>;
@@ -794,6 +810,12 @@ &tlmm {
<44 4>, /* SPI (TPM) */
<238 1>; /* UFS Reset */
+ ec_int_n_default: ec-int-n-state {
+ pins = "gpio66";
+ function = "gpio";
+ bias-disable;
+ };
+
edp_reg_en: edp-reg-en-state {
pins = "gpio70";
function = "gpio";
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: Add EC to Lenovo Yoga Slim 7x
2024-09-27 18:53 ` [PATCH 3/3] arm64: dts: qcom: Add EC to Lenovo Yoga Slim 7x Maya Matuszczyk
@ 2024-09-30 3:10 ` Bjorn Andersson
2024-09-30 12:45 ` Konrad Dybcio
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2024-09-30 3:10 UTC (permalink / raw)
To: Maya Matuszczyk
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-msm, devicetree, linux-kernel
On Fri, Sep 27, 2024 at 08:53:42PM GMT, Maya Matuszczyk wrote:
> This device has an EC on i2c5 bus at address 0x76, driver for the EC was
> added in a previous patch.
>
No concerns with this patch, but please Cc: at least all the mailing
lists on each patch, so that I get all the patches in the series.
Or better yet, take a look at
https://b4.docs.kernel.org/en/latest/contributor/overview.html which
magically handles this for you (b4 prep --auto-to-cc).
Regards,
Bjorn
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> ---
> .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> index 3c13331a9ef4..63b627f60ec7 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> @@ -536,6 +536,22 @@ keyboard@3a {
> };
> };
>
> +&i2c5 {
> + clock-frequency = <400000>;
> +
> + status = "okay";
> +
> + embedded-controller@76 {
> + compatible = "lenovo,yoga-slim7x-ec";
> + reg = <0x76>;
> +
> + interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>;
> +
> + pinctrl-0 = <&ec_int_n_default>;
> + pinctrl-names = "default";
> + };
> +};
> +
> &i2c8 {
> clock-frequency = <400000>;
>
> @@ -794,6 +810,12 @@ &tlmm {
> <44 4>, /* SPI (TPM) */
> <238 1>; /* UFS Reset */
>
> + ec_int_n_default: ec-int-n-state {
> + pins = "gpio66";
> + function = "gpio";
> + bias-disable;
> + };
> +
> edp_reg_en: edp-reg-en-state {
> pins = "gpio70";
> function = "gpio";
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: Add EC to Lenovo Yoga Slim 7x
2024-09-27 18:53 ` [PATCH 3/3] arm64: dts: qcom: Add EC to Lenovo Yoga Slim 7x Maya Matuszczyk
2024-09-30 3:10 ` Bjorn Andersson
@ 2024-09-30 12:45 ` Konrad Dybcio
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2024-09-30 12:45 UTC (permalink / raw)
To: Maya Matuszczyk, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 27.09.2024 8:53 PM, Maya Matuszczyk wrote:
> This device has an EC on i2c5 bus at address 0x76, driver for the EC was
> added in a previous patch.
>
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konradybcio@kernel.org>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-30 12:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240927185345.3680-1-maccraft123mc@gmail.com>
2024-09-27 18:53 ` [PATCH 3/3] arm64: dts: qcom: Add EC to Lenovo Yoga Slim 7x Maya Matuszczyk
2024-09-30 3:10 ` Bjorn Andersson
2024-09-30 12:45 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox