From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pratyush Brahma <quic_pbrahma@quicinc.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v5 2/2] arm64: dts: qcom: qcs8300: Add device node for gfx_smmu
Date: Wed, 12 Feb 2025 06:37:50 +0100 [thread overview]
Message-ID: <09922fcf-f667-490b-bbd2-e5fc19c3f958@kernel.org> (raw)
In-Reply-To: <075588ff-77e5-4b01-8c67-8fc30e51b8a9@quicinc.com>
On 12/02/2025 06:19, Pratyush Brahma wrote:
>
> On 2/12/2025 10:09 AM, Pratyush Brahma wrote:
>>
>>
>> On 2/11/2025 8:45 PM, Krzysztof Kozlowski wrote:
>>> On 11/02/2025 05:45, Pratyush Brahma wrote:
>>>> Add the device node for gfx smmu that is required for gpu
>>>> specific address translations.
>>>>
>>>> Signed-off-by: Pratyush Brahma<quic_pbrahma@quicinc.com>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/qcs8300.dtsi | 39 +++++++++++++++++++++++++++++++++++
>>>> 1 file changed, 39 insertions(+)
>>> As pointed out by Rob, this wasn't ever tested. One more example of work
>>> where you have the binding in the same patch but refuse to use it.
> No, I had tested these patches against the dt_bindings_check and didn't
> see these errors.
> It seems I need to upgrade my dtschema as Rob pointed out, reorder the
> clocks and resend.
The reported errors are not relevant at all to upgraded or not upgraded
dtschema. This just wasn't tested.
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-12 5:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 4:45 [PATCH v5 0/2] Add support for GPU SMMU on QCS8300 Pratyush Brahma
2025-02-11 4:45 ` [PATCH v5 1/2] dt-bindings: arm-smmu: Document QCS8300 GPU SMMU Pratyush Brahma
2025-02-11 4:45 ` [PATCH v5 2/2] arm64: dts: qcom: qcs8300: Add device node for gfx_smmu Pratyush Brahma
2025-02-11 15:15 ` Krzysztof Kozlowski
[not found] ` <138b1c42-9580-41f4-9079-87740568b79c@quicinc.com>
2025-02-12 5:19 ` Pratyush Brahma
2025-02-12 5:37 ` Krzysztof Kozlowski [this message]
2025-02-11 13:28 ` [PATCH v5 0/2] Add support for GPU SMMU on QCS8300 Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09922fcf-f667-490b-bbd2-e5fc19c3f958@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_pbrahma@quicinc.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox