From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pratyush Brahma <quic_pbrahma@quicinc.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v5 2/2] arm64: dts: qcom: qcs8300: Add device node for gfx_smmu
Date: Tue, 11 Feb 2025 16:15:15 +0100 [thread overview]
Message-ID: <3158e911-c771-4186-b287-50d2395b8c94@kernel.org> (raw)
In-Reply-To: <20250211-b4-branch-gfx-smmu-v5-2-ff0bcb6a3c51@quicinc.com>
On 11/02/2025 05:45, Pratyush Brahma wrote:
> Add the device node for gfx smmu that is required for gpu
> specific address translations.
>
> Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qcs8300.dtsi | 39 +++++++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
As pointed out by Rob, this wasn't ever tested. One more example of work
where you have the binding in the same patch but refuse to use it.
NAK
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-11 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 4:45 [PATCH v5 0/2] Add support for GPU SMMU on QCS8300 Pratyush Brahma
2025-02-11 4:45 ` [PATCH v5 1/2] dt-bindings: arm-smmu: Document QCS8300 GPU SMMU Pratyush Brahma
2025-02-11 4:45 ` [PATCH v5 2/2] arm64: dts: qcom: qcs8300: Add device node for gfx_smmu Pratyush Brahma
2025-02-11 15:15 ` Krzysztof Kozlowski [this message]
[not found] ` <138b1c42-9580-41f4-9079-87740568b79c@quicinc.com>
2025-02-12 5:19 ` Pratyush Brahma
2025-02-12 5:37 ` Krzysztof Kozlowski
2025-02-11 13:28 ` [PATCH v5 0/2] Add support for GPU SMMU on QCS8300 Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3158e911-c771-4186-b287-50d2395b8c94@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_pbrahma@quicinc.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox