Re: [PATCH v6 11/11] Documentation: document adreno preemption

[Antonino Maniscalco <antomani103@gmail.com>]

On 10/1/24 3:10 AM, Bagas Sanjaya wrote:
> On Thu, Sep 26, 2024 at 11:16:53PM +0200, Antonino Maniscalco wrote:
>> +.. SPDX-License-Identifier: GPL-2.0
>> +
>> +:orphan:
> 
> Why don't this be added to toctree in Documentation/gpu/index.rst?

Yes so there is existing orphan documentation for msm so my intention 
was to add it as orphan then eventually send out a series to organize it 
properly (so creating an msm directory with an index which then points 
two files we currently have). Does that sound good to you?

> 
>> +
>> +=============
>> +MSM Preemtion
>> +=============
> s/Preemtion/Preemption/

Thanks for pointing out the typo!

> 
> 
>> +This mechanism can be used by the kernel to switch between rings. Whenever a
>> +submission occurs the kernel finds the highest priority ring which isn't empty
>> +and preempts to it if said ring is not the one being currently executed. This is
>> +also done whenever a submission completes to make sure execution resumes on a
>> +lower priority ring when a higher priority ring is done.
> 
> Do you mean that the kernel finds highest priority ring possible that is not
> empty? What if all these 4 rings are empty?
> 
> Confused...
> 

Yep, if all rings are empty we don't preempt, same as when the highest 
priority ring is the current one.

Best regards,
-- 
Antonino Maniscalco <antomani103@gmail.com>